| Message ID | 20180202154706.1624997-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | vxfs: fix building with LTO | expand |
Looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/freevxfs/vxfs_subr.c b/fs/freevxfs/vxfs_subr.c index e806694d4145..8e213cce586f 100644 --- a/fs/freevxfs/vxfs_subr.c +++ b/fs/freevxfs/vxfs_subr.c @@ -46,7 +46,7 @@ const struct address_space_operations vxfs_aops = { .bmap = vxfs_bmap, }; -inline void +void vxfs_put_page(struct page *pp) { kunmap(pp);
When link-time optimizations are enabled, vxfs fails to build: fs/freevxfs/vxfs_lookup.c: In function 'vxfs_readdir': fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow vxfs_put_page(struct page *pp) ^ fs/freevxfs/vxfs_lookup.c:291:3: note: called from here vxfs_put_page(pp); ^ fs/freevxfs/vxfs_inode.c: In function '__vxfs_iget': fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow fs/freevxfs/vxfs_lookup.c: In function 'vxfs_lookup': fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow This removes the 'inline' annotation that obviously doesn't do much anyway. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- fs/freevxfs/vxfs_subr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0