diff mbox series

tools/mrvl_uart.sh: Fix minicom baudrate

Message ID 20180120120709.24023-1-afaerber@suse.de
State Accepted
Commit 3e00c48ef05bfe1a16f57dd0610ed2fa78774d63
Headers show
Series tools/mrvl_uart.sh: Fix minicom baudrate | expand

Commit Message

Andreas Färber Jan. 20, 2018, 12:07 p.m. UTC
minicom doesn't inherit the baudrate from stty but uses its own
defaults, such as for example 57600, whereas we expect 115200 here.
Explicitly tell minicom which baudrate to use.

Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
Cc: Konstantin Porotchkin <kostap@marvell.com>
Cc: Stefan Roese <sr@denx.de>
Cc: Igal Liberman <igall@marvell.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 tools/mrvl_uart.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kostya Porotchkin Jan. 21, 2018, 9:08 a.m. UTC | #1
> -----Original Message-----

> From: Andreas Färber [mailto:afaerber@suse.de]

> Sent: Saturday, January 20, 2018 14:07

> To: u-boot@lists.denx.de

> Cc: Andreas Färber; Kostya Porotchkin; Stefan Roese; Igal Liberman

> Subject: [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate

> 

> minicom doesn't inherit the baudrate from stty but uses its own

> defaults, such as for example 57600, whereas we expect 115200 here.

> Explicitly tell minicom which baudrate to use.

> 

> Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")

> Cc: Konstantin Porotchkin <kostap@marvell.com>

> Cc: Stefan Roese <sr@denx.de>

> Cc: Igal Liberman <igall@marvell.com>

> Signed-off-by: Andreas Färber <afaerber@suse.de>

> ---

>  tools/mrvl_uart.sh | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh index

> 6b04d7ae2c..500fa117eb 100755

> --- a/tools/mrvl_uart.sh

> +++ b/tools/mrvl_uart.sh

> @@ -115,5 +115,5 @@ sx -vv $file > $port < $port  stty -F $port raw

> ignbrk time 5 $default_baudrate

> 

>  # Optional - fire up Minicom

> -minicom -D $port

> +minicom -D $port -b $default_baudrate

> 

> --

> 2.13.6

Reviewed-by: Konstantin Porotchkin <kostap@marvell.com>
Stefan Roese Jan. 22, 2018, 8:47 a.m. UTC | #2
On 20.01.2018 13:07, Andreas Färber wrote:
> minicom doesn't inherit the baudrate from stty but uses its own
> defaults, such as for example 57600, whereas we expect 115200 here.
> Explicitly tell minicom which baudrate to use.
> 
> Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Igal Liberman <igall@marvell.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   tools/mrvl_uart.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh
> index 6b04d7ae2c..500fa117eb 100755
> --- a/tools/mrvl_uart.sh
> +++ b/tools/mrvl_uart.sh
> @@ -115,5 +115,5 @@ sx -vv $file > $port < $port
>   stty -F $port raw ignbrk time 5 $default_baudrate
>   
>   # Optional - fire up Minicom
> -minicom -D $port
> +minicom -D $port -b $default_baudrate
>   
> 

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Stefan Roese Jan. 29, 2018, 12:40 p.m. UTC | #3
On 20.01.2018 13:07, Andreas Färber wrote:
> minicom doesn't inherit the baudrate from stty but uses its own
> defaults, such as for example 57600, whereas we expect 115200 here.
> Explicitly tell minicom which baudrate to use.
> 
> Fixes: eee4835d22 ("tools: Add Marvell recovery image download script")
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Igal Liberman <igall@marvell.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   tools/mrvl_uart.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh
> index 6b04d7ae2c..500fa117eb 100755
> --- a/tools/mrvl_uart.sh
> +++ b/tools/mrvl_uart.sh
> @@ -115,5 +115,5 @@ sx -vv $file > $port < $port
>   stty -F $port raw ignbrk time 5 $default_baudrate
>   
>   # Optional - fire up Minicom
> -minicom -D $port
> +minicom -D $port -b $default_baudrate
>   
> 

Applied to u-boot-marvell/master.

Thanks,
Stefan
diff mbox series

Patch

diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh
index 6b04d7ae2c..500fa117eb 100755
--- a/tools/mrvl_uart.sh
+++ b/tools/mrvl_uart.sh
@@ -115,5 +115,5 @@  sx -vv $file > $port < $port
 stty -F $port raw ignbrk time 5 $default_baudrate
 
 # Optional - fire up Minicom
-minicom -D $port
+minicom -D $port -b $default_baudrate