| Message ID | 1391416179-24728-2-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Feb 03, 2014 at 01:59:39PM +0530, Sachin Kamat wrote: > Fixes the following compilation warning: > drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: > drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ > defined but not used [-Wunused-label] > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> What about this one ? > --- > drivers/usb/gadget/s3c-hsudc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c > index ea4bbfe72ec0..10c6a128250c 100644 > --- a/drivers/usb/gadget/s3c-hsudc.c > +++ b/drivers/usb/gadget/s3c-hsudc.c > @@ -1344,7 +1344,6 @@ static int s3c_hsudc_probe(struct platform_device *pdev) > > return 0; > err_add_udc: > -err_add_device: > clk_disable(hsudc->uclk); > err_res: > if (!IS_ERR_OR_NULL(hsudc->transceiver)) > -- > 1.7.9.5 >
On 18 February 2014 20:58, Felipe Balbi <balbi@ti.com> wrote: > On Mon, Feb 03, 2014 at 01:59:39PM +0530, Sachin Kamat wrote: >> Fixes the following compilation warning: >> drivers/usb/gadget/s3c-hsudc.c: In function 's3c_hsudc_probe': >> drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label 'err_add_device' >> defined but not used [-Wunused-label] >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > What about this one ? This patch too is needed but can go in for 3.15.
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index ea4bbfe72ec0..10c6a128250c 100644 --- a/drivers/usb/gadget/s3c-hsudc.c +++ b/drivers/usb/gadget/s3c-hsudc.c @@ -1344,7 +1344,6 @@ static int s3c_hsudc_probe(struct platform_device *pdev) return 0; err_add_udc: -err_add_device: clk_disable(hsudc->uclk); err_res: if (!IS_ERR_OR_NULL(hsudc->transceiver))
Fixes the following compilation warning: drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ defined but not used [-Wunused-label] Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/usb/gadget/s3c-hsudc.c | 1 - 1 file changed, 1 deletion(-)