diff mbox series

perf tools: Fix compiling error in libunwind x86

Message ID 20171206015040.114574-1-wangnan0@huawei.com
State Superseded
Headers show
Series perf tools: Fix compiling error in libunwind x86 | expand

Commit Message

Wang Nan Dec. 6, 2017, 1:50 a.m. UTC
Fix a compiling error:

 ...
   CC       util/libunwind/x86_32.o
 In file included from util/libunwind/x86_32.c:33:0:
 util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id':
 util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function)
    return -EINVAL;
            ^
 util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: note: each undeclared identifier is reported only once for each function it appears in
 mv: cannot stat 'util/libunwind/.x86_32.o.tmp': No such file or directory
 make[4]: *** [util/libunwind/x86_32.o] Error 1
 make[3]: *** [util] Error 2
 make[2]: *** [libperf-in.o] Error 2
 make[1]: *** [sub-make] Error 2
 make: *** [all] Error 2

It happens when libunwind-x86 feature is detected.

Signed-off-by: Wang Nan <wangnan0@huawei.com>

---
 tools/perf/arch/x86/util/unwind-libunwind.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.1

Comments

Arnaldo Carvalho de Melo Jan. 4, 2018, 6:25 p.m. UTC | #1
Em Wed, Dec 06, 2017 at 01:50:40AM +0000, Wang Nan escreveu:
> Fix a compiling error:

> 

>  ...

>    CC       util/libunwind/x86_32.o

>  In file included from util/libunwind/x86_32.c:33:0:

>  util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id':

>  util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function)

>     return -EINVAL;

>             ^

>  util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: note: each undeclared identifier is reported only once for each function it appears in

>  mv: cannot stat 'util/libunwind/.x86_32.o.tmp': No such file or directory

>  make[4]: *** [util/libunwind/x86_32.o] Error 1

>  make[3]: *** [util] Error 2

>  make[2]: *** [libperf-in.o] Error 2

>  make[1]: *** [sub-make] Error 2

>  make: *** [all] Error 2

> 

> It happens when libunwind-x86 feature is detected.


Thanks, simple enough, applied.

- Arnaldo
 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

> ---

>  tools/perf/arch/x86/util/unwind-libunwind.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c

> index 9c917f8..05920e3 100644

> --- a/tools/perf/arch/x86/util/unwind-libunwind.c

> +++ b/tools/perf/arch/x86/util/unwind-libunwind.c

> @@ -1,7 +1,7 @@

>  // SPDX-License-Identifier: GPL-2.0

>  

> -#ifndef REMOTE_UNWIND_LIBUNWIND

>  #include <errno.h>

> +#ifndef REMOTE_UNWIND_LIBUNWIND

>  #include <libunwind.h>

>  #include "perf_regs.h"

>  #include "../../util/unwind.h"

> -- 

> 2.10.1
diff mbox series

Patch

diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c
index 9c917f8..05920e3 100644
--- a/tools/perf/arch/x86/util/unwind-libunwind.c
+++ b/tools/perf/arch/x86/util/unwind-libunwind.c
@@ -1,7 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0
 
-#ifndef REMOTE_UNWIND_LIBUNWIND
 #include <errno.h>
+#ifndef REMOTE_UNWIND_LIBUNWIND
 #include <libunwind.h>
 #include "perf_regs.h"
 #include "../../util/unwind.h"