| Message ID | 20171218173022.18418-2-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/arm: Prepatory work for SVE | expand |
On 12/18/2017 02:30 PM, Richard Henderson wrote: > If it isn't used when translate.h is included, > we'll get a compiler Werror. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/arm/translate.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/translate.h b/target/arm/translate.h > index cd7313ace7..3f4df91e5e 100644 > --- a/target/arm/translate.h > +++ b/target/arm/translate.h > @@ -108,7 +108,7 @@ static inline int default_exception_el(DisasContext *s) > ? 3 : MAX(1, s->current_el); > } > > -static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) > +static inline void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) > { > /* We don't need to save all of the syndrome so we mask and shift > * out unneeded bits to help the sleb128 encoder do a better job. >
On 18 December 2017 at 17:30, Richard Henderson <richard.henderson@linaro.org> wrote: > If it isn't used when translate.h is included, > we'll get a compiler Werror. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/translate.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/translate.h b/target/arm/translate.h > index cd7313ace7..3f4df91e5e 100644 > --- a/target/arm/translate.h > +++ b/target/arm/translate.h > @@ -108,7 +108,7 @@ static inline int default_exception_el(DisasContext *s) > ? 3 : MAX(1, s->current_el); > } > > -static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) > +static inline void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) > { > /* We don't need to save all of the syndrome so we mask and shift > * out unneeded bits to help the sleb128 encoder do a better job. > -- > 2.14.3 Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/target/arm/translate.h b/target/arm/translate.h index cd7313ace7..3f4df91e5e 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -108,7 +108,7 @@ static inline int default_exception_el(DisasContext *s) ? 3 : MAX(1, s->current_el); } -static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) +static inline void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) { /* We don't need to save all of the syndrome so we mask and shift * out unneeded bits to help the sleb128 encoder do a better job.
If it isn't used when translate.h is included, we'll get a compiler Werror. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/translate.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3