| Message ID | 20171212180741.4896-1-semen.protsenko@linaro.org |
|---|---|
| State | Accepted |
| Commit | dd0829f6c3938dd1bebd86ec5b790fc9b53db8f0 |
| Headers | show |
| Series | am335x_evm: Fix DFU for eMMC | expand |
On Tue, 12 Dec 2017 20:07:41 +0200 Sam Protsenko <semen.protsenko@linaro.org> wrote: > Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. > It was probably overlooked when extracting DFU variables to mentioned > file. > > This patch fixes DFU on BeagleBone Black, so that we can use commands > like ones below to upgrade various images on eMMC: > > => setenv dfu_alt_info $dfu_alt_info_emmc > => dfu 0 mmc 1 > > $ dfu-util -D MLO -a MLO.raw > $ dfu-util -D u-boot.img -a u-boot.img.raw > > Without this patch, the user is forced to assign the value to > dfu_alt_info_emmc manually, which contradicts with instructions [1]. > > [1] > http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > include/configs/am335x_evm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/am335x_evm.h > b/include/configs/am335x_evm.h index 5ad0366730..856c546fc1 100644 > --- a/include/configs/am335x_evm.h > +++ b/include/configs/am335x_evm.h > @@ -255,7 +255,7 @@ > /* USB Device Firmware Update support */ > #ifndef CONFIG_SPL_BUILD > #define DFUARGS \ > - "dfu_alt_info_emmc=rawemmc raw 0 3751936\0" \ > + DFU_ALT_INFO_EMMC \ > DFU_ALT_INFO_MMC \ > DFU_ALT_INFO_RAM \ > DFU_ALT_INFO_NAND Reviewed-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Tue, Dec 12, 2017 at 08:07:41PM +0200, Sam Protsenko wrote: > Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. > It was probably overlooked when extracting DFU variables to mentioned > file. > > This patch fixes DFU on BeagleBone Black, so that we can use commands > like ones below to upgrade various images on eMMC: > > => setenv dfu_alt_info $dfu_alt_info_emmc > => dfu 0 mmc 1 > > $ dfu-util -D MLO -a MLO.raw > $ dfu-util -D u-boot.img -a u-boot.img.raw > > Without this patch, the user is forced to assign the value to > dfu_alt_info_emmc manually, which contradicts with instructions [1]. > > [1] http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> > Reviewed-by: Lukasz Majewski <lukma@denx.de> Applied to u-boot/master, thanks! -- Tom
diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h index 5ad0366730..856c546fc1 100644 --- a/include/configs/am335x_evm.h +++ b/include/configs/am335x_evm.h @@ -255,7 +255,7 @@ /* USB Device Firmware Update support */ #ifndef CONFIG_SPL_BUILD #define DFUARGS \ - "dfu_alt_info_emmc=rawemmc raw 0 3751936\0" \ + DFU_ALT_INFO_EMMC \ DFU_ALT_INFO_MMC \ DFU_ALT_INFO_RAM \ DFU_ALT_INFO_NAND
Use dfu_alt_info_emmc variable from include/environment/ti/dfu.h file. It was probably overlooked when extracting DFU variables to mentioned file. This patch fixes DFU on BeagleBone Black, so that we can use commands like ones below to upgrade various images on eMMC: => setenv dfu_alt_info $dfu_alt_info_emmc => dfu 0 mmc 1 $ dfu-util -D MLO -a MLO.raw $ dfu-util -D u-boot.img -a u-boot.img.raw Without this patch, the user is forced to assign the value to dfu_alt_info_emmc manually, which contradicts with instructions [1]. [1] http://processors.wiki.ti.com/index.php/Linux_Core_U-Boot_User%27s_Guide Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- include/configs/am335x_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)