| Message ID | 1511745081-7292-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | binman: do not add binary files to git | expand |
Hi Masahiro, On 26 November 2017 at 18:11, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Commit message? This breaks the binman tests. With the Makefile that is now present in tools/binman/test we could perhaps generate these files on the fly? > --- > > tools/binman/test/.gitignore | 3 +++ > tools/binman/test/bss_data | Bin 5020 -> 0 bytes > tools/binman/test/u_boot_no_ucode_ptr | Bin 4182 -> 0 bytes > tools/binman/test/u_boot_ucode_ptr | Bin 4175 -> 0 bytes > 4 files changed, 3 insertions(+) > create mode 100644 tools/binman/test/.gitignore > delete mode 100755 tools/binman/test/bss_data > delete mode 100755 tools/binman/test/u_boot_no_ucode_ptr > delete mode 100755 tools/binman/test/u_boot_ucode_ptr Regards, Simon
Hi Simon, 2017-11-29 22:08 GMT+09:00 Simon Glass <sjg@chromium.org>: > Hi Masahiro, > > On 26 November 2017 at 18:11, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Commit message? > > This breaks the binman tests. > > With the Makefile that is now present in tools/binman/test we could > perhaps generate these files on the fly? I saw the Makefile. I thought it was invoked somewhere. >> -- >> >> tools/binman/test/.gitignore | 3 +++ >> tools/binman/test/bss_data | Bin 5020 -> 0 bytes >> tools/binman/test/u_boot_no_ucode_ptr | Bin 4182 -> 0 bytes >> tools/binman/test/u_boot_ucode_ptr | Bin 4175 -> 0 bytes >> 4 files changed, 3 insertions(+) >> create mode 100644 tools/binman/test/.gitignore >> delete mode 100755 tools/binman/test/bss_data >> delete mode 100755 tools/binman/test/u_boot_no_ucode_ptr >> delete mode 100755 tools/binman/test/u_boot_ucode_ptr > > Regards, > Simon > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Hi Masahiro, On 29 November 2017 at 07:14, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Hi Simon, > > 2017-11-29 22:08 GMT+09:00 Simon Glass <sjg@chromium.org>: > > Hi Masahiro, > > > > On 26 November 2017 at 18:11, Masahiro Yamada > > <yamada.masahiro@socionext.com> wrote: > >> > >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > > Commit message? > > > > This breaks the binman tests. > > > > With the Makefile that is now present in tools/binman/test we could > > perhaps generate these files on the fly? > > > I saw the Makefile. > I thought it was invoked somewhere. Unfortunately not yet, but it is a start. Originally I was worried that we might not be able to generate a suitable ELF file reliably on all platforms, but perhaps I am being too paranoid. Regards, Simon
Hi Simon, 2017-12-02 8:24 GMT+09:00 Simon Glass <sjg@chromium.org>: > Hi Masahiro, > > On 29 November 2017 at 07:14, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> >> Hi Simon, >> >> 2017-11-29 22:08 GMT+09:00 Simon Glass <sjg@chromium.org>: >> > Hi Masahiro, >> > >> > On 26 November 2017 at 18:11, Masahiro Yamada >> > <yamada.masahiro@socionext.com> wrote: >> >> >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> > >> > Commit message? >> > >> > This breaks the binman tests. >> > >> > With the Makefile that is now present in tools/binman/test we could >> > perhaps generate these files on the fly? >> >> >> I saw the Makefile. >> I thought it was invoked somewhere. > > Unfortunately not yet, but it is a start. Originally I was worried > that we might not be able to generate a suitable ELF file reliably on > all platforms, but perhaps I am being too paranoid. > Can you fix this? I am not familiar with Binman.
diff --git a/tools/binman/test/.gitignore b/tools/binman/test/.gitignore new file mode 100644 index 0000000..e38c6e8 --- /dev/null +++ b/tools/binman/test/.gitignore @@ -0,0 +1,3 @@ +u_boot_ucode_ptr +u_boot_no_ucode_ptr +bss_data
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- tools/binman/test/.gitignore | 3 +++ tools/binman/test/bss_data | Bin 5020 -> 0 bytes tools/binman/test/u_boot_no_ucode_ptr | Bin 4182 -> 0 bytes tools/binman/test/u_boot_ucode_ptr | Bin 4175 -> 0 bytes 4 files changed, 3 insertions(+) create mode 100644 tools/binman/test/.gitignore delete mode 100755 tools/binman/test/bss_data delete mode 100755 tools/binman/test/u_boot_no_ucode_ptr delete mode 100755 tools/binman/test/u_boot_ucode_ptr diff --git a/tools/binman/test/bss_data b/tools/binman/test/bss_data deleted file mode 100755 index afa28282aa157f6717c1ba244ecbfc6e1b081734..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 5020 zcmeHLyKWOf6uoP&!GJ+|Af+(H7C{(6hJ>s{1O*}i;vz!9k|7jmvEv0>!j5FGr4S(= z1rl`m016r?sner~AE2ip9R*N@0-1AWb`nc8lqu#)$M-R39(#6N?0tS?>89s-Vl5+C zVfN$CU=YG@j+l{90?A29j!9mR>*@<XFTe^W5IGjX=X`p3hjGA1SOyLOtTX>YU@kF< zm|&e)-boq-EK+#s=ZTZ35qA7G#*zMGT%X&LM}8Jqyj7L$-{T)<zJ0y(_Vh>Z{jc>) zoA)Lv)i*nzb0r)u1JV{C_dj{X>=n-E`M(bagY)oQhvscm#Cw|eiUr?)4Z<nZh%N9m z=h}(<tIYiI-10UUoZ-wV;1qBQI0c*nP64NYQ@|<U6mSYS1)Ks0M}ZQKvbeBtIVe@@ z{Z7&kLN%wtsf&G`%{-e4)pV$4&zic3>OE;EwK{y#HNI)1&RP<yN1eW^_gjw}Q>})m zBwkNM#m(qpx7LoMW}~~GiE7l6ny7lOCu()A-HtoS|Lal&^)SHCcil&Tp9HMgPjH0- zzvtN-*hQ~l7v6r;Bi!p{glWw6bl(A!hIw|q`5|6_-b4W29BS4qZwUqN%N~U8gQR^A zrZmf|AkG8i1!zb3;PIVU3)0{&JlC5}bMnrmF&)Q<Q9$nrPrCr#109(ka%l8?R%_)k z^iEJbiUPs&VX7PfhSyse7rBm_HM^e8hdtj5bJI~W`kUPBOr1?`cA%anPt}1QCfA)M zt&hodCyAl9EN;T^Iehs!uw(Sh3-I>2Mv+e-r`{#_QQVFIo;@!(Jhvxj;Qe&}5sc3w z=l$WG7=v<r=lkP1xr)3z#1~xah!<R~N)$2awKn3tszkk{)=lh?j@z|XN1|B&E26m5 FkiP*om$v`_ diff --git a/tools/binman/test/u_boot_no_ucode_ptr b/tools/binman/test/u_boot_no_ucode_ptr deleted file mode 100755 index f72462f0be41a934d468481bf627d6c1ec9a8e1c..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 4182 zcmeHKy-EW?5T5*Cv``}iEVQ^HMMSbDdWK+O6Euwq7AdTbT<(Ygb0^7OVG6bMF|2$8 zpFw;En;;05iM_7#<+2d5v9R2MkJ<U%oo}nTIXF5@Bod@0NhyLg`c%qheYX@xY_d2~ zpbVua@rie&6fxF02bhC1OPs;=i*XP1$+Hc>51hV9kJT?hJ(n9X3>XFs1BL;^fMLKe zU>GnA7zPXjhJk-z0Q*;tkz&+O8uWhlJbWr0zYHsC`1(-IehePl*#DA<*J^uKq2We> zj4WGJg<af^CRX{nY>SdDb~a)^k?3D_Wz%IXd$B&(ry!KRXa|vSqt1m_?06)iR_OU8 zT4A^A2a>P)v#fDuhJp8Cx5S>ApQ*-t5W&D4m^1gKRF3!4c|L2=dAsaDUTGS@9=oZN zrZL1<80e*?&UyRVV2vCIG~TA=ewpZ&4eYjfH}1ubyTF+3XR))wJ}tVRwr4fwh8=I} z@qDp8do$uXBd$)<SgrCAe1MC@kC)<YW3|P8-9L+IBF7Cw=>(xO`84NJ_C$;LPaVgT TQ=i-H`%b?z@X6`RW>3;L6WVxU diff --git a/tools/binman/test/u_boot_ucode_ptr b/tools/binman/test/u_boot_ucode_ptr deleted file mode 100755 index dbfb184cecfbcf55cf43ed4f4ac0ee90a7364d93..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 4175 zcmeHKze~eV5WfDv>Y%NqTOB%ds7Rl!MiB>>qFqFAD7b~B30kp<v@e1V>Lh}je}Vs) zgM)i3QgG0CU(yE=7YE1p!Ew2t@9xWVH@o|LsZ@#-(v%@sqt7rjSl=(i5rZlmsZoxy zQ9SaF!jM>&I0rHVXMs3_>*wPh=u>4I0zc&NRXVJG0rgz2p&8H&Xa+O`ngPv#W<WEb z8PE)91~dczzyR*A5=(}qebAw|qP00Wx+^}sOy2XS&mWD8@+0oQG~%t+cBR&_15XAO zLu?77z7|AQ^SWt>h9TCMV?U7?UiPJBvzCKcpQta-m##SW0$~TeGpF8jNCaKqaY=Oj ze&6*ZKlNvnIWxzC`EXm}&a5V?u^%8<um|=meT89(@6%cSR#15x>_A>)8o(X9qLQXD z#1~o6OQFqqJIY{<8~_@#DLmzgZrQ+Xi@EVGZrnMRWWNeKSJ|ha`YAi9u{Z4aQjhnG z?c~ddtBklhOXCp#9(;g{)Q?Fq+c>PTU-d6wo4~YvUz*V$GtcEfbjfs-ZCgXv9QLkU KGKbO{NcskUZF7hK