| Message ID | 20171120213305.53913-1-jc@linux.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE | expand |
On Mon 20 Nov 13:33 PST 2017, Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o > see include/linux/module.h for more information > > This adds the license as "GPL v2", which matches the header of the file. > > MODULE_DESCRIPTION is also added. > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Although I suspect that the plan was for the three ufs phy drivers to be one kernel module... Regards, Bjorn > Signed-off-by: Jesse Chan <jc@linux.com> > --- > drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c > index c5ff4525edef..124dc70f6986 100644 > --- a/drivers/phy/qualcomm/phy-qcom-ufs.c > +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c > @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy) > return 0; > } > EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off); > + > +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY"); > +MODULE_LICENSE("GPL v2"); > -- > 2.14.1 >
On 2017-11-20 13:33, Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/phy/qualcomm/phy-qcom-ufs.o > see include/linux/module.h for more information > > This adds the license as "GPL v2", which matches the header of the > file. > > MODULE_DESCRIPTION is also added. > > Signed-off-by: Jesse Chan <jc@linux.com> > --- > drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c > b/drivers/phy/qualcomm/phy-qcom-ufs.c > index c5ff4525edef..124dc70f6986 100644 > --- a/drivers/phy/qualcomm/phy-qcom-ufs.c > +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c > @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy) > return 0; > } > EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off); > + > +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY"); > +MODULE_LICENSE("GPL v2"); Looks good to me. Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c index c5ff4525edef..124dc70f6986 100644 --- a/drivers/phy/qualcomm/phy-qcom-ufs.c +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy) return 0; } EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off); + +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY"); +MODULE_LICENSE("GPL v2");
This change resolves a new compile-time warning when built as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o see include/linux/module.h for more information This adds the license as "GPL v2", which matches the header of the file. MODULE_DESCRIPTION is also added. Signed-off-by: Jesse Chan <jc@linux.com> --- drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.14.1