diff mbox series

[edk2] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

Message ID 20171101150125.13679-1-ard.biesheuvel@linaro.org
State New
Headers show
Series [edk2] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources | expand

Commit Message

Ard Biesheuvel Nov. 1, 2017, 3:01 p.m. UTC 
Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE
linking") works around an issue that was caught due to the fact that
PIE linking produces broken .acpi files. However, v2 of that fix
inadvertently only applied the workaround to the normal linker command
line, and not to the ASLD one, so the issue still persists.

So add the missing -no-pie options for ASLD on ARM and AARCH64.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 BaseTools/Conf/tools_def.template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Gao, Liming Nov. 1, 2017, 3:13 p.m. UTC | #1 
Reviewed-by: Liming Gao <liming.gao@intel.com>


> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Wednesday, November 1, 2017 11:01 PM

> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong

> <yonghong.zhu@intel.com>

> Cc: daniel.thompson@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

> 

> Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE

> linking") works around an issue that was caught due to the fact that

> PIE linking produces broken .acpi files. However, v2 of that fix

> inadvertently only applied the workaround to the normal linker command

> line, and not to the ASLD one, so the issue still persists.

> 

> So add the missing -no-pie options for ASLD on ARM and AARCH64.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  BaseTools/Conf/tools_def.template | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template

> index 98df0ffc9294..aebd7d558633 100755

> --- a/BaseTools/Conf/tools_def.template

> +++ b/BaseTools/Conf/tools_def.template

> @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>  DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

> -DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS)

> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS)

> +DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

> 

>  ####################################################################################

>  #

> --

> 2.11.0


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 1, 2017, 3:18 p.m. UTC | #2 
On 1 November 2017 at 15:13, Gao, Liming <liming.gao@intel.com> wrote:
> Reviewed-by: Liming Gao <liming.gao@intel.com>

>


Thanks - pushed as 3380a591232de2ab3007ab051010a67c3d000d1c

>> -----Original Message-----

>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>> Sent: Wednesday, November 1, 2017 11:01 PM

>> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong

>> <yonghong.zhu@intel.com>

>> Cc: daniel.thompson@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

>>

>> Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE

>> linking") works around an issue that was caught due to the fact that

>> PIE linking produces broken .acpi files. However, v2 of that fix

>> inadvertently only applied the workaround to the normal linker command

>> line, and not to the ASLD one, so the issue still persists.

>>

>> So add the missing -no-pie options for ASLD on ARM and AARCH64.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.1

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> ---

>>  BaseTools/Conf/tools_def.template | 4 ++--

>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>

>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template

>> index 98df0ffc9294..aebd7d558633 100755

>> --- a/BaseTools/Conf/tools_def.template

>> +++ b/BaseTools/Conf/tools_def.template

>> @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>>  DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>> -DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS)

>> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS)

>> +DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

>> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

>>

>>  ####################################################################################

>>  #

>> --

>> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Marcin Wojtas Nov. 16, 2017, 2:38 p.m. UTC | #3 
Hi Ard,

With both PIE disabling patches for AARCH64, when compiling ACPI tables with
gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-
I get following errors:
[...]
aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'
Do I understand correctly, that I should either revert those patches
or upgrade to the newer toolchain?

Best regards,
Marcin

2017-11-01 16:18 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
> On 1 November 2017 at 15:13, Gao, Liming <liming.gao@intel.com> wrote:

>> Reviewed-by: Liming Gao <liming.gao@intel.com>

>>

>

> Thanks - pushed as 3380a591232de2ab3007ab051010a67c3d000d1c

>

>>> -----Original Message-----

>>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>>> Sent: Wednesday, November 1, 2017 11:01 PM

>>> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong

>>> <yonghong.zhu@intel.com>

>>> Cc: daniel.thompson@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>

>>> Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

>>>

>>> Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE

>>> linking") works around an issue that was caught due to the fact that

>>> PIE linking produces broken .acpi files. However, v2 of that fix

>>> inadvertently only applied the workaround to the normal linker command

>>> line, and not to the ASLD one, so the issue still persists.

>>>

>>> So add the missing -no-pie options for ASLD on ARM and AARCH64.

>>>

>>> Contributed-under: TianoCore Contribution Agreement 1.1

>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>>> ---

>>>  BaseTools/Conf/tools_def.template | 4 ++--

>>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>>

>>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template

>>> index 98df0ffc9294..aebd7d558633 100755

>>> --- a/BaseTools/Conf/tools_def.template

>>> +++ b/BaseTools/Conf/tools_def.template

>>> @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>>>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>>>  DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>>>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>>> -DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS)

>>> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS)

>>> +DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

>>> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

>>>

>>>  ####################################################################################

>>>  #

>>> --

>>> 2.11.0

>>

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 16, 2017, 2:48 p.m. UTC | #4 
On 16 November 2017 at 14:38, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Ard,

>

> With both PIE disabling patches for AARCH64, when compiling ACPI tables with

> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-

> I get following errors:

> [...]

> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

> Do I understand correctly, that I should either revert those patches

> or upgrade to the newer toolchain?

>


Ugh.

I thought GCC 5 and later implemented -no-pie, but apparently not.

Does this fix your build? I will need to check whether it fixes the
original issue, but hopefully your toolchain doesn't choke on this:

diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index aebd7d558633..111fe8da7773 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS         =
DEF(GCC49_AARCH64_CC_FLAGS)
 DEFINE GCC5_AARCH64_CC_XIPFLAGS      = DEF(GCC49_AARCH64_CC_XIPFLAGS)
 DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie
 DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error
-DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie
+DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS)
-Wl,-no-pie
 DEFINE GCC5_AARCH64_DLINK2_FLAGS     =
DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error
 DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie
-DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =
DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie
+DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =
DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie

 ####################################################################################
 #



>

> 2017-11-01 16:18 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:

>> On 1 November 2017 at 15:13, Gao, Liming <liming.gao@intel.com> wrote:

>>> Reviewed-by: Liming Gao <liming.gao@intel.com>

>>>

>>

>> Thanks - pushed as 3380a591232de2ab3007ab051010a67c3d000d1c

>>

>>>> -----Original Message-----

>>>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>>>> Sent: Wednesday, November 1, 2017 11:01 PM

>>>> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong

>>>> <yonghong.zhu@intel.com>

>>>> Cc: daniel.thompson@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>

>>>> Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

>>>>

>>>> Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE

>>>> linking") works around an issue that was caught due to the fact that

>>>> PIE linking produces broken .acpi files. However, v2 of that fix

>>>> inadvertently only applied the workaround to the normal linker command

>>>> line, and not to the ASLD one, so the issue still persists.

>>>>

>>>> So add the missing -no-pie options for ASLD on ARM and AARCH64.

>>>>

>>>> Contributed-under: TianoCore Contribution Agreement 1.1

>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>>>> ---

>>>>  BaseTools/Conf/tools_def.template | 4 ++--

>>>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>>>

>>>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template

>>>> index 98df0ffc9294..aebd7d558633 100755

>>>> --- a/BaseTools/Conf/tools_def.template

>>>> +++ b/BaseTools/Conf/tools_def.template

>>>> @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>>>>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>>>>  DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>>>>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>>>> -DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS)

>>>> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS)

>>>> +DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

>>>> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

>>>>

>>>>  ####################################################################################

>>>>  #

>>>> --

>>>> 2.11.0

>>>

>> _______________________________________________

>> edk2-devel mailing list

>> edk2-devel@lists.01.org

>> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Marcin Wojtas Nov. 16, 2017, 3:07 p.m. UTC | #5 
Hi Ard,

2017-11-16 15:48 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
> On 16 November 2017 at 14:38, Marcin Wojtas <mw@semihalf.com> wrote:

>> Hi Ard,

>>

>> With both PIE disabling patches for AARCH64, when compiling ACPI tables with

>> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-

>> I get following errors:

>> [...]

>> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

>> Do I understand correctly, that I should either revert those patches

>> or upgrade to the newer toolchain?

>>

>

> Ugh.

>

> I thought GCC 5 and later implemented -no-pie, but apparently not.

>

> Does this fix your build? I will need to check whether it fixes the

> original issue, but hopefully your toolchain doesn't choke on this:

>

> diff --git a/BaseTools/Conf/tools_def.template

> b/BaseTools/Conf/tools_def.template

> index aebd7d558633..111fe8da7773 100755

> --- a/BaseTools/Conf/tools_def.template

> +++ b/BaseTools/Conf/tools_def.template

> @@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS         =

> DEF(GCC49_AARCH64_CC_FLAGS)

>  DEFINE GCC5_AARCH64_CC_XIPFLAGS      = DEF(GCC49_AARCH64_CC_XIPFLAGS)

>  DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

> -DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

> +DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS)

> -Wl,-no-pie

>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     =

> DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>  DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie

>

>  ####################################################################################

>  #

>


Unfortunately no change, still:
aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'
In order to make sure, I double checked twice cleaninig everything and
rebuilding from scratch.

Marcin
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 16, 2017, 3:08 p.m. UTC | #6 
On 16 November 2017 at 15:07, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Ard,

>

> 2017-11-16 15:48 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:

>> On 16 November 2017 at 14:38, Marcin Wojtas <mw@semihalf.com> wrote:

>>> Hi Ard,

>>>

>>> With both PIE disabling patches for AARCH64, when compiling ACPI tables with

>>> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-

>>> I get following errors:

>>> [...]

>>> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

>>> Do I understand correctly, that I should either revert those patches

>>> or upgrade to the newer toolchain?

>>>

>>

>> Ugh.

>>

>> I thought GCC 5 and later implemented -no-pie, but apparently not.

>>

>> Does this fix your build? I will need to check whether it fixes the

>> original issue, but hopefully your toolchain doesn't choke on this:

>>

>> diff --git a/BaseTools/Conf/tools_def.template

>> b/BaseTools/Conf/tools_def.template

>> index aebd7d558633..111fe8da7773 100755

>> --- a/BaseTools/Conf/tools_def.template

>> +++ b/BaseTools/Conf/tools_def.template

>> @@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS         =

>> DEF(GCC49_AARCH64_CC_FLAGS)

>>  DEFINE GCC5_AARCH64_CC_XIPFLAGS      = DEF(GCC49_AARCH64_CC_XIPFLAGS)

>>  DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>> -DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>> +DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS)

>> -Wl,-no-pie

>>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     =

>> DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>>  DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

>> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

>> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

>> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

>> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie

>>

>>  ####################################################################################

>>  #

>>

>

> Unfortunately no change, still:

> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

> In order to make sure, I double checked twice cleaninig everything and

> rebuilding from scratch.

>


Thanks, but it doesn't matter anyway: it doesn't fix the original
issues on affected toolchains.

It appears the only way we can deal with this is introducing GCC6 and
move the workaround there.

Thanks,
Ard.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Gao, Liming Nov. 16, 2017, 3:31 p.m. UTC | #7 
Ard:
  Does this error only happen on ACPI table compiling? But, I see -no-pie is also in normal DLINK flag. Why is the driver not compiled failed?

Thanks
Liming
> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Thursday, November 16, 2017 11:09 PM

> To: Marcin Wojtas <mw@semihalf.com>

> Cc: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; daniel.thompson@linaro.org; leif.lindholm@linaro.org

> Subject: Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

> 

> On 16 November 2017 at 15:07, Marcin Wojtas <mw@semihalf.com> wrote:

> > Hi Ard,

> >

> > 2017-11-16 15:48 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:

> >> On 16 November 2017 at 14:38, Marcin Wojtas <mw@semihalf.com> wrote:

> >>> Hi Ard,

> >>>

> >>> With both PIE disabling patches for AARCH64, when compiling ACPI tables with

> >>> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-

> >>> I get following errors:

> >>> [...]

> >>> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

> >>> Do I understand correctly, that I should either revert those patches

> >>> or upgrade to the newer toolchain?

> >>>

> >>

> >> Ugh.

> >>

> >> I thought GCC 5 and later implemented -no-pie, but apparently not.

> >>

> >> Does this fix your build? I will need to check whether it fixes the

> >> original issue, but hopefully your toolchain doesn't choke on this:

> >>

> >> diff --git a/BaseTools/Conf/tools_def.template

> >> b/BaseTools/Conf/tools_def.template

> >> index aebd7d558633..111fe8da7773 100755

> >> --- a/BaseTools/Conf/tools_def.template

> >> +++ b/BaseTools/Conf/tools_def.template

> >> @@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS         =

> >> DEF(GCC49_AARCH64_CC_FLAGS)

> >>  DEFINE GCC5_AARCH64_CC_XIPFLAGS      = DEF(GCC49_AARCH64_CC_XIPFLAGS)

> >>  DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

> >>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

> >> -DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

> >> +DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS)

> >> -Wl,-no-pie

> >>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     =

> >> DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

> >>  DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

> >> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

> >> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

> >> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

> >> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie

> >>

> >>  ####################################################################################

> >>  #

> >>

> >

> > Unfortunately no change, still:

> > aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

> > In order to make sure, I double checked twice cleaninig everything and

> > rebuilding from scratch.

> >

> 

> Thanks, but it doesn't matter anyway: it doesn't fix the original

> issues on affected toolchains.

> 

> It appears the only way we can deal with this is introducing GCC6 and

> move the workaround there.

> 

> Thanks,

> Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 16, 2017, 3:45 p.m. UTC | #8 
On 16 November 2017 at 15:31, Gao, Liming <liming.gao@intel.com> wrote:
> Ard:

>   Does this error only happen on ACPI table compiling? But, I see -no-pie is also in normal DLINK flag. Why is the driver not compiled failed?

>


The main difference is that the ACPI tables don't tolerate any padding
at the start of the binary image. This is different for ELF binaries
that are converted to PE/COFF, given that the entry point is exposed
in the header, so the padding is just ignored. However, we should
still try to omit those sections if we can.



>> -----Original Message-----

>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>> Sent: Thursday, November 16, 2017 11:09 PM

>> To: Marcin Wojtas <mw@semihalf.com>

>> Cc: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; daniel.thompson@linaro.org; leif.lindholm@linaro.org

>> Subject: Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

>>

>> On 16 November 2017 at 15:07, Marcin Wojtas <mw@semihalf.com> wrote:

>> > Hi Ard,

>> >

>> > 2017-11-16 15:48 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:

>> >> On 16 November 2017 at 14:38, Marcin Wojtas <mw@semihalf.com> wrote:

>> >>> Hi Ard,

>> >>>

>> >>> With both PIE disabling patches for AARCH64, when compiling ACPI tables with

>> >>> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-

>> >>> I get following errors:

>> >>> [...]

>> >>> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

>> >>> Do I understand correctly, that I should either revert those patches

>> >>> or upgrade to the newer toolchain?

>> >>>

>> >>

>> >> Ugh.

>> >>

>> >> I thought GCC 5 and later implemented -no-pie, but apparently not.

>> >>

>> >> Does this fix your build? I will need to check whether it fixes the

>> >> original issue, but hopefully your toolchain doesn't choke on this:

>> >>

>> >> diff --git a/BaseTools/Conf/tools_def.template

>> >> b/BaseTools/Conf/tools_def.template

>> >> index aebd7d558633..111fe8da7773 100755

>> >> --- a/BaseTools/Conf/tools_def.template

>> >> +++ b/BaseTools/Conf/tools_def.template

>> >> @@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS         =

>> >> DEF(GCC49_AARCH64_CC_FLAGS)

>> >>  DEFINE GCC5_AARCH64_CC_XIPFLAGS      = DEF(GCC49_AARCH64_CC_XIPFLAGS)

>> >>  DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>> >>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>> >> -DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>> >> +DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS)

>> >> -Wl,-no-pie

>> >>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     =

>> >> DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>> >>  DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

>> >> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

>> >> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

>> >> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

>> >> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie

>> >>

>> >>  ####################################################################################

>> >>  #

>> >>

>> >

>> > Unfortunately no change, still:

>> > aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

>> > In order to make sure, I double checked twice cleaninig everything and

>> > rebuilding from scratch.

>> >

>>

>> Thanks, but it doesn't matter anyway: it doesn't fix the original

>> issues on affected toolchains.

>>

>> It appears the only way we can deal with this is introducing GCC6 and

>> move the workaround there.

>>

>> Thanks,

>> Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Marcin Wojtas Nov. 21, 2017, 12:06 p.m. UTC | #9 
Hi Ard,

2017-11-16 16:45 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
> On 16 November 2017 at 15:31, Gao, Liming <liming.gao@intel.com> wrote:

>> Ard:

>>   Does this error only happen on ACPI table compiling? But, I see -no-pie is also in normal DLINK flag. Why is the driver not compiled failed?

>>

>

> The main difference is that the ACPI tables don't tolerate any padding

> at the start of the binary image. This is different for ELF binaries

> that are converted to PE/COFF, given that the entry point is exposed

> in the header, so the padding is just ignored. However, we should

> still try to omit those sections if we can.

>

>

>

>>> -----Original Message-----

>>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>>> Sent: Thursday, November 16, 2017 11:09 PM

>>> To: Marcin Wojtas <mw@semihalf.com>

>>> Cc: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; daniel.thompson@linaro.org; leif.lindholm@linaro.org

>>> Subject: Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

>>>

>>> On 16 November 2017 at 15:07, Marcin Wojtas <mw@semihalf.com> wrote:

>>> > Hi Ard,

>>> >

>>> > 2017-11-16 15:48 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:

>>> >> On 16 November 2017 at 14:38, Marcin Wojtas <mw@semihalf.com> wrote:

>>> >>> Hi Ard,

>>> >>>

>>> >>> With both PIE disabling patches for AARCH64, when compiling ACPI tables with

>>> >>> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-

>>> >>> I get following errors:

>>> >>> [...]

>>> >>> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

>>> >>> Do I understand correctly, that I should either revert those patches

>>> >>> or upgrade to the newer toolchain?

>>> >>>

>>> >>

>>> >> Ugh.

>>> >>

>>> >> I thought GCC 5 and later implemented -no-pie, but apparently not.

>>> >>

>>> >> Does this fix your build? I will need to check whether it fixes the

>>> >> original issue, but hopefully your toolchain doesn't choke on this:

>>> >>

>>> >> diff --git a/BaseTools/Conf/tools_def.template

>>> >> b/BaseTools/Conf/tools_def.template

>>> >> index aebd7d558633..111fe8da7773 100755

>>> >> --- a/BaseTools/Conf/tools_def.template

>>> >> +++ b/BaseTools/Conf/tools_def.template

>>> >> @@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS         =

>>> >> DEF(GCC49_AARCH64_CC_FLAGS)

>>> >>  DEFINE GCC5_AARCH64_CC_XIPFLAGS      = DEF(GCC49_AARCH64_CC_XIPFLAGS)

>>> >>  DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie

>>> >>  DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error

>>> >> -DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie

>>> >> +DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS)

>>> >> -Wl,-no-pie

>>> >>  DEFINE GCC5_AARCH64_DLINK2_FLAGS     =

>>> >> DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error

>>> >>  DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie

>>> >> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

>>> >> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie

>>> >> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   =

>>> >> DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie

>>> >>

>>> >>  ####################################################################################

>>> >>  #

>>> >>

>>> >

>>> > Unfortunately no change, still:

>>> > aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie'

>>> > In order to make sure, I double checked twice cleaninig everything and

>>> > rebuilding from scratch.

>>> >

>>>

>>> Thanks, but it doesn't matter anyway: it doesn't fix the original

>>> issues on affected toolchains.

>>>

>>> It appears the only way we can deal with this is introducing GCC6 and

>>> move the workaround there.

>>>


Do you think it would be reasonable to revert:
3380a59 - BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources
1894a7c - BaseTools/tools_def AARCH64 ARM: disable PIE linking
on the EDK2 master branch, so that the users are not affected before
the actual workaround for problematic builds is moved to GCC6?

Best regards,
Marcin
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index 98df0ffc9294..aebd7d558633 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -4498,8 +4498,8 @@  DEFINE GCC5_ARM_DLINK_FLAGS          = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie
 DEFINE GCC5_ARM_DLINK2_FLAGS         = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error
 DEFINE GCC5_AARCH64_DLINK_FLAGS      = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie
 DEFINE GCC5_AARCH64_DLINK2_FLAGS     = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error
-DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS)
-DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS)
+DEFINE GCC5_ARM_ASLDLINK_FLAGS       = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie
+DEFINE GCC5_AARCH64_ASLDLINK_FLAGS   = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie
 
 ####################################################################################
 #