| Message ID | 1505700081-12854-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 0bc989ffc802752c5256192b4a9c8f16a00feca7 |
| Headers | show |
| Series | [v2] checkpatch: do not check missing blank line before builtin_*_driver | expand |
Hi Joe, Andrew, (sorry, Andrew was missing from the list...) 2017-09-18 11:01 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > checkpatch.pl does not check missing blank line before module_*_driver. > I want it to behave likewise for builtin_*_driver. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v2: > - Improve the matching pattern as suggested by Joe Perches > > scripts/checkpatch.pl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index dd2c262aebbf..5c6179c63cf6 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3103,6 +3103,7 @@ sub process { > $line =~ /^\+[a-z_]*init/ || > $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || > $line =~ /^\+\s*DECLARE/ || > + $line =~ /^\+\s*builtin_[\w_]*driver/ || > $line =~ /^\+\s*__setup/)) { > if (CHK("LINE_SPACING", > "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) && > -- > 2.7.4 > Is this patch good for 4.15-rc1? "git log scripts/checkpatch.pl" shows this kind of patch is generally picked up by Andrew. If Joe issues Acked-by, that will be very helpful for applying this patch. Thanks! -- Best Regards Masahiro Yamada
On Wed, 2017-11-08 at 22:32 +0900, Masahiro Yamada wrote: > Hi Joe, Andrew, > > (sorry, Andrew was missing from the list...) > > 2017-09-18 11:01 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > > checkpatch.pl does not check missing blank line before module_*_driver. > > I want it to behave likewise for builtin_*_driver. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > Changes in v2: > > - Improve the matching pattern as suggested by Joe Perches > > > > scripts/checkpatch.pl | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index dd2c262aebbf..5c6179c63cf6 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -3103,6 +3103,7 @@ sub process { > > $line =~ /^\+[a-z_]*init/ || > > $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || > > $line =~ /^\+\s*DECLARE/ || > > + $line =~ /^\+\s*builtin_[\w_]*driver/ || > > $line =~ /^\+\s*__setup/)) { > > if (CHK("LINE_SPACING", > > "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) && > > -- > > 2.7.4 > > > > > Is this patch good for 4.15-rc1? > > "git log scripts/checkpatch.pl" shows > this kind of patch is generally picked up by Andrew. > > > If Joe issues Acked-by, that will be very helpful > for applying this patch. Acked-by: Joe Perches <joe@perches.com>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index dd2c262aebbf..5c6179c63cf6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3103,6 +3103,7 @@ sub process { $line =~ /^\+[a-z_]*init/ || $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || $line =~ /^\+\s*DECLARE/ || + $line =~ /^\+\s*builtin_[\w_]*driver/ || $line =~ /^\+\s*__setup/)) { if (CHK("LINE_SPACING", "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
checkpatch.pl does not check missing blank line before module_*_driver. I want it to behave likewise for builtin_*_driver. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v2: - Improve the matching pattern as suggested by Joe Perches scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) -- 2.7.4