| Message ID | 1392198583-1828-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 12 February 2014 15:19, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. > Else we get the following errors due to missing symbols: > drivers/built-in.o: In function `s6e8ax0_probe': > :(.text+0x51aec): undefined reference to `lcd_device_register' > :(.text+0x51c44): undefined reference to `lcd_device_unregister' > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/video/exynos/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig > index 976594d578a9..eb6f2b059821 100644 > --- a/drivers/video/exynos/Kconfig > +++ b/drivers/video/exynos/Kconfig > @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI > > config EXYNOS_LCD_S6E8AX0 > bool "S6E8AX0 MIPI AMOLED LCD Driver" > - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) > + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE > + depends on (LCD_CLASS_DEVICE = y) > default n > help > If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its > -- > 1.7.9.5 > Sorry, please ignore this.
On 12 February 2014 16:56, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 12/02/14 11:55, Sachin Kamat wrote: >> On 12 February 2014 15:19, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>> Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. >>> Else we get the following errors due to missing symbols: >>> drivers/built-in.o: In function `s6e8ax0_probe': >>> :(.text+0x51aec): undefined reference to `lcd_device_register' >>> :(.text+0x51c44): undefined reference to `lcd_device_unregister' >>> >>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >>> --- >>> drivers/video/exynos/Kconfig | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig >>> index 976594d578a9..eb6f2b059821 100644 >>> --- a/drivers/video/exynos/Kconfig >>> +++ b/drivers/video/exynos/Kconfig >>> @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI >>> >>> config EXYNOS_LCD_S6E8AX0 >>> bool "S6E8AX0 MIPI AMOLED LCD Driver" >>> - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) >>> + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE >>> + depends on (LCD_CLASS_DEVICE = y) >>> default n >>> help >>> If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its >>> -- >>> 1.7.9.5 >>> >> >> Sorry, please ignore this. >> > > Hmm? Why is the fix not needed? You said you have already applied this for 3.14-fixes. I accidentally sent it again.
On 12 February 2014 17:12, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 12/02/14 13:41, Sachin Kamat wrote: >> On 12 February 2014 16:56, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: >>> On 12/02/14 11:55, Sachin Kamat wrote: >>>> On 12 February 2014 15:19, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>>>> Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. >>>>> Else we get the following errors due to missing symbols: >>>>> drivers/built-in.o: In function `s6e8ax0_probe': >>>>> :(.text+0x51aec): undefined reference to `lcd_device_register' >>>>> :(.text+0x51c44): undefined reference to `lcd_device_unregister' >>>>> >>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >>>>> --- >>>>> drivers/video/exynos/Kconfig | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig >>>>> index 976594d578a9..eb6f2b059821 100644 >>>>> --- a/drivers/video/exynos/Kconfig >>>>> +++ b/drivers/video/exynos/Kconfig >>>>> @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI >>>>> >>>>> config EXYNOS_LCD_S6E8AX0 >>>>> bool "S6E8AX0 MIPI AMOLED LCD Driver" >>>>> - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) >>>>> + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE >>>>> + depends on (LCD_CLASS_DEVICE = y) >>>>> default n >>>>> help >>>>> If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its >>>>> -- >>>>> 1.7.9.5 >>>>> >>>> >>>> Sorry, please ignore this. >>>> >>> >>> Hmm? Why is the fix not needed? >> >> You said you have already applied this for 3.14-fixes. I accidentally >> sent it again. > > Ah ok. I thought the patch itself can be ignored (removed from my branch). Sorry for causing the confusion and noise. Btw, is this [1] your current tree as it doesn't look updated since some time? [1] git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git
On 12 February 2014 17:21, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 12/02/14 13:44, Sachin Kamat wrote: > >> Btw, is this [1] your current tree as it doesn't look updated since some time? >> >> [1] git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git >> > > Yes, but I haven't pushed any 3.15 or 3.14-fixes content yet. I've been > rather busy in the previous weeks. I'll try to get the current patches > pushed today. Sounds good. Thanks.
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig index 976594d578a9..eb6f2b059821 100644 --- a/drivers/video/exynos/Kconfig +++ b/drivers/video/exynos/Kconfig @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI config EXYNOS_LCD_S6E8AX0 bool "S6E8AX0 MIPI AMOLED LCD Driver" - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE + depends on (LCD_CLASS_DEVICE = y) default n help If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. Else we get the following errors due to missing symbols: drivers/built-in.o: In function `s6e8ax0_probe': :(.text+0x51aec): undefined reference to `lcd_device_register' :(.text+0x51c44): undefined reference to `lcd_device_unregister' Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/video/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)