mbox series

[net,0/2] net: ixgbe: Use new flag to disable Relaxed Ordering

Message ID 1502876507-9360-1-git-send-email-dingtianhong@huawei.com
Headers show
Series net: ixgbe: Use new flag to disable Relaxed Ordering | expand

Message

Ding Tianhong Aug. 16, 2017, 9:41 a.m. UTC
The new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added
to indicate that Relaxed Ordering Attributes (RO) should not
be used for Transaction Layer Packets (TLP) targeted toward
these affected Root Port, it will clear the bit4 in the PCIe
Device Control register, so the PCIe device drivers could
query PCIe configuration space to determine if it can send
TLPs to Root Port with the Relaxed Ordering Attributes set.

The ixgbe driver could use this flag to determine if it can
send TLPs to Root Port with the Relaxed Ordering Attributes set.

Ding Tianhong (2):
  Revert commit 1a8b6d76dc5b ("net:add one common config...")
  net: ixgbe: Use new IXGBE_FLAG2_ROOT_NO_RELAXED_ORDERING flag

 arch/Kconfig                                    |  3 --
 arch/sparc/Kconfig                              |  1 -
 drivers/net/ethernet/intel/ixgbe/ixgbe.h        |  1 +
 drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c  | 37 ++++++++++++-------------
 drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 32 +++++++++++----------
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c   | 17 ++++++++++++
 6 files changed, 53 insertions(+), 38 deletions(-)

-- 
1.8.3.1

Comments

David Miller Aug. 16, 2017, 5:56 p.m. UTC | #1
From: Ding Tianhong <dingtianhong@huawei.com>

Date: Wed, 16 Aug 2017 17:41:45 +0800

> The new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added

> to indicate that Relaxed Ordering Attributes (RO) should not

> be used for Transaction Layer Packets (TLP) targeted toward

> these affected Root Port, it will clear the bit4 in the PCIe

> Device Control register, so the PCIe device drivers could

> query PCIe configuration space to determine if it can send

> TLPs to Root Port with the Relaxed Ordering Attributes set.

> 

> The ixgbe driver could use this flag to determine if it can

> send TLPs to Root Port with the Relaxed Ordering Attributes set.


I'll let the Intel guys pick this up.
Ding Tianhong Aug. 17, 2017, 1:22 a.m. UTC | #2
On 2017/8/17 1:56, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>

> Date: Wed, 16 Aug 2017 17:41:45 +0800

> 

>> The new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added

>> to indicate that Relaxed Ordering Attributes (RO) should not

>> be used for Transaction Layer Packets (TLP) targeted toward

>> these affected Root Port, it will clear the bit4 in the PCIe

>> Device Control register, so the PCIe device drivers could

>> query PCIe configuration space to determine if it can send

>> TLPs to Root Port with the Relaxed Ordering Attributes set.

>>

>> The ixgbe driver could use this flag to determine if it can

>> send TLPs to Root Port with the Relaxed Ordering Attributes set.

> 

> I'll let the Intel guys pick this up.

> 

Thanks David, but I am not sure when the Intel guys would take over,
just Alex has replied, so I will release a new version according Alex's
suggestion.

> .

>