diff mbox series

[v7,2/3] mfd: hi6421-pmic: cleanup: update dev_err messages

Message ID 20170720073242.1758-3-guodong.xu@linaro.org
State Accepted
Commit 568e5476cf2b8dfdcf123a67b88fb724beb5487c
Headers show
Series MFD: add driver for HiSilicon Hi6421v530 PMIC | expand

Commit Message

Guodong Xu July 20, 2017, 7:32 a.m. UTC 
Update dev_err messages to make them more readable.

Signed-off-by: Guodong Xu <guodong.xu@linaro.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/mfd/hi6421-pmic-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.10.2

Comments

Lee Jones July 20, 2017, 8:53 a.m. UTC | #1 
On Thu, 20 Jul 2017, Guodong Xu wrote:

> Update dev_err messages to make them more readable.

> 

> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>

> Acked-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/mfd/hi6421-pmic-core.c | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)


Applied, thanks.

> diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c

> index ad9e3d8..b1139d4 100644

> --- a/drivers/mfd/hi6421-pmic-core.c

> +++ b/drivers/mfd/hi6421-pmic-core.c

> @@ -52,8 +52,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev)

>  	pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base,

>  						 &hi6421_regmap_config);

>  	if (IS_ERR(pmic->regmap)) {

> -		dev_err(&pdev->dev,

> -			"regmap init failed: %ld\n", PTR_ERR(pmic->regmap));

> +		dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n",

> +						PTR_ERR(pmic->regmap));

>  		return PTR_ERR(pmic->regmap);

>  	}

>  

> @@ -70,7 +70,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev)

>  	ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs,

>  				   ARRAY_SIZE(hi6421_devs), NULL, 0, NULL);

>  	if (ret) {

> -		dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret);

> +		dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret);

>  		return ret;

>  	}

>  


-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
index ad9e3d8..b1139d4 100644
--- a/drivers/mfd/hi6421-pmic-core.c
+++ b/drivers/mfd/hi6421-pmic-core.c
@@ -52,8 +52,8 @@  static int hi6421_pmic_probe(struct platform_device *pdev)
 	pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base,
 						 &hi6421_regmap_config);
 	if (IS_ERR(pmic->regmap)) {
-		dev_err(&pdev->dev,
-			"regmap init failed: %ld\n", PTR_ERR(pmic->regmap));
+		dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n",
+						PTR_ERR(pmic->regmap));
 		return PTR_ERR(pmic->regmap);
 	}
 
@@ -70,7 +70,7 @@  static int hi6421_pmic_probe(struct platform_device *pdev)
 	ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs,
 				   ARRAY_SIZE(hi6421_devs), NULL, 0, NULL);
 	if (ret) {
-		dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret);
+		dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret);
 		return ret;
 	}