| Message ID | 1391504833-20022-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
> Semicolon is not necessary after the while statement. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mfd/stmpe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c > index 42ccd0544513..4a91f6771fb8 100644 > --- a/drivers/mfd/stmpe.c > +++ b/drivers/mfd/stmpe.c > @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe) > if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET)) > return 0; > usleep_range(100, 200); > - }; > + } > return -EIO; > } Can you re-submit with a new line between it and the return please?
On 4 February 2014 14:46, Lee Jones <lee.jones@linaro.org> wrote: >> Semicolon is not necessary after the while statement. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/mfd/stmpe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c >> index 42ccd0544513..4a91f6771fb8 100644 >> --- a/drivers/mfd/stmpe.c >> +++ b/drivers/mfd/stmpe.c >> @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe) >> if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET)) >> return 0; >> usleep_range(100, 200); >> - }; >> + } >> return -EIO; >> } > > Can you re-submit with a new line between it and the return please? Sure. In a minute :)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c index 42ccd0544513..4a91f6771fb8 100644 --- a/drivers/mfd/stmpe.c +++ b/drivers/mfd/stmpe.c @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe) if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET)) return 0; usleep_range(100, 200); - }; + } return -EIO; }
Semicolon is not necessary after the while statement. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/mfd/stmpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)