| Message ID | 20170703080331.5973-1-fathi.boudra@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Hi, On Mon, Jul 03, 2017 at 11:03:31AM +0300, Fathi Boudra wrote: > * Use a list and re-order alphabetically to make it easier to read and > update. > * Add missing runtime dependencies: > - acl (getfacl/setfacl commands are required) > - attr (getfattr/setfattr commands are required) > - curl (curl command is required) > - util-linux (ipcs command is required) > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > meta/recipes-extended/ltp/ltp_20170516.bb | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-extended/ltp/ltp_20170516.bb b/meta/recipes-extended/ltp/ltp_20170516.bb > index f537d60c15..564fdcf8c2 100644 > --- a/meta/recipes-extended/ltp/ltp_20170516.bb > +++ b/meta/recipes-extended/ltp/ltp_20170516.bb > @@ -95,7 +95,27 @@ do_install(){ > cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases > } > > -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs python-core libaio bash gawk expect ldd unzip gzip cpio cronie logrotate which at" > +RDEPENDS_${PN} = " > + acl \ > + at \ > + attr \ > + bash \ > + cpio \ > + cronie \ > + curl \ > + e2fsprogs-mke2fs \ > + expect \ > + gawk \ > + gzip \ > + ldd \ > + libaio \ > + logrotate \ > + perl \ > + python-core \ > + unzip \ > + util-linux \ > + which \ > +" These changes look good. However, this patch is causing a parser error: ERROR: ParseError at /home/maxin/poky/meta/recipes-extended/ltp/ltp_20170516.bb:98: unparsed line: 'RDEPENDS_${PN} = " Please fix it. > FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" > > @@ -106,4 +126,3 @@ INHIBIT_PACKAGE_STRIP = "1" > INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > # However, test_arch_stripped is already stripped, so... > INSANE_SKIP_${PN} += "already-stripped" Best Regards, Maxin -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 2017年07月03日 16:59, Maxin B. John wrote: > Hi, > > On Mon, Jul 03, 2017 at 11:03:31AM +0300, Fathi Boudra wrote: >> * Use a list and re-order alphabetically to make it easier to read and >> update. >> * Add missing runtime dependencies: >> - acl (getfacl/setfacl commands are required) >> - attr (getfattr/setfattr commands are required) >> - curl (curl command is required) >> - util-linux (ipcs command is required) >> >> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> --- >> meta/recipes-extended/ltp/ltp_20170516.bb | 23 +++++++++++++++++++++-- >> 1 file changed, 21 insertions(+), 2 deletions(-) >> >> diff --git a/meta/recipes-extended/ltp/ltp_20170516.bb b/meta/recipes-extended/ltp/ltp_20170516.bb >> index f537d60c15..564fdcf8c2 100644 >> --- a/meta/recipes-extended/ltp/ltp_20170516.bb >> +++ b/meta/recipes-extended/ltp/ltp_20170516.bb >> @@ -95,7 +95,27 @@ do_install(){ >> cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases >> } >> >> -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs python-core libaio bash gawk expect ldd unzip gzip cpio cronie logrotate which at" >> +RDEPENDS_${PN} = " should be: RDEPENDS_${PN} = " \ >> + acl \ >> + at \ >> + attr \ >> + bash \ >> + cpio \ >> + cronie \ >> + curl \ >> + e2fsprogs-mke2fs \ >> + expect \ >> + gawk \ >> + gzip \ >> + ldd \ >> + libaio \ >> + logrotate \ >> + perl \ >> + python-core \ >> + unzip \ >> + util-linux \ >> + which \ >> +" > These changes look good. However, this patch is causing a parser error: > ERROR: ParseError at /home/maxin/poky/meta/recipes-extended/ltp/ltp_20170516.bb:98: unparsed line: 'RDEPENDS_${PN} = " > > Please fix it. > >> FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" >> >> @@ -106,4 +126,3 @@ INHIBIT_PACKAGE_STRIP = "1" >> INHIBIT_PACKAGE_DEBUG_SPLIT = "1" >> # However, test_arch_stripped is already stripped, so... >> INSANE_SKIP_${PN} += "already-stripped" > Best Regards, > Maxin
On 3 July 2017 at 11:59, Maxin B. John <maxin.john@intel.com> wrote: > Hi, > > On Mon, Jul 03, 2017 at 11:03:31AM +0300, Fathi Boudra wrote: >> * Use a list and re-order alphabetically to make it easier to read and >> update. >> * Add missing runtime dependencies: >> - acl (getfacl/setfacl commands are required) >> - attr (getfattr/setfattr commands are required) >> - curl (curl command is required) >> - util-linux (ipcs command is required) >> >> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> --- >> meta/recipes-extended/ltp/ltp_20170516.bb | 23 +++++++++++++++++++++-- >> 1 file changed, 21 insertions(+), 2 deletions(-) >> >> diff --git a/meta/recipes-extended/ltp/ltp_20170516.bb b/meta/recipes-extended/ltp/ltp_20170516.bb >> index f537d60c15..564fdcf8c2 100644 >> --- a/meta/recipes-extended/ltp/ltp_20170516.bb >> +++ b/meta/recipes-extended/ltp/ltp_20170516.bb >> @@ -95,7 +95,27 @@ do_install(){ >> cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases >> } >> >> -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs python-core libaio bash gawk expect ldd unzip gzip cpio cronie logrotate which at" >> +RDEPENDS_${PN} = " >> + acl \ >> + at \ >> + attr \ >> + bash \ >> + cpio \ >> + cronie \ >> + curl \ >> + e2fsprogs-mke2fs \ >> + expect \ >> + gawk \ >> + gzip \ >> + ldd \ >> + libaio \ >> + logrotate \ >> + perl \ >> + python-core \ >> + unzip \ >> + util-linux \ >> + which \ >> +" > > These changes look good. However, this patch is causing a parser error: > ERROR: ParseError at /home/maxin/poky/meta/recipes-extended/ltp/ltp_20170516.bb:98: unparsed line: 'RDEPENDS_${PN} = " > > Please fix it. fixed in v2: https://patchwork.openembedded.org/patch/141483/ >> FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" >> >> @@ -106,4 +126,3 @@ INHIBIT_PACKAGE_STRIP = "1" >> INHIBIT_PACKAGE_DEBUG_SPLIT = "1" >> # However, test_arch_stripped is already stripped, so... >> INSANE_SKIP_${PN} += "already-stripped" > > Best Regards, > Maxin -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-extended/ltp/ltp_20170516.bb b/meta/recipes-extended/ltp/ltp_20170516.bb index f537d60c15..564fdcf8c2 100644 --- a/meta/recipes-extended/ltp/ltp_20170516.bb +++ b/meta/recipes-extended/ltp/ltp_20170516.bb @@ -95,7 +95,27 @@ do_install(){ cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases } -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs python-core libaio bash gawk expect ldd unzip gzip cpio cronie logrotate which at" +RDEPENDS_${PN} = " + acl \ + at \ + attr \ + bash \ + cpio \ + cronie \ + curl \ + e2fsprogs-mke2fs \ + expect \ + gawk \ + gzip \ + ldd \ + libaio \ + logrotate \ + perl \ + python-core \ + unzip \ + util-linux \ + which \ +" FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" @@ -106,4 +126,3 @@ INHIBIT_PACKAGE_STRIP = "1" INHIBIT_PACKAGE_DEBUG_SPLIT = "1" # However, test_arch_stripped is already stripped, so... INSANE_SKIP_${PN} += "already-stripped" -
* Use a list and re-order alphabetically to make it easier to read and update. * Add missing runtime dependencies: - acl (getfacl/setfacl commands are required) - attr (getfattr/setfattr commands are required) - curl (curl command is required) - util-linux (ipcs command is required) Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> --- meta/recipes-extended/ltp/ltp_20170516.bb | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) -- 2.13.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core