mbox series

[API-NEXT,0/4] Clean up scheduler interface

Message ID 20170630141056.11272-1-petri.savolainen@linaro.org
Headers show
Series Clean up scheduler interface | expand

Message

Petri Savolainen June 30, 2017, 2:10 p.m. UTC
First removed dependency to queue internals from scheduler interface. Then 
removed almost all references to queue internals from default and iquery 
schedulers. This required move of ordered queue data structure from queue to 
scheduler files. The last references require queue / pktio interface change and 
thus is left as the next step. Scheduler performance increased couple of 
percents.


Petri Savolainen (4):
  linux-gen: sched: remove schedule interface depedency to qentry
  linux-gen: sched: use config max ordered locks
  linux-gen: sched: remove most dependecies to qentry
  linux-gen: sched: remove unused sched interface functions

 .../linux-generic/include/odp_config_internal.h    |   2 +-
 .../linux-generic/include/odp_queue_internal.h     |   7 -
 platform/linux-generic/include/odp_schedule_if.h   |  13 +-
 platform/linux-generic/odp_queue.c                 |  68 +--------
 platform/linux-generic/odp_schedule.c              | 161 +++++++++++++--------
 platform/linux-generic/odp_schedule_iquery.c       | 158 ++++++++++++--------
 platform/linux-generic/odp_schedule_sp.c           |  18 +--
 7 files changed, 211 insertions(+), 216 deletions(-)

-- 
2.13.0

Comments

Bill Fischofer June 30, 2017, 3:51 p.m. UTC | #1
For this series:

Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org>

On Fri, Jun 30, 2017 at 9:10 AM, Petri Savolainen
<petri.savolainen@linaro.org> wrote:
> First removed dependency to queue internals from scheduler interface. Then

> removed almost all references to queue internals from default and iquery

> schedulers. This required move of ordered queue data structure from queue to

> scheduler files. The last references require queue / pktio interface change and

> thus is left as the next step. Scheduler performance increased couple of

> percents.

>

>

> Petri Savolainen (4):

>   linux-gen: sched: remove schedule interface depedency to qentry

>   linux-gen: sched: use config max ordered locks

>   linux-gen: sched: remove most dependecies to qentry

>   linux-gen: sched: remove unused sched interface functions

>

>  .../linux-generic/include/odp_config_internal.h    |   2 +-

>  .../linux-generic/include/odp_queue_internal.h     |   7 -

>  platform/linux-generic/include/odp_schedule_if.h   |  13 +-

>  platform/linux-generic/odp_queue.c                 |  68 +--------

>  platform/linux-generic/odp_schedule.c              | 161 +++++++++++++--------

>  platform/linux-generic/odp_schedule_iquery.c       | 158 ++++++++++++--------

>  platform/linux-generic/odp_schedule_sp.c           |  18 +--

>  7 files changed, 211 insertions(+), 216 deletions(-)

>

> --

> 2.13.0

>
Savolainen, Petri (Nokia - FI/Espoo) July 7, 2017, 6:54 a.m. UTC | #2
This is the first step to clean up queue / scheduler dependencies. Could we merge this now and continue towards the next steps. Master and api-next should be synced soon otherwise the code base delta just increases for no real reason (API is the same).

-Petri

> -----Original Message-----

> From: Bill Fischofer [mailto:bill.fischofer@linaro.org]

> Sent: Friday, June 30, 2017 6:51 PM

> To: Petri Savolainen <petri.savolainen@linaro.org>

> Cc: lng-odp-forward <lng-odp@lists.linaro.org>

> Subject: Re: [lng-odp] [API-NEXT PATCH 0/4] Clean up scheduler interface

> 

> For this series:

> 

> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org>

> 

> On Fri, Jun 30, 2017 at 9:10 AM, Petri Savolainen

> <petri.savolainen@linaro.org> wrote:

> > First removed dependency to queue internals from scheduler interface.

> Then

> > removed almost all references to queue internals from default and iquery

> > schedulers. This required move of ordered queue data structure from

> queue to

> > scheduler files. The last references require queue / pktio interface

> change and

> > thus is left as the next step. Scheduler performance increased couple of

> > percents.

> >

> >

> > Petri Savolainen (4):

> >   linux-gen: sched: remove schedule interface depedency to qentry

> >   linux-gen: sched: use config max ordered locks

> >   linux-gen: sched: remove most dependecies to qentry

> >   linux-gen: sched: remove unused sched interface functions

> >

> >  .../linux-generic/include/odp_config_internal.h    |   2 +-

> >  .../linux-generic/include/odp_queue_internal.h     |   7 -

> >  platform/linux-generic/include/odp_schedule_if.h   |  13 +-

> >  platform/linux-generic/odp_queue.c                 |  68 +--------

> >  platform/linux-generic/odp_schedule.c              | 161 +++++++++++++-

> -------

> >  platform/linux-generic/odp_schedule_iquery.c       | 158 ++++++++++++--

> ------

> >  platform/linux-generic/odp_schedule_sp.c           |  18 +--

> >  7 files changed, 211 insertions(+), 216 deletions(-)

> >

> > --

> > 2.13.0

> >