| Message ID | 20170621220115.4100076-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | d0318fb3c388a4082a4ea2b94fc242cd5c064cea |
| Headers | show |
On Thu, Jun 22, 2017 at 12:00:55AM +0200, Arnd Bergmann wrote: > The new driver uses an incorrect format string for resource_size_t: > > drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe': > drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] > > The nicest way to print the address is to pretty-print the resource > using %pR. > > Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied to libata/for-4.13. Thanks. -- Tejun
On Thu, Jun 22, 2017 at 12:00 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The new driver uses an incorrect format string for resource_size_t: > > drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe': > drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] > > The nicest way to print the address is to pretty-print the resource > using %pR. > > Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c index 7b7e417ba8ba..5d4b72e21161 100644 --- a/drivers/ata/pata_ftide010.c +++ b/drivers/ata/pata_ftide010.c @@ -517,8 +517,8 @@ static int pata_ftide010_probe(struct platform_device *pdev) ata_sff_std_ports(ioaddr); } - dev_info(dev, "device ID %08x, irq %d, io base 0x%08x\n", - readl(ftide->base + FTIDE010_IDE_DEVICE_ID), irq, res->start); + dev_info(dev, "device ID %08x, irq %d, reg %pR\n", + readl(ftide->base + FTIDE010_IDE_DEVICE_ID), irq, res); ret = ata_host_activate(ftide->host, irq, ata_bmdma_interrupt, 0, &pata_ftide010_sht);
The new driver uses an incorrect format string for resource_size_t: drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe': drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] The nicest way to print the address is to pretty-print the resource using %pR. Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/ata/pata_ftide010.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0