| Message ID | 20170621220943.104170-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 664d00d187608c66904e62ff2f24e7df49611ba5 |
| Headers | show |
On Wed, Jun 21, 2017 at 4:09 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Without CONFIG_I2C, we get a build failure: > > sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror] > sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] > sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror] > sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable] > > This adds the required Kconfig dependency. > > Fixes: b8b88b70875a ("ASoC: add es8316 codec driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Daniel Drake <drake@endlessm.com> Thanks for the patch. > --- > sound/soc/codecs/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > index c6286e5ba511..f0f794186186 100644 > --- a/sound/soc/codecs/Kconfig > +++ b/sound/soc/codecs/Kconfig > @@ -546,6 +546,7 @@ config SND_SOC_ES7134 > > config SND_SOC_ES8316 > tristate "Everest Semi ES8316 CODEC" > + depends on I2C > > config SND_SOC_ES8328 > tristate > -- > 2.9.0 >
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c6286e5ba511..f0f794186186 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -546,6 +546,7 @@ config SND_SOC_ES7134 config SND_SOC_ES8316 tristate "Everest Semi ES8316 CODEC" + depends on I2C config SND_SOC_ES8328 tristate
Without CONFIG_I2C, we get a build failure: sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror] sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror] sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable] This adds the required Kconfig dependency. Fixes: b8b88b70875a ("ASoC: add es8316 codec driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0