| Message ID | 1451910472-126417-3-git-send-email-puck.chen@hisilicon.com |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Jan 04, 2016 at 08:27:49PM +0800, Chen Feng wrote:
> Add Document for hi655x pmic regulator driver
As indicated in the driver review this seems to be a bit of an unusual
binding that I think needs reworking, also it needs a bit more detail -
for example, listing which regulator names are valid.
Please also use subject lines reflecting the normal style for the
subsystem.
On 2016/1/5 23:47, Mark Brown wrote: > On Mon, Jan 04, 2016 at 08:27:49PM +0800, Chen Feng wrote: >> Add Document for hi655x pmic regulator driver > > As indicated in the driver review this seems to be a bit of an unusual > binding that I think needs reworking, also it needs a bit more detail - > for example, listing which regulator names are valid. > > Please also use subject lines reflecting the normal style for the > subsystem. > OK,Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt new file mode 100644 index 0000000..1cf71a0 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt @@ -0,0 +1,24 @@ +Hisilicon Hi655x Voltage regulators + +Note: +The hi655x regulator control is managed by hi655x Power IC. +So the node of this regulator must be child node of hi655x +pmic node. + +The driver uses the regulator core framework, so please also +take the bindings of regulator.txt for reference. + +Example: + pmic: pmic@f8000000 { + compatible = "hisilicon,hi655x-pmic"; + ... + ldo2: ldo2@a21 { + compatible = "hisilicon,hi655x-regulator"; + regulator-name = "ldo2"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <3200000>; + regulator-valid-modes-mask = <0x02>; + regulator-enable-ramp-delay = <120>; + }; + ... + }