| Message ID | 1496826502-1339-1-git-send-email-ulf.hansson@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: hi6220-hikey: Fix Bluetooth support | expand |
On Wed, Jun 7, 2017 at 2:08 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > The commit ea452678734e ("arm64: dts: hikey: Fix WiFi support") indeed managed > to fix the WiFi support for the Hikey board. However, it also caused the > Bluetooth to break. > > The reason to the problem is because part of the fixes for WiFi, involved > explicitly to start manage the external clock for the TI WiLink chip, as it's > needed to properly power on/off WiFi. Then, because the Bluetooth driver, > hci_ll, don't manage the clock, it fails to initialize Bluetooth. > > This small series add support and DT bindings for the external clock, now > properly managed by the hci_ll driver during power on/off. On top of that, the > external clock is added to the Bluetooth DT node in the Hikey DTS file. > > The regression has been reported by John Stultz, running a Hikey board with > UEFI based boot. I have confirmed that there is no regressions with u-boot as > we still don't have bluetooth working on that set up. I intend to fix that as > well, although in second step and not being part of a fixup series. > > John, can you please confirm/test this on your Hikey board using UEFI!? Yes. This does resolve the issue! Bluetooth and wifi are now working together again as they were before ea452678734e. For the whole set: Tested-by: John Stultz <john.stultz@linaro.org> Thanks so much for working this out Ulf! -john -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/06/2017 21:07, John Stultz wrote: > On Wed, Jun 7, 2017 at 2:08 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote: >> The commit ea452678734e ("arm64: dts: hikey: Fix WiFi support") indeed managed >> to fix the WiFi support for the Hikey board. However, it also caused the >> Bluetooth to break. >> >> The reason to the problem is because part of the fixes for WiFi, involved >> explicitly to start manage the external clock for the TI WiLink chip, as it's >> needed to properly power on/off WiFi. Then, because the Bluetooth driver, >> hci_ll, don't manage the clock, it fails to initialize Bluetooth. >> >> This small series add support and DT bindings for the external clock, now >> properly managed by the hci_ll driver during power on/off. On top of that, the >> external clock is added to the Bluetooth DT node in the Hikey DTS file. >> >> The regression has been reported by John Stultz, running a Hikey board with >> UEFI based boot. I have confirmed that there is no regressions with u-boot as >> we still don't have bluetooth working on that set up. I intend to fix that as >> well, although in second step and not being part of a fixup series. >> >> John, can you please confirm/test this on your Hikey board using UEFI!? > > Yes. This does resolve the issue! Bluetooth and wifi are now working > together again as they were before ea452678734e. > > For the whole set: > Tested-by: John Stultz <john.stultz@linaro.org> Great ! Thanks John for testing. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulf, > The commit ea452678734e ("arm64: dts: hikey: Fix WiFi support") indeed managed > to fix the WiFi support for the Hikey board. However, it also caused the > Bluetooth to break. > > The reason to the problem is because part of the fixes for WiFi, involved > explicitly to start manage the external clock for the TI WiLink chip, as it's > needed to properly power on/off WiFi. Then, because the Bluetooth driver, > hci_ll, don't manage the clock, it fails to initialize Bluetooth. > > This small series add support and DT bindings for the external clock, now > properly managed by the hci_ll driver during power on/off. On top of that, the > external clock is added to the Bluetooth DT node in the Hikey DTS file. > > The regression has been reported by John Stultz, running a Hikey board with > UEFI based boot. I have confirmed that there is no regressions with u-boot as > we still don't have bluetooth working on that set up. I intend to fix that as > well, although in second step and not being part of a fixup series. > > John, can you please confirm/test this on your Hikey board using UEFI!? > > Perhaps this can go in via the bluetooth git, when respective patches has got > an ack. Or whatever you think is best. > > Ulf Hansson (3): > dt-bindings: net: Add binding for the external clock for TI WiLink > Bluetooth: hci_ll: Add support for the external clock > arm64: dts: hikey: Add external clock to the Bluetooth node > > Documentation/devicetree/bindings/net/ti,wilink-st.txt | 6 ++++++ > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 ++ > drivers/bluetooth/hci_ll.c | 14 +++++++++++++- > 3 files changed, 21 insertions(+), 1 deletion(-) all 3 patches have been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
The commit ea452678734e ("arm64: dts: hikey: Fix WiFi support") indeed managed to fix the WiFi support for the Hikey board. However, it also caused the Bluetooth to break. The reason to the problem is because part of the fixes for WiFi, involved explicitly to start manage the external clock for the TI WiLink chip, as it's needed to properly power on/off WiFi. Then, because the Bluetooth driver, hci_ll, don't manage the clock, it fails to initialize Bluetooth. This small series add support and DT bindings for the external clock, now properly managed by the hci_ll driver during power on/off. On top of that, the external clock is added to the Bluetooth DT node in the Hikey DTS file. The regression has been reported by John Stultz, running a Hikey board with UEFI based boot. I have confirmed that there is no regressions with u-boot as we still don't have bluetooth working on that set up. I intend to fix that as well, although in second step and not being part of a fixup series. John, can you please confirm/test this on your Hikey board using UEFI!? Perhaps this can go in via the bluetooth git, when respective patches has got an ack. Or whatever you think is best. Ulf Hansson (3): dt-bindings: net: Add binding for the external clock for TI WiLink Bluetooth: hci_ll: Add support for the external clock arm64: dts: hikey: Add external clock to the Bluetooth node Documentation/devicetree/bindings/net/ti,wilink-st.txt | 6 ++++++ arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 ++ drivers/bluetooth/hci_ll.c | 14 +++++++++++++- 3 files changed, 21 insertions(+), 1 deletion(-) -- 2.7.4