| Message ID | 1495557626-25285-1-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Accepted |
| Commit | b2cc3c8071bee6e3defa54b701671d310cb94f3c |
| Headers | show |
On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <xinliang.liu@linaro.org> wrote: > On 24 May 2017 at 00:40, John Stultz <john.stultz@linaro.org> wrote: >> >> This fixes a regression introduced by ebc944613567 ("drm: >> convert drivers to use drm_of_find_panel_or_bridge") that was >> recently merged, causing HDMI output to not work. >> >> For the kirin driver, the port value should be 1 instead of 0, >> so this oneline patch fixes it and gets graphics working again. >> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Archit Taneja <architt@codeaurora.org> >> Cc: Philipp Zabel <p.zabel@pengutronix.de> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >> Cc: Sean Paul <seanpaul@chromium.org> >> Cc: Dave Airlie <airlied@gmail.com> >> Cc: >> Xinliang Liu <xinliang.liu@linaro.org> >> Fix-suggested-by: Rob Herring <robh@kernel.org> >> Signed-off-by: John Stultz <john.stultz@linaro.org> > > > Looks good to me. Thanks for the patch. > > Reviewed-by: > Xinliang Liu <xinliang.liu@linaro.org> > Just wanted to check in on this. Is there someone I'm missing from the cc list on this? thanks -john
On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <john.stultz@linaro.org> wrote: > On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <xinliang.liu@linaro.org> wrote: >> On 24 May 2017 at 00:40, John Stultz <john.stultz@linaro.org> wrote: >>> >>> This fixes a regression introduced by ebc944613567 ("drm: >>> convert drivers to use drm_of_find_panel_or_bridge") that was >>> recently merged, causing HDMI output to not work. >>> >>> For the kirin driver, the port value should be 1 instead of 0, >>> so this oneline patch fixes it and gets graphics working again. >>> >>> Cc: Rob Herring <robh@kernel.org> >>> Cc: Archit Taneja <architt@codeaurora.org> >>> Cc: Philipp Zabel <p.zabel@pengutronix.de> >>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >>> Cc: Sean Paul <seanpaul@chromium.org> >>> Cc: Dave Airlie <airlied@gmail.com> >>> Cc: >>> Xinliang Liu <xinliang.liu@linaro.org> >>> Fix-suggested-by: Rob Herring <robh@kernel.org> >>> Signed-off-by: John Stultz <john.stultz@linaro.org> >> >> >> Looks good to me. Thanks for the patch. >> >> Reviewed-by: >> Xinliang Liu <xinliang.liu@linaro.org> >> > > Just wanted to check in on this. Is there someone I'm missing from the > cc list on this? > Hi John, Apologies, I just saw this. Slipped through my cracks because it's not posted on dri-devel. The patch looks good. I'll pick it up in drm-misc-fixes if Dave doesn't take it directly into drm-fixes. Sean > thanks > -john
On Fri, Jun 2, 2017 at 2:52 PM, Sean Paul <seanpaul@chromium.org> wrote: > On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <john.stultz@linaro.org> wrote: >> On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <xinliang.liu@linaro.org> wrote: >>> On 24 May 2017 at 00:40, John Stultz <john.stultz@linaro.org> wrote: >>>> >>>> This fixes a regression introduced by ebc944613567 ("drm: >>>> convert drivers to use drm_of_find_panel_or_bridge") that was >>>> recently merged, causing HDMI output to not work. >>>> >>>> For the kirin driver, the port value should be 1 instead of 0, >>>> so this oneline patch fixes it and gets graphics working again. >>>> >>>> Cc: Rob Herring <robh@kernel.org> >>>> Cc: Archit Taneja <architt@codeaurora.org> >>>> Cc: Philipp Zabel <p.zabel@pengutronix.de> >>>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >>>> Cc: Sean Paul <seanpaul@chromium.org> >>>> Cc: Dave Airlie <airlied@gmail.com> >>>> Cc: >>>> Xinliang Liu <xinliang.liu@linaro.org> >>>> Fix-suggested-by: Rob Herring <robh@kernel.org> >>>> Signed-off-by: John Stultz <john.stultz@linaro.org> >>> >>> >>> Looks good to me. Thanks for the patch. >>> >>> Reviewed-by: >>> Xinliang Liu <xinliang.liu@linaro.org> >>> >> >> Just wanted to check in on this. Is there someone I'm missing from the >> cc list on this? >> > > Hi John, > Apologies, I just saw this. Slipped through my cracks because it's not > posted on dri-devel. > > The patch looks good. I'll pick it up in drm-misc-fixes if Dave > doesn't take it directly into drm-fixes. > Hi John, I've picked this up in drm-misc-fixes. Thanks again for the patch, Sean > Sean > > >> thanks >> -john
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 5abc69c..f77dcfa 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -760,7 +760,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi) * Get the endpoint node. In our case, dsi has one output port1 * to which the external HDMI bridge is connected. */ - ret = drm_of_find_panel_or_bridge(np, 0, 0, NULL, &dsi->bridge); + ret = drm_of_find_panel_or_bridge(np, 1, 0, NULL, &dsi->bridge); if (ret) return ret;
This fixes a regression introduced by ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge") that was recently merged, causing HDMI output to not work. For the kirin driver, the port value should be 1 instead of 0, so this oneline patch fixes it and gets graphics working again. Cc: Rob Herring <robh@kernel.org> Cc: Archit Taneja <architt@codeaurora.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Sean Paul <seanpaul@chromium.org> Cc: Dave Airlie <airlied@gmail.com> Cc: Xinliang Liu <xinliang.liu@linaro.org> Fix-suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: John Stultz <john.stultz@linaro.org> --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4