| Message ID | 3768541.ja0r6f0Odi@wuerfel |
|---|---|
| State | New |
| Headers | show |
On Fri, Nov 27, 2015 at 5:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: > - do_div(size, bs); /* convert size to pages */ > - do_div(size, 256); /* concert size to pgs pr blk */ > + sector_div(size, bs); /* convert size to pages */ > + sector_div(size, 256); /* concert size to pgs pr blk */ Ugh. Dividing by 256 should never be done with do_div() *or* sector-div. Same goes for this, which is just obnoxiously idiotic: > - do_div(size, (1 << 16)); > + sector_div(size, (1 << 16)); WTF? It explicitly divides by a particular power-of-two? Has nobody ever heard of expensive divide operations? Sure, for the cases where we *don't* do this with inline asm etc because it's already fairly cheap, the compiler will DTRT. But that "divide by (1 << 16)" is just a sign of insanity. Why is that not just size >>= 16; instead, which is certainly not any less legible, and won't generate potentially crap code? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Friday 27 November 2015 10:07:54 Linus Torvalds wrote: > On Fri, Nov 27, 2015 at 5:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > - do_div(size, bs); /* convert size to pages */ > > - do_div(size, 256); /* concert size to pgs pr blk */ > > + sector_div(size, bs); /* convert size to pages */ > > + sector_div(size, 256); /* concert size to pgs pr blk */ > > Ugh. > > Dividing by 256 should never be done with do_div() *or* sector-div. You are right, I missed what should have been an obvious simplification. FWIW, the division by 256 should now be optimized automatically when the new asm-generic do_div() implementation is used (which in turn caused the type mismatch warning that I'm trying to avoid). Of course that is no excuse for writing silly code like that, and it doesn't catch the cases where the argument is a power-of-two variable number. The first do_div() is also questionable: 'bs' is a global variable from a module parameter that defaults to 512 and is fixed to 4096 when the device is used for lightnvm. I would guess that we run into bugs if this is ever set to a number that is not a power of two, smaller than 512, or larger than PAGE_SIZE. > Same goes for this, which is just obnoxiously idiotic: > > > - do_div(size, (1 << 16)); > > + sector_div(size, (1 << 16)); > > WTF? It explicitly divides by a particular power-of-two? > > Has nobody ever heard of expensive divide operations? Sure, for the > cases where we *don't* do this with inline asm etc because it's > already fairly cheap, the compiler will DTRT. But that "divide by (1 > << 16)" is just a sign of insanity. > > Why is that not just > > size >>= 16; > > instead, which is certainly not any less legible, and won't generate > potentially crap code? I'll wait for Matias or Jens to comment on the blocksize, but can do a new patch unless they beat me to it. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 11/27/2015 10:31 PM, Arnd Bergmann wrote: > On Friday 27 November 2015 10:07:54 Linus Torvalds wrote: >> On Fri, Nov 27, 2015 at 5:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: >>> - do_div(size, bs); /* convert size to pages */ >>> - do_div(size, 256); /* concert size to pgs pr blk */ >>> + sector_div(size, bs); /* convert size to pages */ >>> + sector_div(size, 256); /* concert size to pgs pr blk */ >> >> Ugh. >> >> Dividing by 256 should never be done with do_div() *or* sector-div. > > You are right, I missed what should have been an obvious simplification. > FWIW, the division by 256 should now be optimized automatically when the > new asm-generic do_div() implementation is used (which in turn caused > the type mismatch warning that I'm trying to avoid). Of course that > is no excuse for writing silly code like that, and it doesn't catch the > cases where the argument is a power-of-two variable number. > > The first do_div() is also questionable: 'bs' is a global variable > from a module parameter that defaults to 512 and is fixed to 4096 > when the device is used for lightnvm. I would guess that we run into > bugs if this is ever set to a number that is not a power of two, > smaller than 512, or larger than PAGE_SIZE. > >> Same goes for this, which is just obnoxiously idiotic: >> >>> - do_div(size, (1 << 16)); >>> + sector_div(size, (1 << 16)); >> >> WTF? It explicitly divides by a particular power-of-two? >> >> Has nobody ever heard of expensive divide operations? Sure, for the >> cases where we *don't* do this with inline asm etc because it's >> already fairly cheap, the compiler will DTRT. But that "divide by (1 >> << 16)" is just a sign of insanity. >> >> Why is that not just >> >> size >>= 16; >> >> instead, which is certainly not any less legible, and won't generate >> potentially crap code? > > I'll wait for Matias or Jens to comment on the blocksize, but can > do a new patch unless they beat me to it. > > Arnd > Thanks Arnd and Linus. I had my head around the original code and kept references to the device layout I had in mind. 256 being number of pages in a block, and the 2^16 being number of blocks in a lun and wanted to communicate that part.. which led to producing silly code in the mean time. Similarly, the bs is always fixed to 4k for lightnvm, until other bs sizes are supported. We could optimize it out, I left it in for the same reasons. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/diff --git i/drivers/block/null_blk.c w/drivers/block/null_blk.c index 5c8ba54..97c02fe 100644 --- i/drivers/block/null_blk.c +++ w/drivers/block/null_blk.c @@ -510,17 +510,17 @@ static int null_lnvm_id(struct request_queue *q, struct nvm_id *id) id->ppaf.ch_offset = 56; id->ppaf.ch_len = 8; - do_div(size, bs); /* convert size to pages */ - do_div(size, 256); /* concert size to pgs pr blk */ + sector_div(size, bs); /* convert size to pages */ + size >>= 8; /* convert size to pgs pr blk */ grp = &id->groups[0]; grp->mtype = 0; grp->fmtype = 0; grp->num_ch = 1; grp->num_pg = 256; blksize = size; - do_div(size, (1 << 16)); + size >>= 16; /* convert size to num luns */ grp->num_lun = size + 1; - do_div(blksize, grp->num_lun); + sector_div(blksize, grp->num_lun); grp->num_blk = blksize; grp->num_pln = 1;
On 11/27/2015 02:31 PM, Arnd Bergmann wrote: > On Friday 27 November 2015 10:07:54 Linus Torvalds wrote: >> On Fri, Nov 27, 2015 at 5:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: >>> - do_div(size, bs); /* convert size to pages */ >>> - do_div(size, 256); /* concert size to pgs pr blk */ >>> + sector_div(size, bs); /* convert size to pages */ >>> + sector_div(size, 256); /* concert size to pgs pr blk */ >> >> Ugh. >> >> Dividing by 256 should never be done with do_div() *or* sector-div. > > You are right, I missed what should have been an obvious simplification. > FWIW, the division by 256 should now be optimized automatically when the > new asm-generic do_div() implementation is used (which in turn caused > the type mismatch warning that I'm trying to avoid). Of course that > is no excuse for writing silly code like that, and it doesn't catch the > cases where the argument is a power-of-two variable number. > > The first do_div() is also questionable: 'bs' is a global variable > from a module parameter that defaults to 512 and is fixed to 4096 > when the device is used for lightnvm. I would guess that we run into > bugs if this is ever set to a number that is not a power of two, > smaller than 512, or larger than PAGE_SIZE. We can use the shift, but honestly, it's just setup code. For hot paths, avoiding the div is definitely of higher priority. And for the sake of people copy/pasting or similar, making it a shift is probably a good idea. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Saturday 28 November 2015 09:05:56 Matias Bjørling wrote: > > I had my head around the original code and kept references to the device > layout I had in mind. 256 being number of pages in a block, and the 2^16 > being number of blocks in a lun and wanted to communicate that part.. > which led to producing silly code in the mean time. > > Similarly, the bs is always fixed to 4k for lightnvm, until other bs > sizes are supported. We could optimize it out, I left it in for the same > reasons. I still see the build warning in linux-next, can you merge your patch? Arnd > diff --git i/drivers/block/null_blk.c w/drivers/block/null_blk.c > index 5c8ba54..97c02fe 100644 > --- i/drivers/block/null_blk.c > +++ w/drivers/block/null_blk.c > @@ -510,17 +510,17 @@ static int null_lnvm_id(struct request_queue *q, > struct nvm_id *id) > id->ppaf.ch_offset = 56; > id->ppaf.ch_len = 8; > > - do_div(size, bs); /* convert size to pages */ > - do_div(size, 256); /* concert size to pgs pr blk */ > + sector_div(size, bs); /* convert size to pages */ > + size >>= 8; /* convert size to pgs pr blk */ > grp = &id->groups[0]; > grp->mtype = 0; > grp->fmtype = 0; > grp->num_ch = 1; > grp->num_pg = 256; > blksize = size; > - do_div(size, (1 << 16)); > + size >>= 16; /* convert size to num luns */ > grp->num_lun = size + 1; > - do_div(blksize, grp->num_lun); > + sector_div(blksize, grp->num_lun); > grp->num_blk = blksize; > grp->num_pln = 1; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Friday 18 December 2015 17:13:40 Arnd Bergmann wrote: > On Saturday 28 November 2015 09:05:56 Matias Bjørling wrote: > > > > I had my head around the original code and kept references to the device > > layout I had in mind. 256 being number of pages in a block, and the 2^16 > > being number of blocks in a lun and wanted to communicate that part.. > > which led to producing silly code in the mean time. > > > > Similarly, the bs is always fixed to 4k for lightnvm, until other bs > > sizes are supported. We could optimize it out, I left it in for the same > > reasons. > > I still see the build warning in linux-next, can you merge your patch? The merge window is open now, the bug persists in linux-next. I'm submitting Matias version now. Arnd
diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index 5c8ba5484d86..d0eeecd294de 100644 --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -510,17 +510,17 @@ static int null_lnvm_id(struct request_queue *q, struct nvm_id *id) id->ppaf.ch_offset = 56; id->ppaf.ch_len = 8; - do_div(size, bs); /* convert size to pages */ - do_div(size, 256); /* concert size to pgs pr blk */ + sector_div(size, bs); /* convert size to pages */ + sector_div(size, 256); /* concert size to pgs pr blk */ grp = &id->groups[0]; grp->mtype = 0; grp->fmtype = 0; grp->num_ch = 1; grp->num_pg = 256; blksize = size; - do_div(size, (1 << 16)); + sector_div(size, (1 << 16)); grp->num_lun = size + 1; - do_div(blksize, grp->num_lun); + sector_div(blksize, grp->num_lun); grp->num_blk = blksize; grp->num_pln = 1;
Dividing a sector_t number should be done using sector_div rather than do_div to optimize the 32-bit sector_t case, and with the latest do_div optimizations, we now get a compile-time warning for this: arch/arm/include/asm/div64.h:32:95: note: expected 'uint64_t * {aka long long unsigned int *}' but argument is of type 'sector_t * {aka long unsigned int *}' drivers/block/null_blk.c:521:81: warning: comparison of distinct pointer types lacks a cast This changes the newly added code to use sector_div. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: b2b7e00148a2 ("null_blk: register as a LightNVM device") --- Found on ARM randconfig builds with today's linux-next -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/