[07/15] mfd: cros_ec: use devm_of_platform_populate()

Message ID	1496072763-31209-8-git-send-email-benjamin.gaignard@linaro.org
State	Accepted
Commit	2eb131efb13d1fb98c08fccfe25908a5a3ad04f6
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>, Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org Subject: [PATCH 07/15] mfd: cros_ec: use devm_of_platform_populate() Date: Mon, 29 May 2017 17:45:55 +0200 Message-Id: <1496072763-31209-8-git-send-email-benjamin.gaignard@linaro.org> In-Reply-To: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk
Series	[01/15] iio: adc: stm32: use devm_of_platform_populate() \| expand [01/15] iio: adc: stm32: use devm_of_platform_populate() [02/15] iio: dac: stm32: use devm_of_platform_populate() [04/15] drm: msm: use devm_of_platform_populate() [05/15] mfd: stm32-timers: use devm_of_platform_populate [06/15] mfd: atmel: use devm_of_platform_populate() [07/15] mfd: cros_ec: use devm_of_platform_populate() [08/15] mfd: exynos: use devm_of_platform_populate() [09/15] mfd: fsl-imx25: use devm_of_platform_populate() [10/15] mfd: motorola-cpcap: use devm_of_platform_populate() [11/15] mfd: palmas: use devm_of_platform_populate() [12/15] mfd: qcom-spmi-pmic: use devm_of_platform_populate() [13/15] mfd: smsc-ece: use devm_of_platform_populate() [14/15] sound: stm32: use devm_of_platform_populate() [15/15] media: exynos4-is: use devm_of_platform_populate()

Message ID

1496072763-31209-8-git-send-email-benjamin.gaignard@linaro.org

State

Accepted

Commit

2eb131efb13d1fb98c08fccfe25908a5a3ad04f6

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-kernel-owner@vger.kernel.org designates 209.132.180.67
	as permitted sender) client-ip=209.132.180.67; 
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 07/15] mfd: cros_ec: use devm_of_platform_populate()
Date: Mon, 29 May 2017 17:45:55 +0200
Message-Id: <1496072763-31209-8-git-send-email-benjamin.gaignard@linaro.org>
In-Reply-To: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org>
References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org>
To: unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Series

[01/15] iio: adc: stm32: use devm_of_platform_populate() | expand

Commit Message

Benjamin Gaignard May 29, 2017, 3:45 p.m. UTC

Use devm_of_platform_populate() to be sure that of_platform_depopulate
is called when removing the driver.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>


CC: Lee Jones <lee.jones@linaro.org>
CC: linux-kernel@vger.kernel.org
---
 drivers/mfd/cros_ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

Comments

Lee Jones May 30, 2017, 9:30 a.m. UTC | #1

On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate

> is called when removing the driver.

> 

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

> 

> CC: Lee Jones <lee.jones@linaro.org>

> CC: linux-kernel@vger.kernel.org

> ---

>  drivers/mfd/cros_ec.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Applied, thanks.

> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c

> index d4a407e..e31ac60 100644

> --- a/drivers/mfd/cros_ec.c

> +++ b/drivers/mfd/cros_ec.c

> @@ -147,7 +147,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)

>  	}

>  

>  	if (IS_ENABLED(CONFIG_OF) && dev->of_node) {

> -		err = of_platform_populate(dev->of_node, NULL, NULL, dev);

> +		err = devm_of_platform_populate(dev);

>  		if (err) {

>  			mfd_remove_devices(dev);

>  			dev_err(dev, "Failed to register sub-devices\n");


-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index d4a407e..e31ac60 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -147,7 +147,7 @@  int cros_ec_register(struct cros_ec_device *ec_dev)
 	}
 
 	if (IS_ENABLED(CONFIG_OF) && dev->of_node) {
-		err = of_platform_populate(dev->of_node, NULL, NULL, dev);
+		err = devm_of_platform_populate(dev);
 		if (err) {
 			mfd_remove_devices(dev);
 			dev_err(dev, "Failed to register sub-devices\n");

[07/15] mfd: cros_ec: use devm_of_platform_populate()

Commit Message

Comments

Patch