diff mbox series

[meta-oe,morty,1/1] openssl-native: Compile with -fPIC

Message ID 20170510093705.12171-1-mirza.krak@endian.se
State Superseded
Headers show
Series [meta-oe,morty,1/1] openssl-native: Compile with -fPIC | expand

Commit Message

Mirza Krak May 10, 2017, 9:37 a.m. UTC
From: Khem Raj <raj.khem@gmail.com>


Fixes
| /usr/bin/ld: libcrypto.a(sha1-x86_64.o): relocation R_X86_64_PC32 against undefined symbol `OPENSSL_ia32cap_P' can not be used when making a shared object; recompile with -fPIC
| /usr/bin/ld: final link failed: Bad value

Signed-off-by: Khem Raj <raj.khem@gmail.com>

(cherry picked from commit 0a19e72081771fca8ed94fb2a2a8996fd3dce00c)
Signed-off-by: Mirza Krak <mirza.krak@endian.se>

---

I hit the same compiler error as in above commit message when running on morty branch. 

I simply cherry-picked that fix in to morty branch. I looked in the git log of oe-core and it seems to me that it shall be ok to do that?

 meta/recipes-connectivity/openssl/openssl_1.0.2j.bb | 1 +
 1 file changed, 1 insertion(+)

-- 
2.12.2

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Mirza Krak May 15, 2017, 7:05 a.m. UTC | #1
2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
> == Series Details ==
>
> Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/6671/
> State : failure

I seem to have messed up here.

Why does the testing framework think that I was targeting master? Was
my subject prefix wrong?
Denys Dmytriyenko May 15, 2017, 10:10 p.m. UTC | #2
On Mon, May 15, 2017 at 09:05:23AM +0200, Mirza Krak wrote:
> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:

> > == Series Details ==

> >

> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

> > Revision: 1

> > URL   : https://patchwork.openembedded.org/series/6671/

> > State : failure

> 

> I seem to have messed up here.

> 

> Why does the testing framework think that I was targeting master? Was

> my subject prefix wrong?


Why is there "meta-oe" in there? This is oe-core, not meta-oe...

-- 
Denys
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Paul Eggleton May 16, 2017, 3:42 a.m. UTC | #3
Hi Mirza,

On Monday, 15 May 2017 7:05:23 PM NZST Mirza Krak wrote:
> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:

> > == Series Details ==

> >

> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC

> > Revision: 1

> > URL   : https://patchwork.openembedded.org/series/6671/

> > State : failure

> 

> I seem to have messed up here.

> 

> Why does the testing framework think that I was targeting master? Was

> my subject prefix wrong?


It probably doesn't understand "," as a separator and thus didn't see "morty" 
as a branch name and assumed master as the default - if that's the case we 
should probably fix that.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Mirza Krak May 16, 2017, 6:27 a.m. UTC | #4
2017-05-16 0:10 GMT+02:00 Denys Dmytriyenko <denis@denix.org>:
> On Mon, May 15, 2017 at 09:05:23AM +0200, Mirza Krak wrote:
>> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
>> > == Series Details ==
>> >
>> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
>> > Revision: 1
>> > URL   : https://patchwork.openembedded.org/series/6671/
>> > State : failure
>>
>> I seem to have messed up here.
>>
>> Why does the testing framework think that I was targeting master? Was
>> my subject prefix wrong?
>
> Why is there "meta-oe" in there? This is oe-core, not meta-oe...

Indeed that was an error on my end, using the wrong subject prefix.
Mirza Krak May 16, 2017, 6:30 a.m. UTC | #5
Hi Paul.

2017-05-16 5:42 GMT+02:00 Paul Eggleton <paul.eggleton@linux.intel.com>:
> Hi Mirza,
>
> On Monday, 15 May 2017 7:05:23 PM NZST Mirza Krak wrote:
>> 2017-05-10 13:31 GMT+02:00 Patchwork <patchwork@patchwork.openembedded.org>:
>> > == Series Details ==
>> >
>> > Series: [meta-oe,morty,1/1] openssl-native: Compile with -fPIC
>> > Revision: 1
>> > URL   : https://patchwork.openembedded.org/series/6671/
>> > State : failure
>>
>> I seem to have messed up here.
>>
>> Why does the testing framework think that I was targeting master? Was
>> my subject prefix wrong?
>
> It probably doesn't understand "," as a separator and thus didn't see "morty"
> as a branch name and assumed master as the default - if that's the case we
> should probably fix that.

I actually did not use "," as seperatator. Do not know where this came
from. My patch is [1].

I guess my error here was adding "meta-oe" as subject prefix in
oe-core mailing list, and I probably triggered some weird behavior in
patchwork with this?

[1]. http://lists.openembedded.org/pipermail/openembedded-core/2017-May/136489.html
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb b/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb
index 9a7cdedd05..b6fb126349 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.0.2j.bb
@@ -5,6 +5,7 @@  require openssl.inc
 DEPENDS += "cryptodev-linux"
 
 CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
+CFLAG_append_class-native = " -fPIC"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=27ffa5d74bb5a337056c14b2ef93fbf6"