diff mbox

soc: imx: add PM dependency for IMX7_PM_DOMAINS

Message ID 20170511113806.2647189-1-arnd@arndb.de
State Accepted
Commit e23c7f7d57831fdae444be9d507e67716ab601d4
Headers show

Commit Message

Arnd Bergmann May 11, 2017, 11:37 a.m. UTC
The new pm domain driver causes a build failure when CONFIG_PM
is not set:

warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'

This adds a dependency to ensure that we don't attempt to build the
driver without CONFIG_PM.

Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/soc/imx/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.9.0

Comments

Fabio Estevam May 11, 2017, 11:39 a.m. UTC | #1
On Thu, May 11, 2017 at 8:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new pm domain driver causes a build failure when CONFIG_PM

> is not set:

>

> warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)

> drivers/base/power/domain_governor.c: In function 'default_suspend_ok':

> drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'

>

> This adds a dependency to ensure that we don't attempt to build the

> driver without CONFIG_PM.

>

> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Shawn Guo May 12, 2017, 3:51 a.m. UTC | #2
On Thu, May 11, 2017 at 01:37:47PM +0200, Arnd Bergmann wrote:
> The new pm domain driver causes a build failure when CONFIG_PM

> is not set:

> 

> warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)

> drivers/base/power/domain_governor.c: In function 'default_suspend_ok':

> drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'

> 

> This adds a dependency to ensure that we don't attempt to build the

> driver without CONFIG_PM.

> 

> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied, thanks.
diff mbox

Patch

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 357a5d8f8da0..a5b86a28f343 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,8 +2,9 @@  menu "i.MX SoC drivers"
 
 config IMX7_PM_DOMAINS
 	bool "i.MX7 PM domains"
-	select PM_GENERIC_DOMAINS
 	depends on SOC_IMX7D || (COMPILE_TEST && OF)
+	depends on PM
+	select PM_GENERIC_DOMAINS
 	default y if SOC_IMX7D
 
 endmenu