diff mbox

[oe] chromium: enable aarch64 support

Message ID 1491591433-19590-1-git-send-email-andrey.konovalov@linaro.org
State Accepted
Headers show

Commit Message

Andrey Konovalov April 7, 2017, 6:57 p.m. UTC 
Tested by running:
- chromium-wayland on HiKey
- chromium on dragonboard-410c

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>

---
 recipes-browser/chromium/chromium.inc                   |  1 +
 recipes-browser/chromium/files/aarch64/include.gypi     |  6 ++++++
 recipes-browser/chromium/files/aarch64/oe-defaults.gypi | 15 +++++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 recipes-browser/chromium/files/aarch64/include.gypi
 create mode 100644 recipes-browser/chromium/files/aarch64/oe-defaults.gypi

-- 
2.1.4

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Herve Jourdain April 10, 2017, 5:15 a.m. UTC | #1 
Hi,

And in more recent / GN based versions of Chromium, no specific patch is
even needed, as aarch64 is "natively" supported by the codebase.
I guess recipes for those will come soon, since it seems several different
persons/groups came with their own flavor of GN build...

Cheers,
Herve

-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org

[mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
Andrey Konovalov
Sent: vendredi 7 avril 2017 20:57
To: openembedded-devel@lists.openembedded.org
Subject: ***SPAM*** [oe] [PATCH] chromium: enable aarch64 support

Tested by running:
- chromium-wayland on HiKey
- chromium on dragonboard-410c

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>

---
 recipes-browser/chromium/chromium.inc                   |  1 +
 recipes-browser/chromium/files/aarch64/include.gypi     |  6 ++++++
 recipes-browser/chromium/files/aarch64/oe-defaults.gypi | 15
+++++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 recipes-browser/chromium/files/aarch64/include.gypi
 create mode 100644 recipes-browser/chromium/files/aarch64/oe-defaults.gypi

--
2.1.4

--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-develdiff --git a/recipes-browser/chromium/chromium.inc
b/recipes-browser/chromium/chromium.inc
index 60edccb..c0c3b94 100644
--- a/recipes-browser/chromium/chromium.inc
+++ b/recipes-browser/chromium/chromium.inc
@@ -7,6 +7,7 @@ COMPATIBLE_MACHINE_x86-64 = "(.*)"
 COMPATIBLE_MACHINE_armv6 = "(.*)"
 COMPATIBLE_MACHINE_armv7a = "(.*)"
 COMPATIBLE_MACHINE_armv7ve = "(.*)"
+COMPATIBLE_MACHINE_aarch64 = "(.*)"
 
 # The build type defaults to Release. If you want a Debug build, you can
set  # the variable CHROMIUM_BUILD_TYPE to "Debug" in your conf/local.conf
file.
diff --git a/recipes-browser/chromium/files/aarch64/include.gypi
b/recipes-browser/chromium/files/aarch64/include.gypi
new file mode 100644
index 0000000..ad0347a
--- /dev/null
+++ b/recipes-browser/chromium/files/aarch64/include.gypi
@@ -0,0 +1,6 @@
+{
+  'variables': {
+    # Configure for aarch64 compilation
+    'target_arch': 'arm64',
+  },
+}
diff --git a/recipes-browser/chromium/files/aarch64/oe-defaults.gypi
b/recipes-browser/chromium/files/aarch64/oe-defaults.gypi
new file mode 100644
index 0000000..27e1cfe
--- /dev/null
+++ b/recipes-browser/chromium/files/aarch64/oe-defaults.gypi
@@ -0,0 +1,15 @@
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 1,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 0,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0
+  },
+}
Khem Raj April 10, 2017, 7:47 p.m. UTC | #2 
whoever comes up with patch, we will start the discussions and try to
get it in

On 4/9/17 10:15 PM, Herve Jourdain wrote:
> Hi,

> 

> And in more recent / GN based versions of Chromium, no specific patch is

> even needed, as aarch64 is "natively" supported by the codebase.

> I guess recipes for those will come soon, since it seems several different

> persons/groups came with their own flavor of GN build...

> 

> Cheers,

> Herve

> 

> -----Original Message-----

> From: openembedded-devel-bounces@lists.openembedded.org

> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of

> Andrey Konovalov

> Sent: vendredi 7 avril 2017 20:57

> To: openembedded-devel@lists.openembedded.org

> Subject: ***SPAM*** [oe] [PATCH] chromium: enable aarch64 support

> 

> Tested by running:

> - chromium-wayland on HiKey

> - chromium on dragonboard-410c

> 

> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>

> ---

>  recipes-browser/chromium/chromium.inc                   |  1 +

>  recipes-browser/chromium/files/aarch64/include.gypi     |  6 ++++++

>  recipes-browser/chromium/files/aarch64/oe-defaults.gypi | 15

> +++++++++++++++

>  3 files changed, 22 insertions(+)

>  create mode 100644 recipes-browser/chromium/files/aarch64/include.gypi

>  create mode 100644 recipes-browser/chromium/files/aarch64/oe-defaults.gypi

> 

> diff --git a/recipes-browser/chromium/chromium.inc

> b/recipes-browser/chromium/chromium.inc

> index 60edccb..c0c3b94 100644

> --- a/recipes-browser/chromium/chromium.inc

> +++ b/recipes-browser/chromium/chromium.inc

> @@ -7,6 +7,7 @@ COMPATIBLE_MACHINE_x86-64 = "(.*)"

>  COMPATIBLE_MACHINE_armv6 = "(.*)"

>  COMPATIBLE_MACHINE_armv7a = "(.*)"

>  COMPATIBLE_MACHINE_armv7ve = "(.*)"

> +COMPATIBLE_MACHINE_aarch64 = "(.*)"

>  

>  # The build type defaults to Release. If you want a Debug build, you can

> set  # the variable CHROMIUM_BUILD_TYPE to "Debug" in your conf/local.conf

> file.

> diff --git a/recipes-browser/chromium/files/aarch64/include.gypi

> b/recipes-browser/chromium/files/aarch64/include.gypi

> new file mode 100644

> index 0000000..ad0347a

> --- /dev/null

> +++ b/recipes-browser/chromium/files/aarch64/include.gypi

> @@ -0,0 +1,6 @@

> +{

> +  'variables': {

> +    # Configure for aarch64 compilation

> +    'target_arch': 'arm64',

> +  },

> +}

> diff --git a/recipes-browser/chromium/files/aarch64/oe-defaults.gypi

> b/recipes-browser/chromium/files/aarch64/oe-defaults.gypi

> new file mode 100644

> index 0000000..27e1cfe

> --- /dev/null

> +++ b/recipes-browser/chromium/files/aarch64/oe-defaults.gypi

> @@ -0,0 +1,15 @@

> +{

> +  'variables': {

> +    'use_system_bzip2': 1,

> +    'disable_nacl': 1,

> +    'proprietary_codecs': 1,

> +    'v8_use_snapshot': 1,

> +    'use_system_ffmpeg': 0,

> +    'linux_use_tcmalloc': 0,

> +    'linux_link_kerberos': 0,

> +    'use_kerberos': 0,

> +    'use_cups': 0,

> +    'use_gnome_keyring': 0,

> +    'linux_link_gnome_keyring': 0

> +  },

> +}

> --

> 2.1.4

> 

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff mbox

Patch

diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
index 60edccb..c0c3b94 100644
--- a/recipes-browser/chromium/chromium.inc
+++ b/recipes-browser/chromium/chromium.inc
@@ -7,6 +7,7 @@  COMPATIBLE_MACHINE_x86-64 = "(.*)"
 COMPATIBLE_MACHINE_armv6 = "(.*)"
 COMPATIBLE_MACHINE_armv7a = "(.*)"
 COMPATIBLE_MACHINE_armv7ve = "(.*)"
+COMPATIBLE_MACHINE_aarch64 = "(.*)"
 
 # The build type defaults to Release. If you want a Debug build, you can set
 # the variable CHROMIUM_BUILD_TYPE to "Debug" in your conf/local.conf file.
diff --git a/recipes-browser/chromium/files/aarch64/include.gypi b/recipes-browser/chromium/files/aarch64/include.gypi
new file mode 100644
index 0000000..ad0347a
--- /dev/null
+++ b/recipes-browser/chromium/files/aarch64/include.gypi
@@ -0,0 +1,6 @@ 
+{
+  'variables': {
+    # Configure for aarch64 compilation
+    'target_arch': 'arm64',
+  }, 
+}
diff --git a/recipes-browser/chromium/files/aarch64/oe-defaults.gypi b/recipes-browser/chromium/files/aarch64/oe-defaults.gypi
new file mode 100644
index 0000000..27e1cfe
--- /dev/null
+++ b/recipes-browser/chromium/files/aarch64/oe-defaults.gypi
@@ -0,0 +1,15 @@ 
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 1,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 0,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0
+  }, 
+}