diff mbox series

[1/3] clocksource: Augment bindings for Faraday timer

Message ID 20170324213235.16119-1-linus.walleij@linaro.org
State Superseded
Headers show
Series [1/3] clocksource: Augment bindings for Faraday timer | expand

Commit Message

Linus Walleij March 24, 2017, 9:32 p.m. UTC
It turns out that the Cortina Gemini timer block is just a
standard IP block from Faraday Technology named FTTMR010.

In order to make things clear and understandable, we rename the
bindings with a Faraday compatible as primary and the Cortina
gemini as a more specific case.

For the plain Faraday timer we require two clock references,
while the Gemini can keep it's syscon lookup pattern.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 .../bindings/timer/cortina,gemini-timer.txt        | 22 ---------------
 .../devicetree/bindings/timer/faraday,fttmr010.txt | 33 ++++++++++++++++++++++
 2 files changed, 33 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt
 create mode 100644 Documentation/devicetree/bindings/timer/faraday,fttmr010.txt

-- 
2.9.3

Comments

Daniel Lezcano April 7, 2017, 1:41 p.m. UTC | #1
On Fri, Mar 24, 2017 at 10:32:33PM +0100, Linus Walleij wrote:
> It turns out that the Cortina Gemini timer block is just a

> standard IP block from Faraday Technology named FTTMR010.

> 

> In order to make things clear and understandable, we rename the

> bindings with a Faraday compatible as primary and the Cortina

> gemini as a more specific case.

> 

> For the plain Faraday timer we require two clock references,

> while the Gemini can keep it's syscon lookup pattern.

> 

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---


Rob ? Is this change ok for you?

Thanks.

  -- Daniel

>  .../bindings/timer/cortina,gemini-timer.txt        | 22 ---------------

>  .../devicetree/bindings/timer/faraday,fttmr010.txt | 33 ++++++++++++++++++++++

>  2 files changed, 33 insertions(+), 22 deletions(-)

>  delete mode 100644 Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt

>  create mode 100644 Documentation/devicetree/bindings/timer/faraday,fttmr010.txt

> 

> diff --git a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt b/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt

> deleted file mode 100644

> index 16ea1d3b2e9e..000000000000

> --- a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt

> +++ /dev/null

> @@ -1,22 +0,0 @@

> -Cortina Systems Gemini timer

> -

> -This timer is embedded in the Cortina Systems Gemini SoCs.

> -

> -Required properties:

> -

> -- compatible : Must be "cortina,gemini-timer"

> -- reg : Should contain registers location and length

> -- interrupts : Should contain the three timer interrupts with

> -  flags for rising edge

> -- syscon : a phandle to the global Gemini system controller

> -

> -Example:

> -

> -timer@43000000 {

> -	compatible = "cortina,gemini-timer";

> -	reg = <0x43000000 0x1000>;

> -	interrupts = <14 IRQ_TYPE_EDGE_RISING>, /* Timer 1 */

> -		   <15 IRQ_TYPE_EDGE_RISING>, /* Timer 2 */

> -		   <16 IRQ_TYPE_EDGE_RISING>; /* Timer 3 */

> -	syscon = <&syscon>;

> -};

> diff --git a/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt

> new file mode 100644

> index 000000000000..b73ca6cd07f8

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt

> @@ -0,0 +1,33 @@

> +Faraday Technology timer

> +

> +This timer is a generic IP block from Faraday Technology, embedded in the

> +Cortina Systems Gemini SoCs and other designs.

> +

> +Required properties:

> +

> +- compatible : Must be one of

> +  "faraday,fttmr010"

> +  "cortina,gemini-timer"

> +- reg : Should contain registers location and length

> +- interrupts : Should contain the three timer interrupts usually with

> +  flags for falling edge

> +

> +Optionally required properties:

> +

> +- clocks : a clock to provide the tick rate for "faraday,fttmr010"

> +- clock-names : should be "EXTCLK" and "PCLK" for the external tick timer

> +  and peripheral clock respectively, for "faraday,fttmr010"

> +- syscon : a phandle to the global Gemini system controller if the compatible

> +  type is "cortina,gemini-timer"

> +

> +Example:

> +

> +timer@43000000 {

> +	compatible = "faraday,fttmr010";

> +	reg = <0x43000000 0x1000>;

> +	interrupts = <14 IRQ_TYPE_EDGE_FALLING>, /* Timer 1 */

> +		   <15 IRQ_TYPE_EDGE_FALLING>, /* Timer 2 */

> +		   <16 IRQ_TYPE_EDGE_FALLING>; /* Timer 3 */

> +	clocks = <&extclk>, <&pclk>;

> +	clock-names = "EXTCLK", "PCLK";

> +};

> -- 

> 2.9.3

> 


-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Rob Herring (Arm) April 7, 2017, 2:27 p.m. UTC | #2
On Fri, Apr 7, 2017 at 8:41 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On Fri, Mar 24, 2017 at 10:32:33PM +0100, Linus Walleij wrote:

>> It turns out that the Cortina Gemini timer block is just a

>> standard IP block from Faraday Technology named FTTMR010.

>>

>> In order to make things clear and understandable, we rename the

>> bindings with a Faraday compatible as primary and the Cortina

>> gemini as a more specific case.

>>

>> For the plain Faraday timer we require two clock references,

>> while the Gemini can keep it's syscon lookup pattern.

>>

>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>> ---

>

> Rob ? Is this change ok for you?


Send to the DT list please. And use the -M option.

Rob
Linus Walleij April 7, 2017, 9:52 p.m. UTC | #3
On Fri, Apr 7, 2017 at 4:27 PM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Apr 7, 2017 at 8:41 AM, Daniel Lezcano

> <daniel.lezcano@linaro.org> wrote:

>> On Fri, Mar 24, 2017 at 10:32:33PM +0100, Linus Walleij wrote:

>>> It turns out that the Cortina Gemini timer block is just a

>>> standard IP block from Faraday Technology named FTTMR010.

>>>

>>> In order to make things clear and understandable, we rename the

>>> bindings with a Faraday compatible as primary and the Cortina

>>> gemini as a more specific case.

>>>

>>> For the plain Faraday timer we require two clock references,

>>> while the Gemini can keep it's syscon lookup pattern.

>>>

>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>>> ---

>>

>> Rob ? Is this change ok for you?

>

> Send to the DT list please. And use the -M option.


Sorry missed it :(

Resending this patch.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt b/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt
deleted file mode 100644
index 16ea1d3b2e9e..000000000000
--- a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt
+++ /dev/null
@@ -1,22 +0,0 @@ 
-Cortina Systems Gemini timer
-
-This timer is embedded in the Cortina Systems Gemini SoCs.
-
-Required properties:
-
-- compatible : Must be "cortina,gemini-timer"
-- reg : Should contain registers location and length
-- interrupts : Should contain the three timer interrupts with
-  flags for rising edge
-- syscon : a phandle to the global Gemini system controller
-
-Example:
-
-timer@43000000 {
-	compatible = "cortina,gemini-timer";
-	reg = <0x43000000 0x1000>;
-	interrupts = <14 IRQ_TYPE_EDGE_RISING>, /* Timer 1 */
-		   <15 IRQ_TYPE_EDGE_RISING>, /* Timer 2 */
-		   <16 IRQ_TYPE_EDGE_RISING>; /* Timer 3 */
-	syscon = <&syscon>;
-};
diff --git a/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt
new file mode 100644
index 000000000000..b73ca6cd07f8
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt
@@ -0,0 +1,33 @@ 
+Faraday Technology timer
+
+This timer is a generic IP block from Faraday Technology, embedded in the
+Cortina Systems Gemini SoCs and other designs.
+
+Required properties:
+
+- compatible : Must be one of
+  "faraday,fttmr010"
+  "cortina,gemini-timer"
+- reg : Should contain registers location and length
+- interrupts : Should contain the three timer interrupts usually with
+  flags for falling edge
+
+Optionally required properties:
+
+- clocks : a clock to provide the tick rate for "faraday,fttmr010"
+- clock-names : should be "EXTCLK" and "PCLK" for the external tick timer
+  and peripheral clock respectively, for "faraday,fttmr010"
+- syscon : a phandle to the global Gemini system controller if the compatible
+  type is "cortina,gemini-timer"
+
+Example:
+
+timer@43000000 {
+	compatible = "faraday,fttmr010";
+	reg = <0x43000000 0x1000>;
+	interrupts = <14 IRQ_TYPE_EDGE_FALLING>, /* Timer 1 */
+		   <15 IRQ_TYPE_EDGE_FALLING>, /* Timer 2 */
+		   <16 IRQ_TYPE_EDGE_FALLING>; /* Timer 3 */
+	clocks = <&extclk>, <&pclk>;
+	clock-names = "EXTCLK", "PCLK";
+};