mbox series

[edk2,v3,0/6] Juno cleanup -- EDK2 edition

Message ID 20170404123010.11722-1-ard.biesheuvel@linaro.org
Headers show
Series Juno cleanup -- EDK2 edition | expand

Message

Ard Biesheuvel April 4, 2017, 12:30 p.m. UTC 
This is tagged as v3 because these patches have been isolated from a
ArmPlatformPkg cleanup series that is mostly about ACPI vs DT.

This series is specific to Juno; it replaces the cargo culted and ancient
PCI 'emulation' code with calls into the new non-discoverable device API,
and removes the Juno specific PCI host bridge driver in favor of the generic
one.

Ard Biesheuvel (6):
  ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency
  ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency
  ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device
    support
  ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0
  ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver
  ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c                            | 110 ++-
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf                          |   4 +-
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h                    |   5 -
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c                          | 596 ----------------
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h                          | 284 --------
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c                       | 299 --------
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c                   | 199 ------
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h                   | 324 ---------
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf              |  76 --
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c | 642 -----------------
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c                   | 748 --------------------
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c                     | 170 -----
 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h                     | 111 ---
 ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf                       |   1 -
 ArmPlatformPkg/Library/ArmShellCmdRunAxf/RunAxf.c                                    |  58 +-
 15 files changed, 104 insertions(+), 3523 deletions(-)
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c
 delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h

-- 
2.9.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ryan Harkin April 4, 2017, 3:47 p.m. UTC | #1 
On 4 April 2017 at 13:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> This is tagged as v3 because these patches have been isolated from a

> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT.

>

> This series is specific to Juno; it replaces the cargo culted and ancient

> PCI 'emulation' code with calls into the new non-discoverable device API,

> and removes the Juno specific PCI host bridge driver in favor of the generic

> one.

>

> Ard Biesheuvel (6):

>   ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

>   ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

>   ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device

>     support

>   ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

>   ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

>   ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

>

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c                            | 110 ++-

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf                          |   4 +-

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h                    |   5 -

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c                          | 596 ----------------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h                          | 284 --------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c                       | 299 --------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c                   | 199 ------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h                   | 324 ---------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf              |  76 --

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c | 642 -----------------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c                   | 748 --------------------

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c                     | 170 -----

>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h                     | 111 ---

>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf                       |   1 -

>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/RunAxf.c                                    |  58 +-

>  15 files changed, 104 insertions(+), 3523 deletions(-)

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c

>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h

>

> --

> 2.9.3

>


I tested the whole series in conjunction with the OpenPlatformPkg
series and it works fine on Juno R0/1/2, TC2 and FVP Foundation and
AEMv8 models.

I tested PCIe ethernet and SATA HDD on R1 and R2, and a USB memory
stick on R0/1/2.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ryan Harkin April 4, 2017, 3:48 p.m. UTC | #2 
On 4 April 2017 at 16:47, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> On 4 April 2017 at 13:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

>> This is tagged as v3 because these patches have been isolated from a

>> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT.

>>

>> This series is specific to Juno; it replaces the cargo culted and ancient

>> PCI 'emulation' code with calls into the new non-discoverable device API,

>> and removes the Juno specific PCI host bridge driver in favor of the generic

>> one.

>>

>> Ard Biesheuvel (6):

>>   ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

>>   ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

>>   ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device

>>     support

>>   ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

>>   ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

>>   ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

>>

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c                            | 110 ++-

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf                          |   4 +-

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h                    |   5 -

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c                          | 596 ----------------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h                          | 284 --------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c                       | 299 --------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c                   | 199 ------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h                   | 324 ---------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf              |  76 --

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c | 642 -----------------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c                   | 748 --------------------

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c                     | 170 -----

>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h                     | 111 ---

>>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf                       |   1 -

>>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/RunAxf.c                                    |  58 +-

>>  15 files changed, 104 insertions(+), 3523 deletions(-)

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c

>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h

>>

>> --

>> 2.9.3

>>

>

> I tested the whole series in conjunction with the OpenPlatformPkg

> series and it works fine on Juno R0/1/2, TC2 and FVP Foundation and

> AEMv8 models.

>

> I tested PCIe ethernet and SATA HDD on R1 and R2, and a USB memory

> stick on R0/1/2.


Missed the actual Tested-by tag...

Tested-by: Ryan Harkin <ryan.harkin@linaro.org>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel April 4, 2017, 3:49 p.m. UTC | #3 
On 4 April 2017 at 16:48, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> On 4 April 2017 at 16:47, Ryan Harkin <ryan.harkin@linaro.org> wrote:

>> On 4 April 2017 at 13:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

>>> This is tagged as v3 because these patches have been isolated from a

>>> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT.

>>>

>>> This series is specific to Juno; it replaces the cargo culted and ancient

>>> PCI 'emulation' code with calls into the new non-discoverable device API,

>>> and removes the Juno specific PCI host bridge driver in favor of the generic

>>> one.

>>>

>>> Ard Biesheuvel (6):

>>>   ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency

>>>   ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency

>>>   ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device

>>>     support

>>>   ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0

>>>   ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver

>>>   ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation

>>>

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c                            | 110 ++-

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf                          |   4 +-

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h                    |   5 -

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c                          | 596 ----------------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h                          | 284 --------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c                       | 299 --------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c                   | 199 ------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h                   | 324 ---------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf              |  76 --

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c | 642 -----------------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c                   | 748 --------------------

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c                     | 170 -----

>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h                     | 111 ---

>>>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf                       |   1 -

>>>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/RunAxf.c                                    |  58 +-

>>>  15 files changed, 104 insertions(+), 3523 deletions(-)

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c

>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h

>>>

>>> --

>>> 2.9.3

>>>

>>

>> I tested the whole series in conjunction with the OpenPlatformPkg

>> series and it works fine on Juno R0/1/2, TC2 and FVP Foundation and

>> AEMv8 models.

>>

>> I tested PCIe ethernet and SATA HDD on R1 and R2, and a USB memory

>> stick on R0/1/2.

>

> Missed the actual Tested-by tag...

>

> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>


Thank you! Much appreciated, especially since it took a bit more time
than I had anticipated.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel