Message ID | 20170404132409.20422-1-ard.biesheuvel@linaro.org |
---|---|
Headers | show |
Series | ArmVirtPkg: ignore DT nodes with a status != 'okay' | expand |
On 04/04/17 15:24, Ard Biesheuvel wrote: > The DT passed to us by QEMU may contain nodes that are supposed to be > consumed by the secure world only. In some case, their status may be > set to 'secure', but 'disabled' occurs as well, if the secure OS has > actually modified the DT. > > Since as a general rule, DT nodes should only be consumed if they lack a > status or if their status equals 'okay', update our DT node parsing > routines accordingly. > > Ard Biesheuvel (3): > ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into > account > ArmVirtPkg/FdtPL011SerialPortLib: take DT node 'status' property into > account > ArmVirtPkg/PlatformPeiLib: take DT node 'status' property into account > > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 8 ++++++++ > ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c | 6 ++++++ > ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c | 7 +++++++ > 3 files changed, 21 insertions(+) > Please re-wrap commit messages #2 and #3 to a width of 74 characters. The subject lines are also too long (on patches #1 and #2); please come up with alternatives that fit into 74 characters. For example, replace take DT xxx node 'status' property into account with honor DT xxx node 'status' property With that, series Reviewed-by: Laszlo Ersek <lersek@redhat.com> Thanks, Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 4 April 2017 at 15:16, Laszlo Ersek <lersek@redhat.com> wrote: > On 04/04/17 15:24, Ard Biesheuvel wrote: >> The DT passed to us by QEMU may contain nodes that are supposed to be >> consumed by the secure world only. In some case, their status may be >> set to 'secure', but 'disabled' occurs as well, if the secure OS has >> actually modified the DT. >> >> Since as a general rule, DT nodes should only be consumed if they lack a >> status or if their status equals 'okay', update our DT node parsing >> routines accordingly. >> >> Ard Biesheuvel (3): >> ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into >> account >> ArmVirtPkg/FdtPL011SerialPortLib: take DT node 'status' property into >> account >> ArmVirtPkg/PlatformPeiLib: take DT node 'status' property into account >> >> ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 8 ++++++++ >> ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c | 6 ++++++ >> ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c | 7 +++++++ >> 3 files changed, 21 insertions(+) >> > > Please re-wrap commit messages #2 and #3 to a width of 74 characters. > > The subject lines are also too long (on patches #1 and #2); please come > up with alternatives that fit into 74 characters. For example, replace > > take DT xxx node 'status' property into account > > with > > honor DT xxx node 'status' property > > With that, series > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > Thanks Pushed as d014044395b5 ArmVirtPkg/FdtClientDxe: honor memory DT node 'status' property b1f3e48ed8f9 ArmVirtPkg/FdtPL011SerialPortLib: honor DT node 'status' property 83ae7589b08a ArmVirtPkg/PlatformPeiLib: honor DT node 'status' property _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel