| Message ID | 1389787053-18228-1-git-send-email-tushar.behera@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Tushar, On 15 January 2014 17:27, Tushar Behera <tushar.behera@linaro.org> wrote: > There is no need to include "plat/map-base.h" in ipp driver. Remove > this and enable this driver for multi-platform. > > Signed-off-by: Tushar Behera <tushar.behera@linaro.org> drivers/gpu/drm/exynos/exynos_drm_gsc.c also has this header file included. If this file is needed there, then you may have to add !ARCH_MULTIPLATFORM as its dependency.
On 16 January 2014 10:33, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Hi Tushar, > > On 15 January 2014 17:27, Tushar Behera <tushar.behera@linaro.org> wrote: >> There is no need to include "plat/map-base.h" in ipp driver. Remove >> this and enable this driver for multi-platform. >> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org> > > drivers/gpu/drm/exynos/exynos_drm_gsc.c also has this header file included. > If this file is needed there, then you may have to add !ARCH_MULTIPLATFORM > as its dependency. > Yes, true. There are still some users for this header file within exynos_drm_gsc.c, so we need to make the compilation conditional. I will add that and resend the patch. > -- > With warm regards, > Sachin Thanks.
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index f227f54..3af44c2 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -51,7 +51,7 @@ config DRM_EXYNOS_G2D config DRM_EXYNOS_IPP bool "Exynos DRM IPP" - depends on DRM_EXYNOS && !ARCH_MULTIPLATFORM + depends on DRM_EXYNOS help Choose this option if you want to use IPP feature for DRM. diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index d519a4e..eefb429 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c @@ -16,7 +16,6 @@ #include <linux/types.h> #include <linux/clk.h> #include <linux/pm_runtime.h> -#include <plat/map-base.h> #include <drm/drmP.h> #include <drm/exynos_drm.h>
There is no need to include "plat/map-base.h" in ipp driver. Remove this and enable this driver for multi-platform. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- drivers/gpu/drm/exynos/Kconfig | 2 +- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)