mbox series

[v3,0/3] dmaengine: cppi41: Add dma support to da8xx

Message ID 20170119111334.14718-1-abailon@baylibre.com
Headers show
Series dmaengine: cppi41: Add dma support to da8xx | expand

Message

Alexandre Bailon Jan. 19, 2017, 11:13 a.m. UTC 
This series add support of DA8xx to CPPI 4.1 driver.
As the CPPI 4.1 is now generic, we only had to add the glue for DA8xx.

This serie should applied on top of 
"[PATCH v3 0/4] dmaengine: cppi41: Make CPPI 4.1 driver more generic".

Changes in v3:
- Removed some useless property from DT bindings.
- Update kconfig in patch 2. Was prevously made in another patchset.

Changes in v2:
- most of patches of v1 has been moved to the series
  "[PATCH v2 0/7] dmaengine: cppi41: Make CPPI 4.1 driver more generic".
- some patches of v1 has been removed because they were no required
  anymore because CPPI 4.1 driver has been made more generic.
- In v1, the driver were managing the clock for DA8xx paltform.
  This is not needed as CPPI 4.1 will be a child of MUSB DA8xx glue,
  we can use PM runtime and let the DA8xx glue driver manage it.

Alexandre Bailon (3):
  dt/bindings: da8xx-usb: Add binding for the CPPI 4.1 DMA controller
  dmaengine: cppi41: Add support of DA8xx to CPPI 4.1
  dmaengine: cppi41: Fix teardown warnings

 .../devicetree/bindings/usb/da8xx-usb.txt          | 39 ++++++++++++++++++++++
 drivers/dma/Kconfig                                |  6 ++--
 drivers/dma/cppi41.c                               | 28 ++++++++++++++--
 3 files changed, 68 insertions(+), 5 deletions(-)

-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sergei Shtylyov Jan. 19, 2017, 6:15 p.m. UTC | #1 
On 01/19/2017 02:13 PM, Alexandre Bailon wrote:

> The DA8xx has a CPPI 4.1 DMA controller.

> This is add the glue layer required to make it work on DA8xx.

>

> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

> ---

>  drivers/dma/Kconfig  |  6 +++---

>  drivers/dma/cppi41.c | 24 ++++++++++++++++++++++++

>  2 files changed, 27 insertions(+), 3 deletions(-)

>

> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig

> index 0d6a96e..03ae2a1 100644

> --- a/drivers/dma/Kconfig

> +++ b/drivers/dma/Kconfig

> @@ -514,12 +514,12 @@ config TIMB_DMA

>  	  Enable support for the Timberdale FPGA DMA engine.

>

>  config TI_CPPI41

> -	tristate "AM33xx CPPI41 DMA support"

> -	depends on ARCH_OMAP

> +	tristate "CPPI41 DMA support"


    Grr... CPPI 4.1, please.

> +	depends on (ARCH_OMAP || ARCH_DAVINCI_DA8XX)

>  	select DMA_ENGINE

>  	help

>  	  The Communications Port Programming Interface (CPPI) 4.1 DMA engine

> -	  is currently used by the USB driver on AM335x platforms.

> +	  is currently used by the USB driver on AM335x and DA8xx platforms.

>

>  config TI_DMA_CROSSBAR

>  	bool

> diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c

> index 9767b97..f6f2d84 100644

> --- a/drivers/dma/cppi41.c

> +++ b/drivers/dma/cppi41.c

[...]
> @@ -951,8 +965,18 @@ static const struct cppi_glue_infos am335x_usb_infos = {

>  	.qmgr_num_pend = 5,

>  };

>

> +static const struct cppi_glue_infos da8xx_usb_infos = {

> +	.isr = cppi41_irq,


    Isn't the ISR the same for all glues now?

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre Bailon Jan. 23, 2017, 2:28 p.m. UTC | #2 
On 01/19/2017 07:15 PM, Sergei Shtylyov wrote:
> On 01/19/2017 02:13 PM, Alexandre Bailon wrote:

>

> > The DA8xx has a CPPI 4.1 DMA controller.

> > This is add the glue layer required to make it work on DA8xx.

> >

> > Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

> > ---

> >  drivers/dma/Kconfig  |  6 +++---

> >  drivers/dma/cppi41.c | 24 ++++++++++++++++++++++++

> >  2 files changed, 27 insertions(+), 3 deletions(-)

> >

> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig

> > index 0d6a96e..03ae2a1 100644

> > --- a/drivers/dma/Kconfig

> > +++ b/drivers/dma/Kconfig

> > @@ -514,12 +514,12 @@ config TIMB_DMA

> >        Enable support for the Timberdale FPGA DMA engine.

> >

> >  config TI_CPPI41

> > -    tristate "AM33xx CPPI41 DMA support"

> > -    depends on ARCH_OMAP

> > +    tristate "CPPI41 DMA support"

>

>    Grr... CPPI 4.1, please.

>

> > +    depends on (ARCH_OMAP || ARCH_DAVINCI_DA8XX)

> >      select DMA_ENGINE

> >      help

> >        The Communications Port Programming Interface (CPPI) 4.1 DMA

> > engine

> > -      is currently used by the USB driver on AM335x platforms.

> > +      is currently used by the USB driver on AM335x and DA8xx platforms.

> >

> >  config TI_DMA_CROSSBAR

> >      bool

> > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c

> > index 9767b97..f6f2d84 100644

> > --- a/drivers/dma/cppi41.c

> > +++ b/drivers/dma/cppi41.c

> [...]

> > @@ -951,8 +965,18 @@ static const struct cppi_glue_infos

> > am335x_usb_infos = {

> >      .qmgr_num_pend = 5,

> >  };

> >

> > +static const struct cppi_glue_infos da8xx_usb_infos = {

> > +    .isr = cppi41_irq,

>

>    Isn't the ISR the same for all glues now?

True. I should remove isr callback.
>

> [...]

>

> MBR, Sergei

>


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html