| Message ID | 1479544691-59575-23-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Nov 19, 2016 at 04:37:37PM +0800, Heyi Guo wrote: > The dependency should be added to FdtUpdateLib, but it could not be > added to UpdateFdtDxe when FdtUpdateLib becomes binary. > > So this is a WA and can be removed after FdtUpdateLib open source. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chenhui Sun <sunchenhui@huawei.com> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > index a0f0a9d..ccdcae7 100644 > --- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > +++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > @@ -29,6 +29,7 @@ > [Packages] > ArmPlatformPkg/ArmPlatformPkg.dec > MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > ArmPkg/ArmPkg.dec > OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > @@ -58,5 +59,4 @@ > > > [Depex] > -TRUE > - > + gEfiGenericMemTestProtocolGuid Ah, so this is the reason you want to include the NULL memory test? That does not seem like the most straightforward way to me. Just delete the references from FdtUpdateLib, instead, and delete references to the library from .dsc/.fdf and IntelBds will not try to access it. It is a little bit worrying that the memory test is called only from within the module that will not even be included in released firmware. And not the right way to go for a system that _would_ want to support both DT and ACPI. Regards, Leif
diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf index a0f0a9d..ccdcae7 100644 --- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf +++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf @@ -29,6 +29,7 @@ [Packages] ArmPlatformPkg/ArmPlatformPkg.dec MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec ArmPkg/ArmPkg.dec OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec EmbeddedPkg/EmbeddedPkg.dec @@ -58,5 +59,4 @@ [Depex] -TRUE - + gEfiGenericMemTestProtocolGuid