| Message ID | 1479544691-59575-19-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Nov 19, 2016 at 04:37:33PM +0800, Heyi Guo wrote: > D03 OemNicConfig driver is using CpldIoLib, so CpldIoLib needs > to be added to the INF file to avoid potential build error. > > The reason why it didn't cause D03 build failure is that CpldIoLib is > invoked by this module implicitly via below chain: > I2CLib->PlatformSysCtrlLib of Hi1610->OemAddressMapLib of D03->CpldIoLib > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf > index 4327406..8e1fd9d 100644 > --- a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf > +++ b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf > @@ -34,6 +34,7 @@ > gHisiBoardXgeStatusProtocolGuid > > [LibraryClasses] > + CpldIoLib > UefiDriverEntryPoint > UefiBootServicesTableLib > DebugLib > -- > 1.9.1 >
diff --git a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf index 4327406..8e1fd9d 100644 --- a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf +++ b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf @@ -34,6 +34,7 @@ gHisiBoardXgeStatusProtocolGuid [LibraryClasses] + CpldIoLib UefiDriverEntryPoint UefiBootServicesTableLib DebugLib
D03 OemNicConfig driver is using CpldIoLib, so CpldIoLib needs to be added to the INF file to avoid potential build error. The reason why it didn't cause D03 build failure is that CpldIoLib is invoked by this module implicitly via below chain: I2CLib->PlatformSysCtrlLib of Hi1610->OemAddressMapLib of D03->CpldIoLib Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi.guo@linaro.org> --- Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf | 1 + 1 file changed, 1 insertion(+)