| Message ID | VI1PR0801MB20313580A29473C52721B5BEFFA70@VI1PR0801MB2031.eurprd08.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
Ping.
________________________________________
From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org> on behalf of Tamar Christina <Tamar.Christina@arm.com>
Sent: Monday, November 7, 2016 2:05:27 PM
To: GCC Patches; James Greenhalgh; Richard Earnshaw; Marcus Shawcroft
Cc: nd
Subject: [GCC][AArch64][PATCH][Testsuite] Fix failing test vector_initialization_nostack.c
Hi all,
This fixes (PR78142) by turning off scheduling for the test.
r241590 is causing more registers to be used and so
the SP registered happens to be picked and used.
This test I believe was checking explicitly that the
SP is not used if not needed.
Ran regression tests on aarch64-none-linux-gnu.
Ok for trunk?
Thanks,
Tamar
gcc/testsuite/
2016-11-07 Tamar Christina <tamar.christina@arm.com>
PR middle-end/78142
* gcc.target/aarch64/vector_initialization_nostack.c
(dg-options): Disabled scheduling.
On Mon, Nov 07, 2016 at 02:05:27PM +0000, Tamar Christina wrote: > Hi all, > > This fixes (PR78142) by turning off scheduling for the test. > r241590 is causing more registers to be used and so > the SP registered happens to be picked and used. > > This test I believe was checking explicitly that the > SP is not used if not needed. I can't say I'm convinced by the fix - turning off passes to work around a failure suggests a problem with the test, and turning off the pass reduces coverage of what we're actually trying to test for. Can the test be rewritten to only require construction of one vector in the char case? Thanks, James > gcc/testsuite/ > > 2016-11-07 Tamar Christina <tamar.christina@arm.com> > > PR middle-end/78142 > * gcc.target/aarch64/vector_initialization_nostack.c > (dg-options): Disabled scheduling. > diff --git a/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c b/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c > index bbad04d00263b6a91b826b4911af92bdd226c821..71699281c5ce79fb5cf37e47b8ba078721c19f3a 100644 > --- a/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c > +++ b/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O3 -ftree-vectorize -fno-vect-cost-model" } */ > +/* { dg-options "-O3 -ftree-vectorize -fno-vect-cost-model -fno-schedule-insns" } */ > float arr_f[100][100]; > float > f9 (void)
diff --git a/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c b/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c index bbad04d00263b6a91b826b4911af92bdd226c821..71699281c5ce79fb5cf37e47b8ba078721c19f3a 100644 --- a/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c +++ b/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O3 -ftree-vectorize -fno-vect-cost-model" } */ +/* { dg-options "-O3 -ftree-vectorize -fno-vect-cost-model -fno-schedule-insns" } */ float arr_f[100][100]; float f9 (void)