| Message ID | 68e3188e71377820649c0c484958b3af2df722d6.1479975110.git.baolin.wang@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Hello. On 11/24/2016 11:13 AM, Baolin Wang wrote: > Since these 'return' statements are not generally useful in void function, > remove them. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> [...] > diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c > index 48a26d378..d6f59a3 100644 > --- a/drivers/usb/host/xhci-mem.c > +++ b/drivers/usb/host/xhci-mem.c > @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud > case USB_SPEED_WIRELESS: > xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n"); > return -EINVAL; > - break; Here you're removing *break* instead but not mentioning this in the patch description... [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 24 November 2016 at 17:30, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 11/24/2016 11:13 AM, Baolin Wang wrote: > >> Since these 'return' statements are not generally useful in void function, >> remove them. >> >> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > [...] >> >> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c >> index 48a26d378..d6f59a3 100644 >> --- a/drivers/usb/host/xhci-mem.c >> +++ b/drivers/usb/host/xhci-mem.c >> @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd >> *xhci, struct usb_device *ud >> case USB_SPEED_WIRELESS: >> xhci_dbg(xhci, "FIXME xHCI doesn't support wireless >> speeds\n"); >> return -EINVAL; >> - break; > > > Here you're removing *break* instead but not mentioning this in the patch > description... OK. I will add description to explain it in new patch. Thanks. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1690..470ad66 100644 --- a/drivers/usb/host/xhci-hub.c +++ b/drivers/usb/host/xhci-hub.c @@ -444,8 +444,6 @@ void xhci_ring_device(struct xhci_hcd *xhci, int slot_id) xhci_ring_ep_doorbell(xhci, slot_id, i, 0); } } - - return; } static void xhci_disable_port(struct usb_hcd *hcd, struct xhci_hcd *xhci, diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 48a26d378..d6f59a3 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud case USB_SPEED_WIRELESS: xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n"); return -EINVAL; - break; default: /* Speed was set earlier, this shouldn't happen. */ return -EINVAL; diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index d415911..2057d08 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -157,7 +157,6 @@ static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring) ring->deq_seg = ring->deq_seg->next; ring->dequeue = ring->deq_seg->trbs; } - return; } /* @@ -1167,7 +1166,6 @@ static void xhci_handle_cmd_config_ep(struct xhci_hcd *xhci, int slot_id, ring_doorbell_for_active_rings(xhci, slot_id, ep_index); return; } - return; } static void xhci_handle_cmd_reset_dev(struct xhci_hcd *xhci, int slot_id, @@ -1258,7 +1256,6 @@ static void xhci_handle_stopped_cmd_ring(struct xhci_hcd *xhci, mod_timer(&xhci->cmd_timer, jiffies + XHCI_CMD_DEFAULT_TIMEOUT); xhci_ring_cmd_db(xhci); } - return; } @@ -1307,7 +1304,6 @@ void xhci_handle_command_timeout(unsigned long data) xhci_dbg(xhci, "Command timeout on stopped ring\n"); xhci_handle_stopped_cmd_ring(xhci, xhci->current_cmd); spin_unlock_irqrestore(&xhci->lock, flags); - return; } static void handle_cmd_completion(struct xhci_hcd *xhci, diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index cf30cb6..dc337b3 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -269,8 +269,6 @@ static void xhci_free_irq(struct xhci_hcd *xhci) return; if (pdev->irq > 0) free_irq(pdev->irq, xhci_to_hcd(xhci)); - - return; } /* @@ -351,7 +349,6 @@ static void xhci_cleanup_msix(struct xhci_hcd *xhci) } hcd->msix_enabled = 0; - return; } static void __maybe_unused xhci_msix_sync_irqs(struct xhci_hcd *xhci)
Since these 'return' statements are not generally useful in void function, remove them. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- drivers/usb/host/xhci-hub.c | 2 -- drivers/usb/host/xhci-mem.c | 1 - drivers/usb/host/xhci-ring.c | 4 ---- drivers/usb/host/xhci.c | 3 --- 4 files changed, 10 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html