| Message ID | 690669269.1124561.1477671348137@mail.yahoo.com |
|---|---|
| State | Superseded |
| Headers | show |
On 28-10-2016 18:15, Gianfranco Costamagna wrote: > (resending from my debian.org mail address, to avoid spam filtering) > > Hi Broadcom developers and linux wireless list. > > We found a possible issue in the cfg80211 implementation of the regulatory domain rules: > > .reg_rules = { > /* IEEE 802.11b/g, channels 1..11 */ > REG_RULE(2412-10, 2472+10, 40, 6, 20, 0), > > > the referred channel 11 has/should have a frequency of 2462, not 2472 (corresponding to channel 13). > Is this a typo in the code or the above comment? > > (I'm not sure why the override of reg.c is in place for 2.4 Ghz frequencies) > > Can you please double check and in case apply the attached patch? checking.... stay tuned. Regards, Arend
On 28-10-2016 22:41, Arend Van Spriel wrote: > On 28-10-2016 18:15, Gianfranco Costamagna wrote: >> (resending from my debian.org mail address, to avoid spam filtering) >> >> Hi Broadcom developers and linux wireless list. >> >> We found a possible issue in the cfg80211 implementation of the regulatory domain rules: >> >> .reg_rules = { >> /* IEEE 802.11b/g, channels 1..11 */ >> REG_RULE(2412-10, 2472+10, 40, 6, 20, 0), >> >> >> the referred channel 11 has/should have a frequency of 2462, not 2472 (corresponding to channel 13). >> Is this a typo in the code or the above comment? >> >> (I'm not sure why the override of reg.c is in place for 2.4 Ghz frequencies) >> >> Can you please double check and in case apply the attached patch? > > checking.... stay tuned. Hi Gianfranco, Finally response. As it turns out the range was explcitly changed enabling channels 12 and 13 to be used where applicable. They forgot to update the comment. Regards, Arend
Hi Arend, >Finally response. As it turns out the range was explcitly changed >enabling channels 12 and 13 to be used where applicable. They forgot to >update the comment. so, the struct in net/wireless/reg.c is actually used in that case? static const struct ieee80211_regdomain world_regdom = { do you plan to update the comment? thanks! Gianfranco
On 14-11-2016 12:34, Gianfranco Costamagna wrote: > Hi Arend, > > >> Finally response. As it turns out the range was explcitly changed > >> enabling channels 12 and 13 to be used where applicable. They forgot to >> update the comment. > > > so, the struct in net/wireless/reg.c is actually used in that case? > > static const struct ieee80211_regdomain world_regdom = { > > do you plan to update the comment? Well, not before you pointed it out ;-). You are welcome to send a patch fixing it. Otherwise, I will take care of it. Regards, Arend
From dc2eaeba8cf3d992a18745cfef1b74bbfc11715b Mon Sep 17 00:00:00 2001 From: Arlone Marco <marco.arlone@roj.com> Date: Sat, 22 Oct 2016 15:08:35 +0200 Subject: [PATCH] broadcom cfg80211: fix regulatory channel frequency channel 11 is actually 2462, not 2472 (that is channel 13 instead) Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com> Signed-off-by: Arlone Marco <marco.arlone@roj.com> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index b777e1b..d71f959 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -204,7 +204,7 @@ static const struct ieee80211_regdomain brcmf_regdom = { .alpha2 = "99", .reg_rules = { /* IEEE 802.11b/g, channels 1..11 */ - REG_RULE(2412-10, 2472+10, 40, 6, 20, 0), + REG_RULE(2412-10, 2462+10, 40, 6, 20, 0), /* If any */ /* IEEE 802.11 channel 14 - Only JP enables * this and for 802.11b only -- 2.7.4
(resending from my debian.org mail address, to avoid spam filtering) Hi Broadcom developers and linux wireless list. We found a possible issue in the cfg80211 implementation of the regulatory domain rules: .reg_rules = { /* IEEE 802.11b/g, channels 1..11 */ REG_RULE(2412-10, 2472+10, 40, 6, 20, 0), the referred channel 11 has/should have a frequency of 2462, not 2472 (corresponding to channel 13). Is this a typo in the code or the above comment? (I'm not sure why the override of reg.c is in place for 2.4 Ghz frequencies) Can you please double check and in case apply the attached patch? thanks, -- Gianfranco Costamagna