| Message ID | 1473704975-4636-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
Hi maintainers, Does this patch look good? 2016-09-13 3:29 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > The combo of list_empty() check and return list_first_entry() > can be replaced with list_first_entry_or_null(). > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > tools/perf/util/thread.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > index 8b10a55..ea951df 100644 > --- a/tools/perf/util/thread.c > +++ b/tools/perf/util/thread.c > @@ -107,10 +107,7 @@ void thread__put(struct thread *thread) > > struct comm *thread__comm(const struct thread *thread) > { > - if (list_empty(&thread->comm_list)) > - return NULL; > - > - return list_first_entry(&thread->comm_list, struct comm, list); > + return list_first_entry_or_null(&thread->comm_list, struct comm, list); > } > > struct comm *thread__exec_comm(const struct thread *thread) > -- > 1.9.1 > -- Best Regards Masahiro Yamada
Em Sun, Nov 06, 2016 at 12:00:22PM +0900, Masahiro Yamada escreveu: > Hi maintainers, > > Does this patch look good? From a quick look it seems ok, I'll try and process it when back home. - Arnaldo > 2016-09-13 3:29 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > > The combo of list_empty() check and return list_first_entry() > > can be replaced with list_first_entry_or_null(). > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > tools/perf/util/thread.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > > index 8b10a55..ea951df 100644 > > --- a/tools/perf/util/thread.c > > +++ b/tools/perf/util/thread.c > > @@ -107,10 +107,7 @@ void thread__put(struct thread *thread) > > > > struct comm *thread__comm(const struct thread *thread) > > { > > - if (list_empty(&thread->comm_list)) > > - return NULL; > > - > > - return list_first_entry(&thread->comm_list, struct comm, list); > > + return list_first_entry_or_null(&thread->comm_list, struct comm, list); > > } > > > > struct comm *thread__exec_comm(const struct thread *thread) > > -- > > 1.9.1 > > > > > > -- > Best Regards > Masahiro Yamada
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c index 8b10a55..ea951df 100644 --- a/tools/perf/util/thread.c +++ b/tools/perf/util/thread.c @@ -107,10 +107,7 @@ void thread__put(struct thread *thread) struct comm *thread__comm(const struct thread *thread) { - if (list_empty(&thread->comm_list)) - return NULL; - - return list_first_entry(&thread->comm_list, struct comm, list); + return list_first_entry_or_null(&thread->comm_list, struct comm, list); } struct comm *thread__exec_comm(const struct thread *thread)
The combo of list_empty() check and return list_first_entry() can be replaced with list_first_entry_or_null(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- tools/perf/util/thread.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 1.9.1