| Message ID | 1477415736-11265-2-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | ff52589c745451682ecd8f53814f4715e0405efa |
| Headers | show |
On Tue, Oct 25, 2016 at 06:15:32PM +0100, Ard Biesheuvel wrote: > This givers us a working backspace key, but it happens to be a prerequisite > for using the ArmPkg implementation for PlatformBootManagerLib (used by the > generic BDS) so now is a good time to make this change. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > index 823c934f3159..3526da121c43 100644 > --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > @@ -430,6 +430,9 @@ > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > !endif > > + # use the TTY terminal type (which has a working backspace) If you add "in the default behaviour of most Linux terminal emulators" or equivalent to the above, including the commit message (or just there and delete the "working backspace" comment here): Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 > + > !ifdef EDK2_ENABLE_SMSC_91X > # Ethernet (SMSC 91C111) > gLan91xDxeTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x1A000000 > -- > 2.7.4 >
On 25 October 2016 at 18:15, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > This givers us a working backspace key, but it happens to be a prerequisite > for using the ArmPkg implementation for PlatformBootManagerLib (used by the > generic BDS) so now is a good time to make this change. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > index 823c934f3159..3526da121c43 100644 > --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > @@ -430,6 +430,9 @@ > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > !endif > > + # use the TTY terminal type (which has a working backspace) > + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 > + > !ifdef EDK2_ENABLE_SMSC_91X > # Ethernet (SMSC 91C111) > gLan91xDxeTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x1A000000 > -- > 2.7.4 > Note to self, more than anything else: you need to erase your env vars in NOR for this to make any difference ;-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 823c934f3159..3526da121c43 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -430,6 +430,9 @@ gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } !endif + # use the TTY terminal type (which has a working backspace) + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 + !ifdef EDK2_ENABLE_SMSC_91X # Ethernet (SMSC 91C111) gLan91xDxeTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x1A000000
This givers us a working backspace key, but it happens to be a prerequisite for using the ArmPkg implementation for PlatformBootManagerLib (used by the generic BDS) so now is a good time to make this change. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 3 +++ 1 file changed, 3 insertions(+)