diff mbox

linux-generic: fix ISO C compiling issue with -Werror=pedantic

Message ID 1477292539-23400-1-git-send-email-forrest.shi@linaro.org
State Accepted
Commit e01d879bd344f89d25568d93531d457e87e80f6f
Headers show

Commit Message

Forrest Shi Oct. 24, 2016, 7:02 a.m. UTC
From: Xuelin Shi <forrest.shi@linaro.org>


ISO C does not allow extra ‘;’ outside of a function.

Signed-off-by: Xuelin Shi <forrest.shi@linaro.org>

---
 platform/linux-generic/include/odp/api/plat/atomic_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

Comments

Bill Fischofer Oct. 25, 2016, 1:55 a.m. UTC | #1
On Mon, Oct 24, 2016 at 2:02 AM, <forrest.shi@linaro.org> wrote:

> From: Xuelin Shi <forrest.shi@linaro.org>

>

> ISO C does not allow extra ‘;’ outside of a function.

>

> Signed-off-by: Xuelin Shi <forrest.shi@linaro.org>

>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>



> ---

>  platform/linux-generic/include/odp/api/plat/atomic_types.h | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/platform/linux-generic/include/odp/api/plat/atomic_types.h

> b/platform/linux-generic/include/odp/api/plat/atomic_types.h

> index 3bb2bbd..33a0565 100644

> --- a/platform/linux-generic/include/odp/api/plat/atomic_types.h

> +++ b/platform/linux-generic/include/odp/api/plat/atomic_types.h

> @@ -32,7 +32,7 @@ struct odp_atomic_u64_s {

>          * data types. We use a spin lock to ensure atomicity. */

>         char lock; /**< Spin lock (if needed) used to ensure atomic access

> */

>  #endif

> -} ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */;

> +} ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */

>

>  /**

>   * @internal

> @@ -40,7 +40,7 @@ struct odp_atomic_u64_s {

>   */

>  struct odp_atomic_u32_s {

>         uint32_t v; /**< Actual storage for the atomic variable */

> -} ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */;

> +} ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */

>

>  #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2

>

> --

> 2.7.4

>

>
Maxim Uvarov Oct. 26, 2016, 2:50 p.m. UTC | #2
Merged,
Maxim.

On 10/25/16 04:55, Bill Fischofer wrote:
>

>

> On Mon, Oct 24, 2016 at 2:02 AM, <forrest.shi@linaro.org 

> <mailto:forrest.shi@linaro.org>> wrote:

>

>     From: Xuelin Shi <forrest.shi@linaro.org

>     <mailto:forrest.shi@linaro.org>>

>

>     ISO C does not allow extra ‘;’ outside of a function.

>

>     Signed-off-by: Xuelin Shi <forrest.shi@linaro.org

>     <mailto:forrest.shi@linaro.org>>

>

>

> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 

> <mailto:bill.fischofer@linaro.org>>

>

>     ---

>      platform/linux-generic/include/odp/api/plat/atomic_types.h | 4 ++--

>      1 file changed, 2 insertions(+), 2 deletions(-)

>

>     diff --git

>     a/platform/linux-generic/include/odp/api/plat/atomic_types.h

>     b/platform/linux-generic/include/odp/api/plat/atomic_types.h

>     index 3bb2bbd..33a0565 100644

>     --- a/platform/linux-generic/include/odp/api/plat/atomic_types.h

>     +++ b/platform/linux-generic/include/odp/api/plat/atomic_types.h

>     @@ -32,7 +32,7 @@ struct odp_atomic_u64_s {

>              * data types. We use a spin lock to ensure atomicity. */

>             char lock; /**< Spin lock (if needed) used to ensure

>     atomic access */

>      #endif

>     -} ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */;

>     +} ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */

>

>      /**

>       * @internal

>     @@ -40,7 +40,7 @@ struct odp_atomic_u64_s {

>       */

>      struct odp_atomic_u32_s {

>             uint32_t v; /**< Actual storage for the atomic variable */

>     -} ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */;

>     +} ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */

>

>      #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2

>

>     --

>     2.7.4

>

>
diff mbox

Patch

diff --git a/platform/linux-generic/include/odp/api/plat/atomic_types.h b/platform/linux-generic/include/odp/api/plat/atomic_types.h
index 3bb2bbd..33a0565 100644
--- a/platform/linux-generic/include/odp/api/plat/atomic_types.h
+++ b/platform/linux-generic/include/odp/api/plat/atomic_types.h
@@ -32,7 +32,7 @@  struct odp_atomic_u64_s {
 	 * data types. We use a spin lock to ensure atomicity. */
 	char lock; /**< Spin lock (if needed) used to ensure atomic access */
 #endif
-} ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */;
+} ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */
 
 /**
  * @internal
@@ -40,7 +40,7 @@  struct odp_atomic_u64_s {
  */
 struct odp_atomic_u32_s {
 	uint32_t v; /**< Actual storage for the atomic variable */
-} ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */;
+} ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */
 
 #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2