diff mbox

[RESEND,1/7,v4] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms

Message ID 1471906608-12418-2-git-send-email-john.stultz@linaro.org
State Superseded
Headers show

Commit Message

John Stultz Aug. 22, 2016, 10:56 p.m. UTC 
This allows the k3dma driver to be selected on HiKey via the ARCH_HISI
dependency.

Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>

Signed-off-by: John Stultz <john.stultz@linaro.org>

---
v2:
* Use ARCH_HISI and COMPILE_TEST dependency, suggested by Mark Brown,
  instead of just removing all dependencies.
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

Comments

John Stultz Aug. 23, 2016, 4:24 a.m. UTC | #1 
On Mon, Aug 22, 2016 at 9:23 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi John,

>

> [auto build test ERROR on linus/master]

> [also build test ERROR on v4.8-rc3 next-20160822]

> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]

> [Check https://git-scm.com/docs/git-format-patch for more information]

>

> url:    https://github.com/0day-ci/linux/commits/John-Stultz/K3DMA-fixes-for-HiKey-HDMI-audio/20160823-070749

> config: i386-allmodconfig (attached as .config)

> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705

> reproduce:

>         # save the attached .config to linux build tree

>         make ARCH=i386

>

> Note: the linux-review/John-Stultz/K3DMA-fixes-for-HiKey-HDMI-audio/20160823-070749 HEAD 1f1a623a69af65b192d7f6e2949d4a2dcf75d137 builds fine.

>       It only hurts bisectibility.

>

> All errors (new ones prefixed by >>):

>

>    drivers/dma/k3dma.c: In function 'k3_dma_prep_memcpy':

>>> drivers/dma/k3dma.c:432:20: error: implicit declaration of function '__virt_to_phys' [-Werror=implicit-function-declaration]

>      ds->desc_hw_lli = __virt_to_phys((unsigned long)&ds->desc_hw[0]);

>                        ^~~~~~~~~~~~~~


Grumble.. Looks like this is due to COMPILE_TEST being enabled in the
i386 config and the Kconfig change happening before the fix to remove
__virt_to_phys from this driver.

Reordering so the Kconfig change is applied last would avoid this.

Vinod/Dan: Would you prefer I resend a new patchset with the fixed
order, or do you mind re-ordering the Kconfig change when you apply?

thanks
-john
diff mbox

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 739f797..fe2dbb8 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -279,7 +279,7 @@  config INTEL_MIC_X100_DMA
 
 config K3_DMA
 	tristate "Hisilicon K3 DMA support"
-	depends on ARCH_HI3xxx
+	depends on ARCH_HI3xxx || ARCH_HISI || COMPILE_TEST
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help