diff mbox

[2/2] libunwind: Do not use gold for linking

Message ID 20160808225101.32385-2-raj.khem@gmail.com
State Accepted
Commit 0092a076adb11cac411c86389af84bb96169730f
Headers show

Commit Message

Khem Raj Aug. 8, 2016, 10:51 p.m. UTC
This effectively reverts the commit
3dd233ac0c80393824100c54bb525236f8290fd2

gold now emits errors on copy relocs against
protected symbols what ld.bfd did in past, however
it seems its too conservative.

This does not fix the case for folks who
use gold as default linker, however it
does make bintuls 2.27 work with default
configuration of OE

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-support/libunwind/libunwind.inc | 9 ---------
 1 file changed, 9 deletions(-)

-- 
2.9.2

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Ross Burton Aug. 8, 2016, 11:25 p.m. UTC | #1
On 8 August 2016 at 23:51, Khem Raj <raj.khem@gmail.com> wrote:

> This effectively reverts the commit

> 3dd233ac0c80393824100c54bb525236f8290fd2

>

> gold now emits errors on copy relocs against

> protected symbols what ld.bfd did in past, however

> it seems its too conservative.

>

> This does not fix the case for folks who

> use gold as default linker, however it

> does make bintuls 2.27 work with default

> configuration of OE

>


Presumably this is blocked by the binutils upgrade and should be merged
with it and not beforehand?

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Aug. 9, 2016, 1:48 a.m. UTC | #2
> On Aug 8, 2016, at 4:25 PM, Burton, Ross <ross.burton@intel.com> wrote:

> 

> 

> On 8 August 2016 at 23:51, Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> wrote:

> This effectively reverts the commit

> 3dd233ac0c80393824100c54bb525236f8290fd2

> 

> gold now emits errors on copy relocs against

> protected symbols what ld.bfd did in past, however

> it seems its too conservative.

> 

> This does not fix the case for folks who

> use gold as default linker, however it

> does make bintuls 2.27 work with default

> configuration of OE

> 

> Presumably this is blocked by the binutils upgrade and should be merged with it and not beforehand?


Thats right.

> 

> Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox

Patch

diff --git a/meta/recipes-support/libunwind/libunwind.inc b/meta/recipes-support/libunwind/libunwind.inc
index 1c342d3..e4ae8df 100644
--- a/meta/recipes-support/libunwind/libunwind.inc
+++ b/meta/recipes-support/libunwind/libunwind.inc
@@ -18,15 +18,6 @@  ATOMICOPS_armv5 = "-DAO_USE_PTHREAD_DEFS=1"
 ATOMICOPS_armv4 = "-DAO_USE_PTHREAD_DEFS=1"
 ATOMICOPS ?= ""
 
-LDFLAGS_append_x86 = " -fuse-ld=gold"
-LDFLAGS_append_x86-64 = " -fuse-ld=gold"
-
-LDFLAGS_append_arm = " -fuse-ld=gold"
-LDFLAGS_append_aarch64 = " -fuse-ld=gold"
-
-LDFLAGS_append_powerpc = " -fuse-ld=gold -mbss-plt"
-LDFLAGS_append_powerpc64 = " -fuse-ld=gold -mbss-plt"
-
 SECURITY_LDFLAGS_append_libc-musl = " -lssp_nonshared -lssp"
 
 BBCLASSEXTEND = "native"