| Message ID | 1469198527-12525-1-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
On 22/07/16 16:27, Antoine Tenart wrote: > Hello, > > On Fri, Jul 22, 2016 at 03:42:07PM +0100, Sudeep Holla wrote: >> Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring >> the following config warning: >> >> warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI) >> >> This patch makes selection of ALPINE_MSI conditional on PCI. > > [...] > >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -8,7 +8,7 @@ config ARCH_SUNXI >> >> config ARCH_ALPINE >> bool "Annapurna Labs Alpine platform" >> - select ALPINE_MSI >> + select ALPINE_MSI if PCI >> help >> This enables support for the Annapurna Labs Alpine >> Soc family. > > ALPINE_MSI also depends on PCI_MSI (which itself depends on PCI). ALPINE_MSI now selects PCI_MSI > PCI_MSI isn't necessarily selected when PCI is, so please make the Yes but ALPINE_MSI does it now as I mentioned above. > ALPINE_MSI selection conditional on PCI_MSI instead. > I will wait for Arnd's response if that's OK as he seem to have made some changes around this recently. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index bb2616b16157..fd3ee3a392be 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -8,7 +8,7 @@ config ARCH_SUNXI config ARCH_ALPINE bool "Annapurna Labs Alpine platform" - select ALPINE_MSI + select ALPINE_MSI if PCI help This enables support for the Annapurna Labs Alpine Soc family.
Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring the following config warning: warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI) This patch makes selection of ALPINE_MSI conditional on PCI. Cc: Antoine Tenart <antoine.tenart@free-electrons.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- arch/arm64/Kconfig.platforms | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Hi Arnd, I happened to end up with a config without PCI when switching between DT and ACPI and saw the config warnings. This is against today's next, not sure if you have some fix already queued. Also I am not sure if ALPINE_MSI is must for this platform to boot in which case it needs to select PCI. Regards, Sudeep -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel