| Message ID | 1465402525-30060-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
it will be more complicated to follow dependencies if there will be separate version. I think for now it's better to stay with existence version numbers. Maxim. On 8 June 2016 at 19:15, Anders Roxell <anders.roxell@linaro.org> wrote: > The libodphelper and libopd need to track their evolving ABI > independently and so there needs to be two separate version numbers. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > configure.ac | 3 +++ > helper/Makefile.am | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index a12f984..85dd3b1 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -15,6 +15,9 @@ AM_SILENT_RULES([yes]) > ODP_LIBSO_VERSION=110:0:0 > AC_SUBST(ODP_LIBSO_VERSION) > > +ODPHELPER_LIBSO_VERSION=110:0:0 > +AC_SUBST(ODPHELPER_LIBSO_VERSION) > + > # Checks for programs. > AC_PROG_CC > AM_PROG_CC_C_O > diff --git a/helper/Makefile.am b/helper/Makefile.am > index aa58e8c..a82a11a 100644 > --- a/helper/Makefile.am > +++ b/helper/Makefile.am > @@ -8,7 +8,7 @@ AM_CFLAGS = -I$(srcdir)/include > AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include > AM_CFLAGS += -I$(top_srcdir)/include > > -AM_LDFLAGS += -version-number '$(ODP_LIBSO_VERSION)' > +AM_LDFLAGS += -version-number '$(ODPHELPER_LIBSO_VERSION)' > > helperincludedir = $(includedir)/odp/helper/ > helperinclude_HEADERS = \ > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
On 8 June 2016 at 14:33, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > it will be more complicated to follow dependencies if there will be > separate version. I think for now it's better to stay with existence > version numbers. > Can you explain the complication, I thought this makes things much simpler. As Yi decouples the helpers I dont think we can avoid this, the helpers will have an evolution that is is no way correlated to a specific implementation, it can be packaged, installed and will then be used by any system using Linux in the case of the current helpers implementation. > > Maxim. > > On 8 June 2016 at 19:15, Anders Roxell <anders.roxell@linaro.org> wrote: > >> The libodphelper and libopd need to track their evolving ABI >> independently and so there needs to be two separate version numbers. >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> configure.ac | 3 +++ >> helper/Makefile.am | 2 +- >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index a12f984..85dd3b1 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -15,6 +15,9 @@ AM_SILENT_RULES([yes]) >> ODP_LIBSO_VERSION=110:0:0 >> AC_SUBST(ODP_LIBSO_VERSION) >> >> +ODPHELPER_LIBSO_VERSION=110:0:0 >> +AC_SUBST(ODPHELPER_LIBSO_VERSION) >> + >> # Checks for programs. >> AC_PROG_CC >> AM_PROG_CC_C_O >> diff --git a/helper/Makefile.am b/helper/Makefile.am >> index aa58e8c..a82a11a 100644 >> --- a/helper/Makefile.am >> +++ b/helper/Makefile.am >> @@ -8,7 +8,7 @@ AM_CFLAGS = -I$(srcdir)/include >> AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include >> AM_CFLAGS += -I$(top_srcdir)/include >> >> -AM_LDFLAGS += -version-number '$(ODP_LIBSO_VERSION)' >> +AM_LDFLAGS += -version-number '$(ODPHELPER_LIBSO_VERSION)' >> >> helperincludedir = $(includedir)/odp/helper/ >> helperinclude_HEADERS = \ >> -- >> 2.1.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > >
On 06/08/16 21:46, Mike Holmes wrote: > > > On 8 June 2016 at 14:33, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > it will be more complicated to follow dependencies if there will > be separate version. I think for now it's better to stay with > existence version numbers. > > > Can you explain the complication, I thought this makes things much > simpler. > > As Yi decouples the helpers I dont think we can avoid this, the > helpers will have an evolution that is is no way correlated to a > specific implementation, it can be packaged, installed and will then > be used by any system using Linux in the case of the current helpers > implementation. From my point it's easy to have same version for both libodp and libodphelper if they are in the same git repo. It's more easy to maintain it and jump in code to specific version if you need debug something. If helpers will go to separate repo then there is reason for helpers version and in terms of maintains it's separate project. Maxim. > > > > > Maxim. > > On 8 June 2016 at 19:15, Anders Roxell <anders.roxell@linaro.org > <mailto:anders.roxell@linaro.org>> wrote: > > The libodphelper and libopd need to track their evolving ABI > independently and so there needs to be two separate version > numbers. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org > <mailto:anders.roxell@linaro.org>> > --- > configure.ac <http://configure.ac> | 3 +++ > helper/Makefile.am | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configure.ac <http://configure.ac> b/configure.ac > <http://configure.ac> > index a12f984..85dd3b1 100644 > --- a/configure.ac <http://configure.ac> > +++ b/configure.ac <http://configure.ac> > @@ -15,6 +15,9 @@ AM_SILENT_RULES([yes]) > ODP_LIBSO_VERSION=110:0:0 > AC_SUBST(ODP_LIBSO_VERSION) > > +ODPHELPER_LIBSO_VERSION=110:0:0 > +AC_SUBST(ODPHELPER_LIBSO_VERSION) > + > # Checks for programs. > AC_PROG_CC > AM_PROG_CC_C_O > diff --git a/helper/Makefile.am b/helper/Makefile.am > index aa58e8c..a82a11a 100644 > --- a/helper/Makefile.am > +++ b/helper/Makefile.am > @@ -8,7 +8,7 @@ AM_CFLAGS = -I$(srcdir)/include > AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include > AM_CFLAGS += -I$(top_srcdir)/include > > -AM_LDFLAGS += -version-number '$(ODP_LIBSO_VERSION)' > +AM_LDFLAGS += -version-number '$(ODPHELPER_LIBSO_VERSION)' > > helperincludedir = $(includedir)/odp/helper/ > helperinclude_HEADERS = \ > -- > 2.1.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" >
diff --git a/configure.ac b/configure.ac index a12f984..85dd3b1 100644 --- a/configure.ac +++ b/configure.ac @@ -15,6 +15,9 @@ AM_SILENT_RULES([yes]) ODP_LIBSO_VERSION=110:0:0 AC_SUBST(ODP_LIBSO_VERSION) +ODPHELPER_LIBSO_VERSION=110:0:0 +AC_SUBST(ODPHELPER_LIBSO_VERSION) + # Checks for programs. AC_PROG_CC AM_PROG_CC_C_O diff --git a/helper/Makefile.am b/helper/Makefile.am index aa58e8c..a82a11a 100644 --- a/helper/Makefile.am +++ b/helper/Makefile.am @@ -8,7 +8,7 @@ AM_CFLAGS = -I$(srcdir)/include AM_CFLAGS += -I$(top_srcdir)/platform/@with_platform@/include AM_CFLAGS += -I$(top_srcdir)/include -AM_LDFLAGS += -version-number '$(ODP_LIBSO_VERSION)' +AM_LDFLAGS += -version-number '$(ODPHELPER_LIBSO_VERSION)' helperincludedir = $(includedir)/odp/helper/ helperinclude_HEADERS = \
The libodphelper and libopd need to track their evolving ABI independently and so there needs to be two separate version numbers. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- configure.ac | 3 +++ helper/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)