diff mbox

hw/arm/virt: fix limit of 64-bit ACPI/ECAM PCI MMIO range

Message ID 1463856217-17969-1-git-send-email-ard.biesheuvel@linaro.org
State Superseded
Headers show

Commit Message

Ard Biesheuvel May 21, 2016, 6:43 p.m. UTC 
Set the MMIO range limit field to 'base + size - 1' as required.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 hw/arm/virt-acpi-build.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1

Comments

Laszlo Ersek May 24, 2016, 8:18 a.m. UTC | #1 
On 05/21/16 20:43, Ard Biesheuvel wrote:
> Set the MMIO range limit field to 'base + size - 1' as required.

> 

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  hw/arm/virt-acpi-build.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c

> index f51fe396ce9c..60a70370dd96 100644

> --- a/hw/arm/virt-acpi-build.c

> +++ b/hw/arm/virt-acpi-build.c

> @@ -230,7 +230,8 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,

>          aml_append(rbuf,

>              aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,

>                               AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,

> -                             base_mmio_high, base_mmio_high, 0x0000,

> +                             base_mmio_high,

> +                             base_mmio_high + size_mmio_high - 1, 0x0000,

>                               size_mmio_high));

>      }

>  

> 


$ scripts/get_maintainer.pl -f hw/arm/virt-acpi-build.c

"Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS)
Igor Mammedov <imammedo@redhat.com> (supporter:ACPI/SMBIOS)
Shannon Zhao <zhaoshenglong@huawei.com> (maintainer:ARM ACPI Subsystem)
Peter Maydell <peter.maydell@linaro.org> (maintainer:ARM)
qemu-arm@nongnu.org (open list:ARM ACPI Subsystem)
qemu-devel@nongnu.org (open list:All patches CC here)

For this patch specifically, I'm CC'ing Shannon.

Thanks
Laszlo
Peter Maydell May 24, 2016, 3:51 p.m. UTC | #2 
On 24 May 2016 at 10:01, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>

>

> On 2016/5/24 16:18, Laszlo Ersek wrote:

>> On 05/21/16 20:43, Ard Biesheuvel wrote:

>>> Set the MMIO range limit field to 'base + size - 1' as required.

>>>

>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>




Applied to target-arm.next, thanks.

-- PMM
diff mbox

Patch

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f51fe396ce9c..60a70370dd96 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -230,7 +230,8 @@  static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
         aml_append(rbuf,
             aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
                              AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,
-                             base_mmio_high, base_mmio_high, 0x0000,
+                             base_mmio_high,
+                             base_mmio_high + size_mmio_high - 1, 0x0000,
                              size_mmio_high));
     }