| Message ID | 1460033062-23400-1-git-send-email-bill.fischofer@linaro.org |
|---|---|
| State | Accepted |
| Commit | 79085b187ff359cace325445a9d9ba5cc99190fb |
| Headers | show |
On 7 April 2016 at 08:44, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2168 by commenting out > last stage setting in odp_init_local(). This will need to be uncommented > if further stages are added in subsequent updates. > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > platform/linux-generic/odp_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/platform/linux-generic/odp_init.c > b/platform/linux-generic/odp_init.c > index 11e2ec3..43ff742 100644 > --- a/platform/linux-generic/odp_init.c > +++ b/platform/linux-generic/odp_init.c > @@ -253,7 +253,7 @@ int odp_init_local(odp_thread_type_t thr_type) > ODP_ERR("ODP schedule local init failed.\n"); > goto init_fail; > } > - stage = SCHED_INIT; > + /* stage = SCHED_INIT; */ > Any new init code will clearly see the pattern so I dont think keeping this as a comment containing dead code helps. It should just be deleted until it is needed by any patch adding an init stage > > return 0; > > -- > 2.5.0 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
On 7 April 2016 at 08:44, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2168 by commenting out > last stage setting in odp_init_local(). This will need to be uncommented > if further stages are added in subsequent updates. > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > Reviewed-by: Mike Holmes <Mike.holmes@linaro.org> > --- > platform/linux-generic/odp_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/platform/linux-generic/odp_init.c > b/platform/linux-generic/odp_init.c > index 11e2ec3..43ff742 100644 > --- a/platform/linux-generic/odp_init.c > +++ b/platform/linux-generic/odp_init.c > @@ -253,7 +253,7 @@ int odp_init_local(odp_thread_type_t thr_type) > ODP_ERR("ODP schedule local init failed.\n"); > goto init_fail; > } > - stage = SCHED_INIT; > + /* stage = SCHED_INIT; */ > > return 0; > > -- > 2.5.0 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
merged On 5 May 2016 at 09:03, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 7 April 2016 at 08:44, Bill Fischofer <bill.fischofer@linaro.org> > wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2168 by commenting >> out >> last stage setting in odp_init_local(). This will need to be uncommented >> if further stages are added in subsequent updates. >> >> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >> > > Reviewed-by: Mike Holmes <Mike.holmes@linaro.org> > > >> --- >> platform/linux-generic/odp_init.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/platform/linux-generic/odp_init.c >> b/platform/linux-generic/odp_init.c >> index 11e2ec3..43ff742 100644 >> --- a/platform/linux-generic/odp_init.c >> +++ b/platform/linux-generic/odp_init.c >> @@ -253,7 +253,7 @@ int odp_init_local(odp_thread_type_t thr_type) >> ODP_ERR("ODP schedule local init failed.\n"); >> goto init_fail; >> } >> - stage = SCHED_INIT; >> + /* stage = SCHED_INIT; */ >> >> return 0; >> >> -- >> 2.5.0 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c index 11e2ec3..43ff742 100644 --- a/platform/linux-generic/odp_init.c +++ b/platform/linux-generic/odp_init.c @@ -253,7 +253,7 @@ int odp_init_local(odp_thread_type_t thr_type) ODP_ERR("ODP schedule local init failed.\n"); goto init_fail; } - stage = SCHED_INIT; + /* stage = SCHED_INIT; */ return 0;
Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2168 by commenting out last stage setting in odp_init_local(). This will need to be uncommented if further stages are added in subsequent updates. Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> --- platform/linux-generic/odp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)