| Message ID | 1460375463-15557-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | ca6341711923263aee85f384a8f8cf606fc64acd |
| Headers | show |
On 11 April 2016 at 13:51, Linus Walleij <linus.walleij@linaro.org> wrote: > Let all SPI masters ignore their children: when it comes > to power management: SPI children have no business doing > keeping their parents awake: they are completely autonomous > devices that just use their parent to talk, and the latter > usecase must be power managed by the host itself on a > per-message basis. > > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Mark Brown <broonie@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > ChangeLog v1->v2: > - Change subject from > "let SPI masters inherit suspend child ignorance" > to > "let SPI masters ignore their PM children" > - Use the big hammer and do the sensible thing: > mark all SPI masters as ignoring their children > when it comes to power management. > --- > drivers/spi/spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index de2f2f90d799..6c4c050e6b65 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1764,6 +1764,7 @@ struct spi_master *spi_alloc_master(struct device *dev, unsigned size) > master->num_chipselect = 1; > master->dev.class = &spi_master_class; > master->dev.parent = dev; > + pm_suspend_ignore_children(&master->dev, true); > spi_master_set_devdata(master, &master[1]); > > return master; > -- > 2.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 11, 2016 at 1:51 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > Let all SPI masters ignore their children: when it comes > to power management: SPI children have no business doing > keeping their parents awake: they are completely autonomous > devices that just use their parent to talk, and the latter > usecase must be power managed by the host itself on a > per-message basis. > > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Mark Brown <broonie@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Mark did this slip through the cracks or is there some problem with it? The corresponding patch to I2C is applied in commit 04f59143b571 "i2c: let I2C masters ignore their children for PM" Tell me if I should resend it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 23, 2016 at 02:56:29PM +0200, Linus Walleij wrote: > Mark did this slip through the cracks or is there some > problem with it? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway. > The corresponding patch to I2C is applied in commit > 04f59143b571 "i2c: let I2C masters ignore their children for PM" > > Tell me if I should resend it. It's in my git...
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index de2f2f90d799..6c4c050e6b65 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1764,6 +1764,7 @@ struct spi_master *spi_alloc_master(struct device *dev, unsigned size) master->num_chipselect = 1; master->dev.class = &spi_master_class; master->dev.parent = dev; + pm_suspend_ignore_children(&master->dev, true); spi_master_set_devdata(master, &master[1]); return master;
Let all SPI masters ignore their children: when it comes to power management: SPI children have no business doing keeping their parents awake: they are completely autonomous devices that just use their parent to talk, and the latter usecase must be power managed by the host itself on a per-message basis. Cc: Wolfram Sang <wsa@the-dreams.de> Cc: Mark Brown <broonie@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Rafael J. Wysocki <rjw@rjwysocki.net> Cc: linux-pm@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v1->v2: - Change subject from "let SPI masters inherit suspend child ignorance" to "let SPI masters ignore their PM children" - Use the big hammer and do the sensible thing: mark all SPI masters as ignoring their children when it comes to power management. --- drivers/spi/spi.c | 1 + 1 file changed, 1 insertion(+) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html