diff mbox

linux-generic/odp_impl: removing __DATE__ and __TIME__

Message ID 1460041183-28643-1-git-send-email-ricardo.salveti@linaro.org
State Accepted
Commit 1f23ca056ef357ea92e437f1f59795187608a35a
Headers show

Commit Message

Ricardo Salveti April 7, 2016, 2:59 p.m. UTC
This is so we can get reproducible builds. Besides the library version,
the string already contains the git hash, which is enough to traceback
the build used.

Bug-Link: https://bugs.linaro.org/show_bug.cgi?id=2154

Signed-off-by: Ricardo Salveti <ricardo.salveti@linaro.org>
---
 platform/linux-generic/odp_impl.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Anders Roxell April 7, 2016, 3:07 p.m. UTC | #1
On 7 April 2016 at 16:59, Ricardo Salveti <ricardo.salveti@linaro.org> wrote:
> This is so we can get reproducible builds. Besides the library version,
> the string already contains the git hash, which is enough to traceback
> the build used.
>
> Bug-Link: https://bugs.linaro.org/show_bug.cgi?id=2154
>
> Signed-off-by: Ricardo Salveti <ricardo.salveti@linaro.org>

Reviewed-by: Anders Roxell <anders.roxell@linaro.org>

> ---
>  platform/linux-generic/odp_impl.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
> index 0b89af7..f8d1dfe 100644
> --- a/platform/linux-generic/odp_impl.c
> +++ b/platform/linux-generic/odp_impl.c
> @@ -30,7 +30,6 @@ extern "C" {
>         ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "." \
>         ODP_VERSION_TO_STR(ODP_VERSION_API_MAJOR) "." \
>         ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) ") " \
> -       __DATE__ " " __TIME__ " " \
>         ODP_VERSION_TO_STR(GIT_HASH)
>
>  #define ODP_VERSION_IMPL_NAME \
> --
> 2.7.4
>
Maxim Uvarov April 8, 2016, 3:24 p.m. UTC | #2
Merged,
Maxim.

On 04/07/16 18:07, Anders Roxell wrote:
> On 7 April 2016 at 16:59, Ricardo Salveti <ricardo.salveti@linaro.org> wrote:
>> This is so we can get reproducible builds. Besides the library version,
>> the string already contains the git hash, which is enough to traceback
>> the build used.
>>
>> Bug-Link: https://bugs.linaro.org/show_bug.cgi?id=2154
>>
>> Signed-off-by: Ricardo Salveti <ricardo.salveti@linaro.org>
> Reviewed-by: Anders Roxell <anders.roxell@linaro.org>
>
>> ---
>>   platform/linux-generic/odp_impl.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
>> index 0b89af7..f8d1dfe 100644
>> --- a/platform/linux-generic/odp_impl.c
>> +++ b/platform/linux-generic/odp_impl.c
>> @@ -30,7 +30,6 @@ extern "C" {
>>          ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "." \
>>          ODP_VERSION_TO_STR(ODP_VERSION_API_MAJOR) "." \
>>          ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) ") " \
>> -       __DATE__ " " __TIME__ " " \
>>          ODP_VERSION_TO_STR(GIT_HASH)
>>
>>   #define ODP_VERSION_IMPL_NAME \
>> --
>> 2.7.4
>>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
index 0b89af7..f8d1dfe 100644
--- a/platform/linux-generic/odp_impl.c
+++ b/platform/linux-generic/odp_impl.c
@@ -30,7 +30,6 @@  extern "C" {
 	ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "." \
 	ODP_VERSION_TO_STR(ODP_VERSION_API_MAJOR) "." \
 	ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR) ") " \
-	__DATE__ " " __TIME__ " " \
 	ODP_VERSION_TO_STR(GIT_HASH)
 
 #define ODP_VERSION_IMPL_NAME \