| Message ID | 1459859044-27353-1-git-send-email-bill.fischofer@linaro.org |
|---|---|
| State | Accepted |
| Commit | a3b073aa1cfb45acf94366c6bd9159c4c58303d6 |
| Headers | show |
Could be slightly clearer with linux-generic: pool: align spec prototype with implementation of odp_buffer_free_mult On 5 April 2016 at 08:24, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> With a subject fix Reviewed-by: Mike Holmes <mike.holmes@linsro.org> > --- > platform/linux-generic/odp_pool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/platform/linux-generic/odp_pool.c > b/platform/linux-generic/odp_pool.c > index eb545b2..8c1490c 100644 > --- a/platform/linux-generic/odp_pool.c > +++ b/platform/linux-generic/odp_pool.c > @@ -574,11 +574,11 @@ void odp_buffer_free(odp_buffer_t buf) > ret_local_buf(&pool->s.local_cache[local_id], buf_hdr); > } > > -void odp_buffer_free_multi(const odp_buffer_t buf[], int len) > +void odp_buffer_free_multi(const odp_buffer_t buf[], int num) > { > int i; > > - for (i = 0; i < len; ++i) > + for (i = 0; i < num; ++i) > odp_buffer_free(buf[i]); > } > > -- > 2.5.0 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
Agree on the short msg change. Maxim: I can submit a v2 if you'd prefer that to fixing in merge. On Tue, Apr 5, 2016 at 7:36 AM, Mike Holmes <mike.holmes@linaro.org> wrote: > Could be slightly clearer with > > linux-generic: pool: align spec prototype with implementation of > odp_buffer_free_mult > > On 5 April 2016 at 08:24, Bill Fischofer <bill.fischofer@linaro.org> > wrote: > >> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > > > With a subject fix > Reviewed-by: Mike Holmes <mike.holmes@linsro.org> > > >> --- >> platform/linux-generic/odp_pool.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/platform/linux-generic/odp_pool.c >> b/platform/linux-generic/odp_pool.c >> index eb545b2..8c1490c 100644 >> --- a/platform/linux-generic/odp_pool.c >> +++ b/platform/linux-generic/odp_pool.c >> @@ -574,11 +574,11 @@ void odp_buffer_free(odp_buffer_t buf) >> ret_local_buf(&pool->s.local_cache[local_id], buf_hdr); >> } >> >> -void odp_buffer_free_multi(const odp_buffer_t buf[], int len) >> +void odp_buffer_free_multi(const odp_buffer_t buf[], int num) >> { >> int i; >> >> - for (i = 0; i < len; ++i) >> + for (i = 0; i < num; ++i) >> odp_buffer_free(buf[i]); >> } >> >> -- >> 2.5.0 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > >
I will fix. Maxim. On 04/05/16 15:51, Bill Fischofer wrote: > Agree on the short msg change. Maxim: I can submit a v2 if you'd > prefer that to fixing in merge. > > On Tue, Apr 5, 2016 at 7:36 AM, Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> wrote: > > Could be slightly clearer with > > linux-generic: pool: align spec prototype with implementation of > odp_buffer_free_mult > > On 5 April 2016 at 08:24, Bill Fischofer > <bill.fischofer@linaro.org <mailto:bill.fischofer@linaro.org>> wrote: > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > > > With a subject fix > Reviewed-by: Mike Holmes <mike.holmes@linsro.org > <mailto:mike.holmes@linsro.org>> > > --- > platform/linux-generic/odp_pool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/platform/linux-generic/odp_pool.c > b/platform/linux-generic/odp_pool.c > index eb545b2..8c1490c 100644 > --- a/platform/linux-generic/odp_pool.c > +++ b/platform/linux-generic/odp_pool.c > @@ -574,11 +574,11 @@ void odp_buffer_free(odp_buffer_t buf) > ret_local_buf(&pool->s.local_cache[local_id], buf_hdr); > } > > -void odp_buffer_free_multi(const odp_buffer_t buf[], int len) > +void odp_buffer_free_multi(const odp_buffer_t buf[], int num) > { > int i; > > - for (i = 0; i < len; ++i) > + for (i = 0; i < num; ++i) > odp_buffer_free(buf[i]); > } > > -- > 2.5.0 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for > ARM SoCs > "Work should be fun and collaborative, the rest follows" > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index eb545b2..8c1490c 100644 --- a/platform/linux-generic/odp_pool.c +++ b/platform/linux-generic/odp_pool.c @@ -574,11 +574,11 @@ void odp_buffer_free(odp_buffer_t buf) ret_local_buf(&pool->s.local_cache[local_id], buf_hdr); } -void odp_buffer_free_multi(const odp_buffer_t buf[], int len) +void odp_buffer_free_multi(const odp_buffer_t buf[], int num) { int i; - for (i = 0; i < len; ++i) + for (i = 0; i < num; ++i) odp_buffer_free(buf[i]); }
Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> --- platform/linux-generic/odp_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)