Message ID | 1454089021-24898-1-git-send-email-sudeep.holla@arm.com |
---|---|
State | Accepted |
Commit | 935514c961310558ee0767e73e678b85ac37a68d |
Headers | show |
Hi Mark, On 29/01/16 17:37, Sudeep Holla wrote: > The vexpress regulator implementation is currently just called vexpress. > This is a problem because it clashes with another module with the same > name in hardware monitors. > > This patch renames the vexpress regulator implementation to > vexpress-regulator so that there will be no clash in the module namespace. > Can you take this patch for v4.6 ? It was reported @[1] -- Regards, Sudeep [1] https://lkml.org/lkml/2016/1/29/7
On Wed, Feb 10, 2016 at 06:49:54PM +0000, Sudeep Holla wrote: > On 29/01/16 17:37, Sudeep Holla wrote: > >The vexpress regulator implementation is currently just called vexpress. > >This is a problem because it clashes with another module with the same > >name in hardware monitors. > >This patch renames the vexpress regulator implementation to > >vexpress-regulator so that there will be no clash in the module namespace. > Can you take this patch for v4.6 ? It was reported @[1] Please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway. > [1] https://lkml.org/lkml/2016/1/29/7 Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
On Mon, Feb 15, 2016 at 06:10:17PM +0000, Mark Brown wrote: > On Wed, Feb 10, 2016 at 06:49:54PM +0000, Sudeep Holla wrote: > > [1] https://lkml.org/lkml/2016/1/29/7 > Please include human readable descriptions of things like commits and > issues being discussed in e-mail in your mails, this makes them much > easier for humans to read especially when they have no internet access. > I do frequently catch up on my mail on flights or while otherwise > travelling so this is even more pressing for me than just being about > making things a bit easier to read. ...plus if you're using lkml.org it fails so often that it's likely people won't be able to tell what you're talking about anyway.
On 15/02/16 18:10, Mark Brown wrote: > On Wed, Feb 10, 2016 at 06:49:54PM +0000, Sudeep Holla wrote: >> On 29/01/16 17:37, Sudeep Holla wrote: > >>> The vexpress regulator implementation is currently just called vexpress. >>> This is a problem because it clashes with another module with the same >>> name in hardware monitors. > >>> This patch renames the vexpress regulator implementation to >>> vexpress-regulator so that there will be no clash in the module namespace. > >> Can you take this patch for v4.6 ? It was reported @[1] > > Please allow a reasonable time for review. People get busy, go on > holiday, attend conferences and so on so unless there is some reason for > urgency (like critical bug fixes) please allow at least a couple of > weeks for review. Sending content free pings just adds to the mail > volume (if they are seen at all) and if something has gone wrong you'll > have to resend the patches anyway. > Sorry for that. It was not a ping rather I just wanted to provide the reference for the report since I realized I missed that initially. I just asked the question along with that and didn't mean to show any urgency. I do understand this patch is clearly not at all an urgent/ critical fix. >> [1] https://lkml.org/lkml/2016/1/29/7 > > Please include human readable descriptions of things like commits and > issues being discussed in e-mail in your mails, this makes them much > easier for humans to read especially when they have no internet access. > I do frequently catch up on my mail on flights or while otherwise > travelling so this is even more pressing for me than just being about > making things a bit easier to read. > Understood. I knew lkml.org is broken if we tried very old links but expected to work at-least for couple of month old patches. Anyways hopefully [1] still works. -- Regards, Sudeep [1] http://www.spinics.net/lists/linux-crypto/msg18316.html
On Mon, Feb 15, 2016 at 06:31:29PM +0000, Sudeep Holla wrote: > Understood. I knew lkml.org is broken if we tried very old links but > expected to work at-least for couple of month old patches. Anyways > hopefully [1] still works. It's not old links in particular AFAICT, just general instability.
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index 980b1943fa81..755077a89a25 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile @@ -98,7 +98,7 @@ obj-$(CONFIG_REGULATOR_TPS65910) += tps65910-regulator.o obj-$(CONFIG_REGULATOR_TPS65912) += tps65912-regulator.o obj-$(CONFIG_REGULATOR_TPS80031) += tps80031-regulator.o obj-$(CONFIG_REGULATOR_TWL4030) += twl-regulator.o -obj-$(CONFIG_REGULATOR_VEXPRESS) += vexpress.o +obj-$(CONFIG_REGULATOR_VEXPRESS) += vexpress-regulator.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-dcdc.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-isink.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o diff --git a/drivers/regulator/vexpress.c b/drivers/regulator/vexpress-regulator.c similarity index 100% rename from drivers/regulator/vexpress.c rename to drivers/regulator/vexpress-regulator.c
The vexpress regulator implementation is currently just called vexpress. This is a problem because it clashes with another module with the same name in hardware monitors. This patch renames the vexpress regulator implementation to vexpress-regulator so that there will be no clash in the module namespace. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Reported-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/regulator/Makefile | 2 +- drivers/regulator/{vexpress.c => vexpress-regulator.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/regulator/{vexpress.c => vexpress-regulator.c} (100%) -- 1.9.1