diff mbox

[API-NEXT] api: pktio: remove unused ODP_PKTIO_ANY

Message ID 1452871076-9837-1-git-send-email-stuart.haslam@linaro.org
State Accepted
Commit 98662b5058afdcfd9dd08d8d9dfddebf589e8a87
Headers show

Commit Message

Stuart Haslam Jan. 15, 2016, 3:17 p.m. UTC
ODP_PKTIO_ANY is defined in the API header but there's no description of
its intended use and it wouldn't make sense to pass it to the majority
of exisitng APIs that take odp_pktio_t handles.

It's not currently used anywhere, so remove it.

Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
---
 include/odp/api/packet_io.h                               | 5 -----
 platform/linux-generic/include/odp/plat/packet_io_types.h | 2 --
 2 files changed, 7 deletions(-)

Comments

Maxim Uvarov Jan. 18, 2016, 11:57 a.m. UTC | #1
Merged.
Maxim.

On 01/18/2016 12:04, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
>
>
>> -----Original Message-----
>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT
>> Stuart Haslam
>> Sent: Friday, January 15, 2016 5:18 PM
>> To: lng-odp@lists.linaro.org
>> Subject: [lng-odp] [PATCH API-NEXT] api: pktio: remove unused
>> ODP_PKTIO_ANY
>>
>> ODP_PKTIO_ANY is defined in the API header but there's no description of
>> its intended use and it wouldn't make sense to pass it to the majority
>> of exisitng APIs that take odp_pktio_t handles.
>>
>> It's not currently used anywhere, so remove it.
>>
>> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
>> ---
>>   include/odp/api/packet_io.h                               | 5 -----
>>   platform/linux-generic/include/odp/plat/packet_io_types.h | 2 --
>>   2 files changed, 7 deletions(-)
>>
>> diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
>> index a0a2c12..4971108 100644
>> --- a/include/odp/api/packet_io.h
>> +++ b/include/odp/api/packet_io.h
>> @@ -58,11 +58,6 @@ extern "C" {
>>    */
>>
>>   /**
>> - * @def ODP_PKTIO_ANY
>> - * odp_pktio_t value to indicate any port
>> - */
>> -
>> -/**
>>    * @def ODP_PKTIO_MACADDR_MAXSIZE
>>    * Minimum size of output buffer for odp_pktio_mac_addr()
>>    * Actual MAC address sizes may be different.
>> diff --git a/platform/linux-generic/include/odp/plat/packet_io_types.h
>> b/platform/linux-generic/include/odp/plat/packet_io_types.h
>> index 25f7151..934d7de 100644
>> --- a/platform/linux-generic/include/odp/plat/packet_io_types.h
>> +++ b/platform/linux-generic/include/odp/plat/packet_io_types.h
>> @@ -42,8 +42,6 @@ typedef struct odp_pktout_queue_t {
>>
>>   #define ODP_PKTIO_INVALID _odp_cast_scalar(odp_pktio_t, 0)
>>
>> -#define ODP_PKTIO_ANY _odp_cast_scalar(odp_pktio_t, ~0)
>> -
>>   #define ODP_PKTIO_MACADDR_MAXSIZE 16
>>
>>   /** Get printable format of odp_pktio_t */
>> --
>> 2.1.1
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index a0a2c12..4971108 100644
--- a/include/odp/api/packet_io.h
+++ b/include/odp/api/packet_io.h
@@ -58,11 +58,6 @@  extern "C" {
  */
 
 /**
- * @def ODP_PKTIO_ANY
- * odp_pktio_t value to indicate any port
- */
-
-/**
  * @def ODP_PKTIO_MACADDR_MAXSIZE
  * Minimum size of output buffer for odp_pktio_mac_addr()
  * Actual MAC address sizes may be different.
diff --git a/platform/linux-generic/include/odp/plat/packet_io_types.h b/platform/linux-generic/include/odp/plat/packet_io_types.h
index 25f7151..934d7de 100644
--- a/platform/linux-generic/include/odp/plat/packet_io_types.h
+++ b/platform/linux-generic/include/odp/plat/packet_io_types.h
@@ -42,8 +42,6 @@  typedef struct odp_pktout_queue_t {
 
 #define ODP_PKTIO_INVALID _odp_cast_scalar(odp_pktio_t, 0)
 
-#define ODP_PKTIO_ANY _odp_cast_scalar(odp_pktio_t, ~0)
-
 #define ODP_PKTIO_MACADDR_MAXSIZE 16
 
 /** Get printable format of odp_pktio_t */